[Koha-bugs] [Bug 10419] There is no cronjob script for deleting patrons

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419

--- Comment #6 from Kyle M Hall <kyle.m.hall at gmail.com> ---
Looks good, but I've a few suggestions:

1) I'd switch from --dry-run to --confirm. This seems to be a more standard way
to do things ( in so far as a number of scripts have --confirm and none have
--dry-run ).

2) The script has "first person" style output, whereas no other Koha cli
scripts do. It might be better to remove the "I"s from the script output

3) The use of the "date" program in the example output, while clever and a
great idea, makes the help a bit confusing and hard to read. It would be better
to juse put hard dates in the example usage, and a short explanation on how to
use `date` to autogenerate the dates.

-- 
You are receiving this mail because:
You are watching all bug changes.