[Koha-bugs] [Bug 10258] Remove erroneous call to haspermission in basket.pl

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10258

--- Comment #5 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to comment #3)
> Marcel, Does the following code fix the problem?
> 
> -    my $member = GetMember(borrowernumber => $loggedinuser);
> -    if ($basket->{closedate} && haspermission({ acquisition =>
> 'group_manage'} )) {
> +    my $member = GetMember(borrowernumber => $loggedinuser)->{userid};
> +    if ($basket->{closedate} && haspermission($uid, { acquisition =>
> 'group_manage'} )) {

Hi Jonathan,
What I meant with adding the userid is not the solution, is what you propose
here. I think that if you do this, you need to change the template too.

With your patch, a user without this permission sees the button Change group
and in the combo Add new group. If he clicks the button, he gets a login form
warning him about permissions. I would not opt for that. Perhaps it would be
better to remove the combo and button in this case; more friendly.

Can I obsolete your patch now and let you do this in a qa followup?
Thanks.

-- 
You are receiving this mail because:
You are watching all bug changes.