[Koha-bugs] [Bug 10329] Rename system preference marcflavour to MarcFormat

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10329

--- Comment #4 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Your changes in updatedatabase need correction too (two updates!!)

+$DBversion = "3.13.00.XXX";
+if ( CheckVersion($DBversion) ) {
+    $dbh->do("UPDATE systempreferences SET variable = 'marcflavour' WHERE
variable = 'marcflavour'");
+    print "Upgrade to $DBversion done (Bug 10329 - Rename system preference
marcflavour to marcflavour)\n";
+    SetVersion ($DBversion);
+}
+
 $DBversion = "3.00.00.009";
 if (C4::Context->preference("Version") < TransformToNum($DBversion)) {

@@ -3259,7 +3266,7 @@ if (C4::Context->preference("Version") <
TransformToNum($DBversion)) {
     $dbh->do(qq{
     ALTER TABLE deleteditems ADD UNIQUE INDEX deleteditemsstocknumberidx
(stocknumber);
     });
-    if (C4::Context->preference('marcflavour') eq 'UNIMARC'){
+        if (C4::Context->preference('marcflavour') eq 'UNIMARC'){
         $dbh->do(qq{
     INSERT IGNORE INTO marc_subfield_structure (frameworkcode,tagfield,
tagsubfield, tab, repeatable, mandatory,kohafield)
     SELECT DISTINCT (frameworkcode),995,"j",10,0,0,"items.stocknumber" from
biblio_framework ;
@@ -6971,6 +6978,13 @@ if(CheckVersion($DBversion)) {
     SetVersion ($DBversion);
 }

+$DBversion = "3.13.00.XXX";
+if ( CheckVersion($DBversion) ) {
+   $dbh->do("UPDATE systempreferences SET variable = 'MarcFormat' WHERE
variable = 'marcflavour'");
+   print "Upgrade to $DBversion done (Bug 10329 - Rename system preference
marcflavour to MarcFormat)\n";
+   SetVersion ($DBversion);

I did get two lines indeed when running this:
    Upgrade to 3.13.00.XXX done (Bug 10329 - Rename system preference
marcflavour to marcflavour)
    Upgrade to 3.13.00.XXX done (Bug 10329 - Rename system preference
marcflavour to MarcFormat)

-- 
You are receiving this mail because:
You are watching all bug changes.