[Koha-bugs] [Bug 10428] undefined check in add additem.pl

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10428

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gmcharlt at gmail.com

--- Comment #5 from Galen Charlton <gmcharlt at gmail.com> ---
(In reply to comment #0)
> In additem.pl, in the code that generates item form you find : 
> @values = $itemrecord->field($tag)->subfield($subtag) if ($itemrecord &&
> defined($itemrecord->field($tag)->subfield($subtag)));
> 
> This code is missing the check of $itemrecord->field($tag) undef.
> I did not found a way to test it because item tag is always defined when
> editing an item, but it would be safer/prettier to add this check.

Just double-checking: did you run into any situation where the absence of the
test resulted in a user-visible problem?

It occurs to me that intentionally damaging the contents of the LastCreatedItem
cookie would be a way of exercising this patch.

-- 
You are receiving this mail because:
You are watching all bug changes.