[Koha-bugs] [Bug 10441] UT: Testing AddShare in VirtualShelves.t

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10441

--- Comment #3 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to comment #2)
> I'm not disputing the test itself, but wouldn't it be nice if AddShare
> returned something to indicate sucsess/failure?

Thanks for testing.
First of all, you are right of course.
By far, we are not testing the success of mysql insert statements in Koha. In
some cases it is done (saw one when e.g. adding a biblio); note that AddShare
is not the most critical operation :) AddShare could however simply check DBI's
err and return a boolean.
Will leave the two reports as they are now for the moment, but will later
handle this in a followup.

-- 
You are receiving this mail because:
You are watching all bug changes.