[Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being "no", "yes", "force"

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825

--- Comment #63 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to comment #62)
> It looks like there is a value conflict here. The database update is
> assuming the syspref value of '1' should be converted to 'yes', but the code
> is still assuming it that it is '1'. 
> 
> I think leaving 'no' as an empty value makes the template code cleaner, but
> I think it would be better to keep the alteration of '1' to 'yes'. However,
> it's probably much easier to alter the database update, so I wouldn't fail
> qa just for keeping '1' instead of 'yes'.
> 
> I hope this makes sense!

Hum... whaou, not easy to understand :)
In fact "yes" and "no" are "transformed" to 1 and "" (see comment 15 and bug
7854).
So if we want to have 1 and 0 in DB, we will got "1", "0" and "force" which is
not really cleaner I think.
We cannot set "yes", "no" and "force" in the DB and to test strings ("yes",
"no", "force") in the template.

-- 
You are receiving this mail because:
You are watching all bug changes.