[Koha-bugs] [Bug 10454] New: Failure to lock could generate duplicate card numbers

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10454

            Bug ID: 10454
           Summary: Failure to lock could generate duplicate card numbers
    Classification: Unclassified
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: mtompset at hotmail.com
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

In C4::Members.pm there is a function AddMembers_Opac which calls
fixup_cardnumber. The problem is there is no locking to ensure that someone
else doesn't add a member at the same time and create a duplicate card number.

This patch adds the missing locking in. I've left commented wait code in, so
that the person testing this can switch tabs or browsers to test that the
locking doesn't catastrophically break things.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.