[Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being "no", "yes", "force"

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825

--- Comment #78 from Kyle M Hall <kyle at bywatersolutions.com> ---
Everything looks good, though we still have a lack of a decent commit message.
Perhaps this will do:

Currently, the Koha system preference OPACItemHolds allows a library system to
choose to allow patrons to place bib and item level holds from the OPAC, or to
allow patrons only to place bib level holds only from the opac. 

This patch set adds a third option, "force", which *requires* that patrons
place item level holds from the opac, with no option of making a bib level
hold.

This patch modifies the system preference OPACItemHolds to be of the type
"Choice", with the choices being "no", "yes", "force". The patch does not alter
the currently set value of OPACItemHolds for database updates, only adding the
additional option.

Test Plan:
1) Set OPACItemHolds to "no". Check that OPAC holds behave as it is now (no
"Place On" column, no "Select a specific copy" table, making a reserve is
successful)
2) Set OPACItemHolds to "yes". Check that OPAC holds behave as it is now (
"Place On" column is there, "Select a specific copy" table shows when "A
specific copy" is selected, making a reserve is successful)
3) Set OPACItemHolds to "force". Check that OPAC holds behave as follows:
  -  no "Place On" column is present
  -  "Select a specific copy" table is opened
  -  making a reserve is successful

-- 
You are receiving this mail because:
You are watching all bug changes.