[Koha-bugs] [Bug 10466] Lists: Use "size" as names/hash keys leads to an unexpected results when using Template::Toolkit (name of a virtual method there)

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Jun 14 11:22:37 CEST 2013


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10466

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #5 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
QA Comment:
One line patch fixes a small problem.
Altough we could indeed solve this problem even better by replacing size with
something else, this fix deserves to be pushed if it were only for the commit
message and test plan :)
Additionally, there is at least one other place where this same problem is also
solved in this same way (and was pushed before..)

Note that I took the liberty to amend with a small comment at the end of your
line about the reason you explained so thoroughly in the commit message.

Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list