[Koha-bugs] [Bug 10332] UT: CourseReserves.t needs to create its own data

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10332

--- Comment #20 from Kyle M Hall <kyle at bywatersolutions.com> ---
I bet you're right. Thanks!

Kyle

(In reply to comment #19)
> (In reply to comment #18)
> > Thanks for the followup Jonathan! Everything looks, except koha-qa.pl fail
> > because there is no use strict ( or use Modern::Perl ). Could you amend your
> > followup to include one of those. After that I think it will be good to pass
> > QA!
> > 
> > FAIL   t/db_dependent/CourseReserves.t
> >    OK     pod
> >    OK     forbidden patterns
> >    OK     valid
> >    FAIL   critic # TestingAndDebugging::RequireUseStrict: Got 1 violation(s).
> 
> Kyle,
> Looks good here:
> $ qa -c 2 -v 2
> testing 2 commit(s) (applied to 77a5e3e 'Bug 10439: fix bug preventing the
> lib')
> 
>  OK	t/db_dependent/CourseReserves.t
>    OK	  pod
>    OK	  forbidden patterns
>    OK	  valid
>    OK	  critic
> 
> the file contains "use Modern::Perl;".
> 
> Your t/perlcriticrc (Koha src) file should contain
> [TestingAndDebugging::RequireUseStrict]
> equivalent_modules = Modern::Perl
> 
> [TestingAndDebugging::RequireUseWarnings]
> equivalent_modules = Modern::Perl
> 
> Maybe your qa tools repository is not up-to-date.

-- 
You are receiving this mail because:
You are watching all bug changes.