[Koha-bugs] [Bug 9998] Import/export and compare system preferences

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9998

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
         QA Contact|                            |jonathan.druart at biblibre.co
                   |                            |m

--- Comment #11 from Jonathan Druart <jonathan.druart at biblibre.com> ---
QA comment:

Just some minor things:
1/ I hate the $_ variable loop... :)
2/ the die would be replaced with pod2usage
3/ pod2usage has a message param (in order to display "No filename given",
etc.)
4/ I think that "verbose => 1" would be more appropriate for warning messages.
5/ use Modern::Perl instead of warnings ad strict

I don't know if it is blocker. Let the RM takes the decision.
Marked as Passed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.