[Koha-bugs] [Bug 9288] Add a script to test SIP from the command line

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9288

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Failed QA
                 CC|                            |gmcharlt at gmail.com

--- Comment #13 from Galen Charlton <gmcharlt at gmail.com> ---
This looks like this could become the core of a Nagios check for the SIP
server.

However, it doesn't work for me, as it hangs after sending the 93 login
message, never receiving the response.  I tested with both an Evergreen SIP
server and a Koha one.

Tacking on the following line will probably make it work:

    $/ = "\r";

However, since not all SIP devices agree on the terminator character, even
better would be to use something other than <$socket> to fetch from the socket.

Also, this patch would introduce new code that violates PERL2:

http://wiki.koha-community.org/wiki/Coding_Guidelines#PERL2:_Modern::Perl.

While perhaps a little laxity on the coding guidelines might be OK for test
code, I'm drawing a firm line in the sand regarding PERL2: all new code *must*
have strictures and warnings enabled.

Or be accompanied by a note signed by Larry Wall _and_ Damien Conway explaining
in detail why strictures and warnings should be turned off. :)

-- 
You are receiving this mail because:
You are watching all bug changes.