[Koha-bugs] [Bug 9836] Filtering sort1 list according to patron category in patron data

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9836

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m
           Assignee|koha-bugs at lists.koha-commun |koha at univ-lyon3.fr
                   |ity.org                     |

--- Comment #15 from Jonathan Druart <jonathan.druart at biblibre.com> ---
QA comment:

There is a design issue in this patch:
First, you add a column in a sql table only for some rows (in this case for
categorycode=Bsort1).
Then, multiple values are added into this column (you lost the foreign key to
the patron categories).
I don't like to say that but maybe a syspref is much more appropriate here.

Ergonomic issue:
A new column is added in the authorised values table, but the header only
exists for the Bsort1 category. So there is a shift in others categories.

Looking at the code:
1/ You use an unused tt variable (looploop).
2/
-          SELECT  id, category, authorised_value, lib, lib_opac, imageurl
+          SELECT *
It is preferable to enumerate fields.

Marked as Failed QA.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.