[Koha-bugs] [Bug 10494] New: KohaBranchName sends useless warnings to log if supplied library code is null or not present

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10494

            Bug ID: 10494
           Summary: KohaBranchName sends useless warnings to log if
                    supplied library code is null or not present
    Classification: Unclassified
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: gmcharlt at gmail.com

If the library code passed to the KohaBranchName Template Toolkit plugin is
NULL or isn't present in the database (which can happen, legitimately, in
suggestion management), spurious warnings can get logged.

For example, here's one that gets displayed when viewing purchase suggestions
in the staff interface if any of the suggestions have branchcode either NULL or
set to '__ANY__'.

[Wed Jun 19 07:13:06 2013] [error] [client 192.168.1.10] [Wed Jun 19 07:13:06
2013] suggestion.pl: Use of uninitialized value in concatenation (.) or string
at
/home/gmc/koha/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
line 487., referer:
http://koha-staff.metaquarry/cgi-bin/koha/acqui/acqui-home.pl

Rather than return undef in such cases, the plugin should return the empty
string.

-- 
You are receiving this mail because:
You are watching all bug changes.