[Koha-bugs] [Bug 10495] t/db_dependent/HoldsQueue.t can fail unnecessarily

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10495

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

--- Comment #2 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Galen,
I got a bad news, with my DB tests, I have a bad news, with your patch I get:

  t/db_dependent/HoldsQueue.t .. 1/18 Use of uninitialized value
$borrower_branchcode in string ne at t/db_dependent/HoldsQueue.t line 36.   
  Use of uninitialized value $borrower_branchcode in string ne at
t/db_dependent/HoldsQueue.t line 36.
  [...]
  Use of uninitialized value $borrower_branchcode in string ne at
t/db_dependent/HoldsQueue.t line 36.
  Use of uninitialized value $borrower_branchcode in join or string at
t/db_dependent/HoldsQueue.t line 48.
  DBD::mysql::st execute failed: Column 'frombranch' cannot be null at
t/db_dependent/HoldsQueue.t line 55.
  DBD::mysql::st execute failed: Column 'frombranch' cannot be null at
t/db_dependent/HoldsQueue.t line 55.
  # Looks like you planned 18 tests but ran 2.
  # Looks like your test exited with 255 just after 2.
  t/db_dependent/HoldsQueue.t .. Dubious, test returned 255 (wstat 65280,
0xff00)
  Failed 16/18 subtests 

  Test Summary Report
  -------------------
  t/db_dependent/HoldsQueue.t (Wstat: 65280 Tests: 2 Failed: 0)
    Non-zero exit status: 255
    Parse errors: Bad plan.  You planned 18 tests but ran 2.
  Files=1, Tests=2,  0 wallclock secs ( 0.01 usr  0.01 sys +  0.43 cusr  0.02
csys =  0.47 CPU)
  Result: FAIL

But I have a good one, if I apply 10336 before yours, I get:
  t/db_dependent/HoldsQueue.t .. ok     
  All tests successful.
  Files=1, Tests=18,  0 wallclock secs ( 0.03 usr  0.00 sys +  0.53 cusr  0.06
csys =  0.62 CPU)
  Result: PASS

So I will sign off this one! Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.