[Koha-bugs] [Bug 8798] Add the use of DBIx::Class

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798

--- Comment #67 from Kyle M Hall <kyle at bywatersolutions.com> ---
> Jonathan & I had a short discussion about this patch & DBIC: we have the
> same question: what's the next step once this patch is pushed ? We need to
> have clear directions, in order to coordinate the effort & do as much
> progress as possible in DBIC.

This a good question! I've already submitted a patch that uses DBIC, Bug 10493.
It's interesting because I started writing using the standard C4 and Koha
modules, but I was extremely surprised to find how much easier and quicker the
development went once I switched to DBIC!

I think we need to push as much logic into the DBIC classes as we can ( only
the logic which sensibly should be there or course ). For example, I'm sure
Koha::Schema::Result::Borrower is ripe for additional logic.
C4::Members::IsMemberBlocked() could easily be replaced with
$borrower->IsBlocked(). 

> PS: from a QA point of view, am I right if I say that those patches need to
> be merged in one patch, otherwise they're quite hard to understand ?
> the schema is made, then updated. we put something in C4/Context.pm, then
> remove it to create Koha/Database.pm

The only issue I see is we have 3 authors here. Elliot is no longer active in
the community so I cannot speak for him, though I'm sure we can contact him
about it. If a merge before push is necessary, I'd say he should retain the
authorship line, considering this was originally his patch.

On the other hand, a squashed patch could be uploaded for QA purposes, and the
individual patches pushed afterward. I think that should provide the QA clarity
while retaining individual patch authorship.

-- 
You are receiving this mail because:
You are watching all bug changes.