[Koha-bugs] [Bug 10483] check_uniqueness.pl does not work

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10483

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #19075|0                           |1
        is obsolete|                            |

--- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 19184
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19184&action=edit
Bug 10483 - check_uniqueness.pl does not work

When syspref "UniqueItemFields" is defined, the item uniqueness is tested in
acquisition by an Ajax call to check_uniqueness.pl.
I noticed that it does not work, item is always created without alert even on
existing barcode.

I have looked in perl debug mode and found that in check_uniqueness.pl :
    my $input = new CGI;
    my @field = $input->param('field');
    my @value = $input->param('value');
@field and @value are always empty.
It is because in CGI the params are named "field[]" and "value[]".
It seems to be because of the ajax serialization of a Javascript Array.
This patch corrects this bug.

Test plan :
- Select an existing item with barcode
- Add "barcode" to "UniqueItemFields" syspref (use space as separator for
multiple values)
- Set "AcqCreateItem" syspref to "Create an item when placing an order"
- Go to an acquisition basket
- Create a new order from empty
- Enter existing barcode in item form and save
=> You get an alert that barcode already exists and order is not saved
- Enter a non-existing barcode in item form and save
=> Order and item are created

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.