[Koha-bugs] [Bug 10380] output_pref should use a hashref for parameters

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Jun 21 15:25:28 CEST 2013


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10380

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #18597|0                           |1
        is obsolete|                            |

--- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 19188
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19188&action=edit
Bug 10380: Change prototype for output_pref routine

Koha::DateUtils::output_pref takes 4 parameters and the last one is a
boolean, so some calls are:
  output_pref($dt, undef, undef, 1)

This patch changes it prototype to
  output_pref({
    dt => $dt,
    dateformat => $dateformat,
    timeformat => $timeformat,
    dateonly => $boolean
  });
an alternative is to call the output_pref routine with a datetime
object, without using an hashref:
  output_pref($dt);

Signed-off-by: Srdjan <srdjan at catalyst.net.nz>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list