[Koha-bugs] [Bug 8798] Add the use of DBIx::Class

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Jun 21 16:55:33 CEST 2013


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798

--- Comment #70 from Galen Charlton <gmcharlt at gmail.com> ---
(In reply to comment #66)
> (In reply to comment #60)
> > Chris and I discussed this bug today and he's agreed to update the patch
> > series for master; I intend to push DBIC support unless some showstopper
> > comes up during QA and testing.
> Jonathan & I had a short discussion about this patch & DBIC: we have the
> same question: what's the next step once this patch is pushed ? We need to
> have clear directions, in order to coordinate the effort & do as much
> progress as possible in DBIC.

What I propose is a multi-part process:

[1] Once DBIC support is pushed, along with at least one other patch that uses
it, we promote the existence of it vigorous, with the aim of encouraging folks
to use it for new functionality even *before* KohaCon.  I agree that seminars
there would be a good idea, too.

I think it would be a reasonable goal to get to the point where, once the cycle
for 3.16 starts, DBIC is required for any new code that interacts with the
database.  That can't be a requirement for 3.14, of course, but we can
certainly encourage it.

[2] I agree that we should make a concerted effort to switch existing code over
to DBIC, but with a *very* strong caveat: I am disinclined to push patches that
refactor code to use DBIC that are not backed up by unit tests first.  There
will be some trickiness in writing such tests, of course, since switching
functionality to DBIC also means restructuring the API, but I have very little
tolerance for user-visible regressions in the name of architectural
improvements, no matter how important.

However, one question that has to be answered first: who has time to commit to
systematically refactoring existing code?  An answer to that would inform
future planning.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list