[Koha-bugs] [Bug 8798] Add the use of DBIx::Class

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798

--- Comment #71 from Paul Poulain <paul.poulain at biblibre.com> ---
(In reply to comment #70)
> What I propose is a multi-part process:
> 
> [1] Once DBIC support is pushed, along with at least one other patch that
> uses it, we promote the existence of it vigorous, with the aim of
> encouraging folks to use it for new functionality even *before* KohaCon.  I
> agree that seminars there would be a good idea, too.
+1
> I think it would be a reasonable goal to get to the point where, once the
> cycle for 3.16 starts, DBIC is required for any new code that interacts with
> the database.  That can't be a requirement for 3.14, of course, but we can
> certainly encourage it.
+1, even if the big deal here will be to mix DBIC & C4/ code: I want to add a
feature that could use C4/Acquisition.pm::whatever. Should I write a
Koha/BusinessLogic::whatever_for_DBIC anyway ? I don't see an clear answer to
this question. If I answer yes, then it mean there are 2 "whatever" functions,
that will be a pain to maintain.

> [2] I agree that we should make a concerted effort to switch existing code
> over to DBIC, but with a *very* strong caveat: I am disinclined to push
> patches that refactor code to use DBIC that are not backed up by unit tests
> first.  There will be some trickiness in writing such tests, of course,
> since switching functionality to DBIC also means restructuring the API, but
> I have very little tolerance for user-visible regressions in the name of
> architectural improvements, no matter how important.
in my tests on bug 8309, I started with some basic admin/ scripts. I think it's
a good way to start, because there is only a few dependencies, and a lot of
things that are not in any C4/ file already.

> However, one question that has to be answered first: who has time to commit
> to systematically refactoring existing code?  An answer to that would inform
> future planning.
+1
Next week, there's the yearly french kohacon, I plan to speak openly of this
problem: we need time, and, as everyone knows, time is money (I need to pay
BibLibre staff you know... what a pity :D ).
I think we should also speak of this during KohaCon13

-- 
You are receiving this mail because:
You are watching all bug changes.