[Koha-bugs] [Bug 8798] Add the use of DBIx::Class

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798

--- Comment #73 from Galen Charlton <gmcharlt at gmail.com> ---
Paste of an IRC conversation with the maintainer of DBIX::Class today:

<riba> I wanted to comment on
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798 but didn't find a
way without creating yet another account
<huginn> Bug 8798: enhancement, P3, ---, elliott, Signed Off , Add the use of
DBIx::Class
<-> riba is now known as Guest688
<-> Guest688 is now known as ribasushi
<ribasushi> wtf..
<ribasushi> anyway - is any of the bug participants around?
<jcamins> ribasushi: I think gmcharlt, khall, and paul_p have been discussing
that recently.
<paul_p> ribasushi yes, I'm here
<ribasushi> hi
<-- lds (~Thunderbi at giono.biblibre.com) has quit (Quit: lds)
<paul_p> hi ribasushi
<gmcharlt> hi ribasushi
<ribasushi> paul_p: I am the current-long-standing DBIC maint
<ribasushi> I am excited you guys are migrating DBIC wholesale - I need more
such success stories to brag about ;D
<ribasushi> I looked over some of the diffs and there's one thing that jumped
at me as very wrong
--> lds (~Thunderbi at giono.biblibre.com) has joined #koha
<paul_p> ribasushi well, we've got the decision, some nice hackers, what we
lack is time (or money, but that's almost the same thing : I could dedicate 2
FTE to this task if I had enough money...)
<paul_p> ribasushi which mistake ?
<ribasushi> you have set (in many places) ...
<ribasushi> I am looking for it, lost the diff...
<-- chris_n (~Chris at 184.7.21.42) has quit (Quit: Coyote finally caught me)
<ribasushi> $ENV{'DBIC_DONT_VALIDATE_RELS'} <- you set this all over the place
<ribasushi> it was introduced as a backcompat measure for folks with broken
preexisting schema definitions
<ribasushi> in *new code* this is a sign of a latent data eater
--> Callender (~quassel at 50-79-238-214-static.hfc.comcastbusiness.net) has
joined #koha
<ribasushi> you need to resolve the cause of this (whatever it may actually be)
before "going public" with a call for conversions
--> chris_n (~Chris at 184.7.21.42) has joined #koha
*** Mode #koha +o chris_n by ChanServ
<gmcharlt> ribasushi: we were figuring that corrections to the schema were
needed anyway
<gmcharlt> but could you expand on what you mean by "latent data eater"?
<ribasushi> the presence of this warning implies an incorrectly set metadata on
the source in question
<ribasushi> most likely the "direction" of the relationship is reversed
<-> Jesse_phone is now known as JesseM
<ribasushi> the higher the DBIC version - the more I rely on the correctness of
such metadata to make informed decisions on the SQL I generate
<ribasushi> for instance an incorrect relationship direction may end up in a
cascaded delete going in a way that you never anticipated
<ribasushi> or an entire JOIN being dropped away because DBIC can "prove"
(based on the erroneous metadata) that it does not need it
<gmcharlt> gah
<gmcharlt> thanks for the warning
<ribasushi> because this stuff happens deep in the guts the consequences may
compound to something I can't currently think of
<paul_p> ribasushi = am I right if I say "adding this will hide any error in
your schema, and that's a bad idea, better fixing the schema" ?
<ribasushi> on the other hand - I *never* rely on metadata blindly, unless I
can provide a reasonable (and timely) warning way in advance "hey your schema
metadata makes no sense!"
<ribasushi> gmcharlt: so I am not taking the risk lightly, but there is only so
much I can do ;)
<ribasushi> paul_p: "any error" is a tad strong, "a number of errors" would be
more correct
<ribasushi> paul_p: also s/better fixing/we have to fix/
<gmcharlt> ribasushi: well, we'll take that out of the patch and exercise it
more
<ribasushi> I am sadly not much around IRC lately (life happens etc)
<ribasushi> but I am always available with a reasonable turnaround at
ribasushi at cpan.org
--> pianohacker (~feoh3 at vps.lanfort.org) has joined #koha
<ribasushi> so feel free to contact me if more issues arise
<ribasushi> gmcharlt: ^^
<ribasushi> paul_p: ^^
<gmcharlt> great -- and thanks for taking the time to look it over
<paul_p> ribasushi we'll probably ask for some hints later ;-)
<gmcharlt> ribasushi: do you have any objections to my pasting this
conversation into the bug report? (the channel is logged anyway, to be clear)
<ribasushi> gmcharlt: not at all
<-- lds (~Thunderbi at giono.biblibre.com) has quit (Quit: lds)
<gmcharlt> thanks
<ribasushi> gmcharlt: I'd also grp for other ENV overrides
<ribasushi> in case I missed something (it's a lot of code ;)
<ribasushi> *grep

-- 
You are receiving this mail because:
You are watching all bug changes.