[Koha-bugs] [Bug 10454] Duplicate card numbers may be generated

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10454

--- Comment #8 from Galen Charlton <gmcharlt at gmail.com> ---
Comment on attachment 19196
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19196
Bug 10454 - Duplicate card numbers may be generated

Review of attachment 19196:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10454&attachment=19196)
-----------------------------------------------------------------

This is not a complete review of the patch, which will come later, just
commenting on something that jumped out immediately.

::: kohaversion.pl
@@ +16,4 @@
>  use strict;
>  
>  sub kohaversion {
> +    our $VERSION = '3.13.00.XXX';

There is no need to kohaversion.pl -- the RM takes care of updating that any
time a DBrev is pushed -- and leaving it in the patch just creates the
potentially for merge conflict noise.

-- 
You are receiving this mail because:
You are watching all bug changes.