[Koha-bugs] [Bug 8798] Add the use of DBIx::Class

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #85 from Paul Poulain <paul.poulain at biblibre.com> ---
OK, I gave this patch a try, because DBIx::Class is where we want to go in the
long term, so it's worth the effort
(plus, I'm stuck in a train that is 2 hours late, soon 3 hours, so I will have
9 hours in a train...)

QA comments :
 * I've squashed the 4 previous patches, it's much easy to read the code, the
authorship is still here
 * I think the  "C4/Context.pm   |    1 - "should be removed, it's just
removing an empty line
 * unless i'm wrong, the  "t/Context.t  |   10 +" is not related to
DBIx::Class. It's a good idea to have it, but please put it in another patch

But's theres more: I wrote a patch to implement a 1st version of Branch.pm
(BusinessLogic, DataObject, DB), then made 2 other patches to see how it
behaves.
It's nice & handy.
BUT : there's some diacritics in my database, and they're not properly handled.
I thought I had found the solution, but got no success.

This problem must be fixed before the initial patch is pushed.

HTH

-- 
You are receiving this mail because:
You are watching all bug changes.