[Koha-bugs] [Bug 10442] Remove references to non-standard "error" class

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Sun Jun 30 12:01:04 CEST 2013


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10442

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #19281|0                           |1
        is obsolete|                            |

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 19296
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19296&action=edit
[PASSED QA] Bug 10442 - Remove references to non-standard "error" class

The CSS for <div class="error"> is obsolete and should not be used. This
patch removes the definition from the main CSS file and corrects
instances of its use in the templates to the standard <div class="dialog
alert">.

This patch also corrects some minor HTML validity and
capitalization errors in the changed templates.

Testing each error condition in all the modified temlates is probably
overkill for the minor changes made in this patch. Markup has simply
been changed to use alternate existing styles. Visual confirmation of
the markup changes is probably sufficient.

Signed-off-by: Liz Rea <wizzyrea at gmail.com>
confirmed the changes - no obvious errors, functionality seems fine.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Passes all tests and QA script.
I read the changes and did a few tests in Koha.
Some of the error conditions are pretty hard to reproduce,
I did manage for lateorders, but didn't succeed for memberentrygen
and parcel. But changes appear to be save and I spotted no problems,
so passing QA.

Patch also fixes a few capitalization errors.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list