From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 00:26:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Feb 2013 23:26:57 +0000 Subject: [Koha-bugs] [Bug 9736] New: Add CSS classes to OPAC items table to allow better styling and JS manipulation Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9736 Bug ID: 9736 Summary: Add CSS classes to OPAC items table to allow better styling and JS manipulation Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: robin at catalyst.net.nz Currently there are none, but there are in the staff client. This'll make them match up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 00:27:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Feb 2013 23:27:05 +0000 Subject: [Koha-bugs] [Bug 9736] Add CSS classes to OPAC items table to allow better styling and JS manipulation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9736 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |robin at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 01:02:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 00:02:15 +0000 Subject: [Koha-bugs] [Bug 9322] If multiple transfers exist (from circ/branchtransfers.pl), completing one completes them all In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9322 --- Comment #14 from Galen Charlton --- And while we're in the area ... this would be a good time to assign a numeric PK to branchtransfers. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 01:08:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 00:08:19 +0000 Subject: [Koha-bugs] [Bug 9663] Individual bibliographic record "Save" option requires export permission In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9663 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Jared Camins-Esakov --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 01:11:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 00:11:38 +0000 Subject: [Koha-bugs] [Bug 5333] Undefined value stops import from z39.50 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5333 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #10 from Jared Camins-Esakov --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 01:14:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 00:14:58 +0000 Subject: [Koha-bugs] [Bug 9669] Replace YUI buttons on staff client cart toolbar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9669 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Jared Camins-Esakov --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 01:16:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 00:16:23 +0000 Subject: [Koha-bugs] [Bug 9555] Template files contain single quote strings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9555 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Jared Camins-Esakov --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 01:19:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 00:19:39 +0000 Subject: [Koha-bugs] [Bug 9445] Use DataTables in local use system preferences editor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9445 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #7 from Jared Camins-Esakov --- This patch adds Datatables, but it does not remove tablesorter from the page. It probably should. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 01:30:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 00:30:57 +0000 Subject: [Koha-bugs] [Bug 3549] Framework sorting in addbook In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3549 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #13 from Jared Camins-Esakov --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 01:33:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 00:33:44 +0000 Subject: [Koha-bugs] [Bug 8740] Serials Claims should be exportable all at once In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8740 MJ Ray (software.coop) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12155|0 |1 is obsolete| | --- Comment #4 from MJ Ray (software.coop) --- Created attachment 15788 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15788&action=edit enh bug 8740 Serials Claims should be exportable all at once Test plan: 1. Visit Serials: Claims and look at the vendor list drop-down 2. select All 3. click OK 4. export them all -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 01:35:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 00:35:49 +0000 Subject: [Koha-bugs] [Bug 8740] Serials Claims should be exportable all at once In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8740 MJ Ray (software.coop) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15788|0 |1 is obsolete| | --- Comment #5 from MJ Ray (software.coop) --- Created attachment 15789 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15789&action=edit enh bug 8740 Serials Claims should be exportable all at once Test plan: 1. Visit Serials: Claims and look at the vendor list drop-down 2. select All 3. click OK 4. export them all -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 01:39:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 00:39:54 +0000 Subject: [Koha-bugs] [Bug 8740] Serials Claims should be exportable all at once In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8740 MJ Ray (software.coop) changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #6 from MJ Ray (software.coop) --- I've rebased this and changed a == to an eq to avoid the warnings. I have not set the "all suppliers" value with -1 because I dislike magic numbers and it is possible (but unlikely unless you mess with the database directly) to have a vendor with id -1 which would become unselectable alone. I ask for reviews and maybe new signoffs, please. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 01:41:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 00:41:55 +0000 Subject: [Koha-bugs] [Bug 9456] Add callnumber column to the cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #22 from Jared Camins-Esakov --- I am a little bit doubtful about pushing this patch as-is. Although the sorting seems to work, it becomes hard to tell what item belongs to which library, and even where the call numbers begin and end: http://screencast.com/t/meDgCBj3Rwm Is there some way we can group information about each item together so that it's possible to follow? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 01:56:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 00:56:15 +0000 Subject: [Koha-bugs] [Bug 9458] Add sorting to lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9458 --- Comment #24 from Jared Camins-Esakov --- Comment on attachment 15675 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15675 Bug 9458 - Add sorting to lists - QA Followup Review of attachment 15675: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=9458&attachment=15675) ----------------------------------------------------------------- ::: C4/VirtualShelves/Page.pm @@ +249,4 @@ > my $items; > my $tag_quantity; > my $sortfield = ( $sorton ? $sorton : 'title' ); > + $sortfield = $query->param('sort') || $sortfield || 'title'; ## Passed in sorting overrides default sorting I am a little bit perplexed by this line. Why did you add the || 'title' when $sortfield has already been set? Or, equivalently, why did you set $sortfield previously? I would have thought the simplest way to get the desired results would be: my $sortfield = $query->param('sort') || $sorton || 'title'; My chief concern is, is there some sort of side-effect in the code that you're trying to work around with this? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 02:18:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 01:18:25 +0000 Subject: [Koha-bugs] [Bug 9736] Add CSS classes to OPAC items table to allow better styling and JS manipulation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9736 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Robin Sheat --- Looks like bug 8597 beat me to it. *** This bug has been marked as a duplicate of bug 8597 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 02:18:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 01:18:25 +0000 Subject: [Koha-bugs] [Bug 8597] New theme for the OPAC with a mobile view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8597 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |robin at catalyst.net.nz --- Comment #71 from Robin Sheat --- *** Bug 9736 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 02:23:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 01:23:47 +0000 Subject: [Koha-bugs] [Bug 9737] New: Local Covers sometimes appear then disappear on OPAC Search Results/Lists Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9737 Bug ID: 9737 Summary: Local Covers sometimes appear then disappear on OPAC Search Results/Lists Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: dcook at prosentient.com.au When there are bibs with local covers in the OPAC search results or in an OPAC list, they will appear for a split second and then disappear. Important Note: >From what I can tell, this only happens when "OPACAmazonCoverImages" is turned on. It also only seems to happen when an ISBN is supplied... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 02:26:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 01:26:28 +0000 Subject: [Koha-bugs] [Bug 9737] Local Covers sometimes appear then disappear on OPAC Search Results/Lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9737 --- Comment #1 from David Cook --- I think the Amazon JS is causing the problem... Since I retrieve this cover just fine: http://images.amazon.com/images/P/0764548557.01.TZZZZZZZ.jpg But when I try to get this cover, I don't get the cover and the local image disappears, even though the normalized ISBN should be valid...: http://images.amazon.com/images/P/061535243X.01.TZZZZZZZ.jpg -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 02:49:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 01:49:22 +0000 Subject: [Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043 --- Comment #13 from Srikanth Dhondi --- Hi Jonathan, I like the idea. But there are couple of issues I would like to raise 1) In the current state, the OpacAdvSearch syspref applies the same behavior to Advanced search page with both Fewer and More options. This needs to be rectified. 2) I tried unselecting/disabling a previously selected/enabled option by clicking on it, this doesn't seem to work. How does one unselect/disable one of the options from the scroll-down menu? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 03:48:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 02:48:17 +0000 Subject: [Koha-bugs] [Bug 9737] Local Covers sometimes appear then disappear on OPAC Search Results/Lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9737 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|oleonard at myacpl.org |dcook at prosentient.com.au --- Comment #2 from David Cook --- Created attachment 15790 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15790&action=edit Bug 9737 - Local Covers sometimes appear then disappear on OPAC Search Results/Lists The current problem: When the verify_images() function runs from amazonimages.js, it loops through every img element and selects the elements that come from Amazon sources. However, if the height/width is 1 (i.e. Amazon passes off a blank image) or if the img element's complete property is null or non-existent, then it searches for the parent node and re-writes the HTML with the "No Cover Image Available" (NO_AMAZON_IMAGE) text, even though that parent node might contain other img elements that have images available (from Google, local images, etc)! Proposed fix: Wrap the Amazon image in a span tag (as we do with the Google and local covers), so that it re-writes the HTML within that parent span, rather than the parent anchor which contains all the other images. To test: 1) Turn on the OPACAmazonCoverImages, GoogleJackets, and OPACLocalCoverImages system preferences 2) Replace the ISBN in one of your records with 9780615352435 3) Now load a local cover image for that record 4) Search for that record (but make sure you're vague enough to have multiple search results) 5) For a split second, you may notice the local cover image appears before being replaced by a "No Cover Image Available". Now apply this patch 6) Refresh your search results page 7) You should now see your local cover image, PLUS the "No Cover Image Available" for the Amazon image, and whatever other graphics/"no cover image available" "graphics" for the Google Jackets. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 03:57:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 02:57:23 +0000 Subject: [Koha-bugs] [Bug 9737] Local Covers sometimes appear then disappear on OPAC Search Results/Lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9737 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15790|0 |1 is obsolete| | --- Comment #3 from David Cook --- Created attachment 15791 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15791&action=edit Bug 9737 - Local Covers sometimes appear then disappear on OPAC Search Results/Lists [Revised to include lists] The above comment is still valid, but this patch includes the same fix for Syndetics (which is Amazon apparently) and the OPAC Lists as well as the OPAC Search Results. For testing, duplicate the steps for the lists as well as the search results. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 08:29:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 07:29:39 +0000 Subject: [Koha-bugs] [Bug 9040] uninitialized value in concatenation error in Opac-detail.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9040 --- Comment #7 from Nu?o L?pez Ans?tegui --- (In reply to comment #6) > In which cases do you see warning messages? > > On opac-detail.pl, I just get some warnings about $ccode (Use of > uninitialized value $ccode in exists at /home/koha/src/opac/opac-detail.pl > line 534). I meant that I have written the code like the other tests, for example as the barcode code: [% IF ( itemdata_datedue ) %][% ITEM_RESULT.datedue | $KohaDates %][% END %] [% IF ( OPACShowBarcode ) %][% ITEM_RESULT.barcode %][% END %] if $ccode get a warning, must also fix it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 09:14:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 08:14:09 +0000 Subject: [Koha-bugs] [Bug 8451] Confusing and problematic double prompt for processing transfers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8451 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #9 from M. de Rooy --- QA: Looking at this one now.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 09:44:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 08:44:02 +0000 Subject: [Koha-bugs] [Bug 9445] Use DataTables in local use system preferences editor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9445 --- Comment #8 from Jonathan Druart --- (In reply to comment #7) > This patch adds Datatables, but it does not remove tablesorter from the > page. It probably should. Ho yes, good catch. I don't understand when this code is used but it should be deleted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 09:55:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 08:55:40 +0000 Subject: [Koha-bugs] [Bug 9738] New: Confirming a hold crashes on datetime duration error Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9738 Bug ID: 9738 Summary: Confirming a hold crashes on datetime duration error Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com The 'days' parameter (undef) to DateTime::Duration::new was an 'undef', which is not one of the allowed types: scalar at /usr/local/share/perl5/Params/Validate/PP.pm line 633 Params::Validate::PP::__ANON__('The \'days\' parameter (undef) to DateTime::Duration::new was...') called at /usr/local/share/perl5/Params/Validate/PP.pm line 477 Params::Validate::PP::_validate_one_param(undef, 'HASH(0x47a7ae8)', 'HASH(0x468ebe0)', 'The \'days\' parameter (undef)') called at /usr/local/share/perl5/Params/Validate/PP.pm line 336 Params::Validate::PP::validate('ARRAY(0x1607930)', 'HASH(0x47a7bf0)') called at /usr/local/share/perl5/DateTime/Duration.pm line 31 DateTime::Duration::new(undef, 'days', undef) called at /usr/local/share/perl5/DateTime.pm line 1641 DateTime::add('DateTime=HASH(0x4711608)', 'days', undef) called at /usr/share/koha/testclone/C4/Letters.pm line 609 C4::Letters::_parseletter('HASH(0x467a2e0)', 'reserves', 'HASH(0x4679c68)') called at /usr/share/koha/testclone/C4/Letters.pm line 551 C4::Letters::_substitute_tables('HASH(0x467a2e0)', 'HASH(0x13f3798)') called at /usr/share/koha/testclone/C4/Letters.pm line 499 C4::Letters::GetPreparedLetter('letter_code', 'HOLD_PRINT', 'tables', 'HASH(0x13f3798)', 'substitute', 'HASH(0x467a448)', 'branchcode', 'ZZ', 'module', ...) called at /usr/share/koha/testclone/C4/Reserves.pm line 1884 C4::Reserves::_koha_notify_reserve(154329, 1, 151000) called at /usr/share/koha/testclone/C4/Reserves.pm line 1265 C4::Reserves::ModReserveAffect(154329, 1, undef) called at /usr/share/koha/testclone/circ/returns.pl line 145 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 10:06:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 09:06:20 +0000 Subject: [Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043 --- Comment #14 from Jonathan Druart --- (In reply to comment #13) > Hi Jonathan, I like the idea. But there are couple of issues I would like to > raise > > 1) In the current state, the OpacAdvSearch syspref applies the same behavior > to Advanced search page with both Fewer and More options. This needs to be > rectified. Ok, I didn't understand what you want. New patch coming. > 2) I tried unselecting/disabling a previously selected/enabled option by > clicking on it, this doesn't seem to work. How does one unselect/disable one > of the options from the scroll-down menu? You have to press the ctrl key and click on the entry. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 10:06:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 09:06:45 +0000 Subject: [Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15547|0 |1 is obsolete| | --- Comment #15 from Jonathan Druart --- Created attachment 15792 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15792&action=edit Bug 9043: Changes to the advanced search page New syspref: OpacAdvSearch. This syspref is multivalued and you can add or remove some elements on the adv search page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 10:10:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 09:10:58 +0000 Subject: [Koha-bugs] [Bug 9040] uninitialized value in concatenation error in Opac-detail.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9040 --- Comment #8 from Jonathan Druart --- (In reply to comment #7) > (In reply to comment #6) > > In which cases do you see warning messages? > > > > On opac-detail.pl, I just get some warnings about $ccode (Use of > > uninitialized value $ccode in exists at /home/koha/src/opac/opac-detail.pl > > line 534). > > I meant that I have written the code like the other tests, for example as > the barcode code: > > [% IF ( itemdata_datedue ) %][% ITEM_RESULT.datedue | > $KohaDates %][% END %] > [% IF ( OPACShowBarcode ) %][% ITEM_RESULT.barcode > %][% END %] > > if $ccode get a warning, must also fix it. Since I cannot reproduce, I cannot help you. You can keep your code but if the error is caused by the KohaDates plugin you have to check the existence of the variable before filtering it : [% IF ( itemdata_datedue ) %][% IF ITEM_RESULT.datedue%][% ITEM_RESULT.datedue | $KohaDates %][% END %][% END %] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 10:25:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 09:25:11 +0000 Subject: [Koha-bugs] [Bug 9040] uninitialized value in concatenation error in Opac-detail.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9040 --- Comment #9 from Nu?o L?pez Ans?tegui --- (In reply to comment #8) > (In reply to comment #7) > > (In reply to comment #6) > > > In which cases do you see warning messages? > > > > > > On opac-detail.pl, I just get some warnings about $ccode (Use of > > > uninitialized value $ccode in exists at /home/koha/src/opac/opac-detail.pl > > > line 534). > > > > I meant that I have written the code like the other tests, for example as > > the barcode code: > > > > [% IF ( itemdata_datedue ) %][% ITEM_RESULT.datedue | > > $KohaDates %][% END %] > > [% IF ( OPACShowBarcode ) %][% ITEM_RESULT.barcode > > %][% END %] > > > > if $ccode get a warning, must also fix it. > > Since I cannot reproduce, I cannot help you. > You can keep your code but if the error is caused by the KohaDates plugin > you have to check the existence of the variable before filtering it : > > [% IF ( itemdata_datedue ) %][% IF > ITEM_RESULT.datedue%][% ITEM_RESULT.datedue | $KohaDates %][% END %][% > END %] Ok, but I check the existence of the variable in [% IF ( itemdata_datedue ) %] I Would not checking the same variable two times? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 10:28:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 09:28:51 +0000 Subject: [Koha-bugs] [Bug 9040] uninitialized value in concatenation error in Opac-detail.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9040 --- Comment #10 from Jonathan Druart --- (In reply to comment #9) > Ok, but I check the existence of the variable in [% IF ( itemdata_datedue ) > %] > > I Would not checking the same variable two times? itemdata_datedue is true if at least one datedue is defined in the ITEM_RESULT array. It is not the same variable at all. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 10:34:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 09:34:47 +0000 Subject: [Koha-bugs] [Bug 8451] Confusing and problematic double prompt for processing transfers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8451 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #10 from M. de Rooy --- QA Comment: This is a hard one. Also taking into account the comments of Liz and Jonathan. I do appreciate your finding a solution in this minefield :) When taking some distance from Koha and just looking at the code, the introduction of the reserve id parameter in ModReserve seems not to be a good idea. It is somewhat 'unusual' way of resolving a problem. (Please note that I understand that we are editing not-so-ideal code already..) It will not make the code more readable/maintainable(..) When going back to Koha, I also think that we should resolve the problem at another place. That is the checkin should not display two prompts (probably one adjusted prompt for this situation). When the book is checked in at the transfer branch, the transfer should be marked as arrived and at the same time the transit hold should become a waiting hold. Actually, AddReturn calls ModReserveStatus but it will update a book with priority 0 only for found="" and not for found=T. Could we resolve it there? About Liz' comment: If we want to know where the transfer was generated, we should probably add some additional field to branchtransfers. At this moment we just do not know how it was generated. So my (somewhat intuitive) recommendation would be not to push this patch in this state. I just 'arbitrarily' picked Failed QA for now. But feel free to put it in Discussion and raise a discussion on the dev list. I will send a short mail to other QA team members. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 10:35:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 09:35:49 +0000 Subject: [Koha-bugs] [Bug 8917] Track clicks to links external to Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 --- Comment #46 from Jonathan Druart --- (In reply to comment #38) > Comment on attachment 15714 [details] [review] > [SIGNED_OFF] Bug 8917 : Script to log link clicks > > Review of attachment 15714 [details] [review]: > ----------------------------------------------------------------- > > ::: opac/tracklinks.pl > @@ +65,5 @@ > > + print $cgi->redirect("/cgi-bin/koha/errors/404.pl"); # escape early > > + exit; > > +} > > + > > +sub trackclick { > > Don't we want to have this routine into a new module (in order to prevent > sql code into pl file)? Hi Chris, You didn't address this remark, isn't it relevant? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 10:43:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 09:43:21 +0000 Subject: [Koha-bugs] [Bug 9656] fines.pl creating a log file should be optional In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9656 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 10:44:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 09:44:08 +0000 Subject: [Koha-bugs] [Bug 8917] Track clicks to links external to Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 --- Comment #47 from Chris Cormack --- (In reply to comment #46) > (In reply to comment #38) > > Comment on attachment 15714 [details] [review] [review] > > [SIGNED_OFF] Bug 8917 : Script to log link clicks > > > > Review of attachment 15714 [details] [review] [review]: > > ----------------------------------------------------------------- > > > > ::: opac/tracklinks.pl > > @@ +65,5 @@ > > > + print $cgi->redirect("/cgi-bin/koha/errors/404.pl"); # escape early > > > + exit; > > > +} > > > + > > > +sub trackclick { > > > > Don't we want to have this routine into a new module (in order to prevent > > sql code into pl file)? > > Hi Chris, > You didn't address this remark, isn't it relevant? I didn't think it was, no. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 10:46:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 09:46:49 +0000 Subject: [Koha-bugs] [Bug 9040] uninitialized value in concatenation error in Opac-detail.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9040 --- Comment #11 from Nu?o L?pez Ans?tegui --- It's true, you are right...sorry, I fix it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 10:51:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 09:51:50 +0000 Subject: [Koha-bugs] [Bug 8451] Confusing and problematic double prompt for processing transfers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8451 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 10:53:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 09:53:37 +0000 Subject: [Koha-bugs] [Bug 6813] Acquistions - duplicate search across orders, suggestions and catalog In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|paul.poulain at biblibre.com |m.de.rooy at rijksmuseum.nl --- Comment #31 from M. de Rooy --- QA: Looking now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 10:55:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 09:55:05 +0000 Subject: [Koha-bugs] [Bug 8917] Track clicks to links external to Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 --- Comment #48 from Jonathan Druart --- (In reply to comment #47) > (In reply to comment #46) > > (In reply to comment #38) > > > Comment on attachment 15714 [details] [review] [review] [review] > > > [SIGNED_OFF] Bug 8917 : Script to log link clicks > > > > > > Review of attachment 15714 [details] [review] [review] [review]: > > > ----------------------------------------------------------------- > > > > > > ::: opac/tracklinks.pl > > > @@ +65,5 @@ > > > > + print $cgi->redirect("/cgi-bin/koha/errors/404.pl"); # escape early > > > > + exit; > > > > +} > > > > + > > > > +sub trackclick { > > > > > > Don't we want to have this routine into a new module (in order to prevent > > > sql code into pl file)? > > > > Hi Chris, > > You didn't address this remark, isn't it relevant? > > I didn't think it was, no. So please set out your argument, mine is the coding guidelines : http://wiki.koha-community.org/wiki/Coding_Guidelines#SQL8:_SQL_code_in_.pl_scripts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 10:59:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 09:59:41 +0000 Subject: [Koha-bugs] [Bug 9732] timestamp not updated when modifying biblio In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9732 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |chris at bigballofwax.co.nz --- Comment #2 from Chris Cormack --- This shouldn't be needed Can you check your database structure, it should be `timestamp` timestamp NOT NULL default CURRENT_TIMESTAMP on update CURRENT_TIMESTAMP, Which means MySQL will update it, can you do show create table biblio; select biblionumber,title,timestamp from biblio; +--------------+---------+---------------------+ | biblionumber | title | timestamp | +--------------+---------+---------------------+ | 1 | chris | 2012-07-01 16:21:13 | | 2 | chris 2 | 2012-06-11 23:14:39 | +--------------+---------+---------------------+ update biblio set title='test timestamp' where biblionumber=1; Query OK, 1 row affected (0.05 sec) Rows matched: 1 Changed: 1 Warnings: 0 mysql> select biblionumber,title,timestamp from biblio; +--------------+----------------+---------------------+ | biblionumber | title | timestamp | +--------------+----------------+---------------------+ | 1 | test timestamp | 2013-03-01 22:59:09 | | 2 | chris 2 | 2012-06-11 23:14:39 | +--------------+----------------+---------------------+ 2 rows in set (0.00 sec) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 11:02:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 10:02:16 +0000 Subject: [Koha-bugs] [Bug 8917] Track clicks to links external to Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 --- Comment #49 from Chris Cormack --- (In reply to comment #48) > (In reply to comment #47) > > (In reply to comment #46) > > > (In reply to comment #38) > > > > Comment on attachment 15714 [details] [review] [review] [review] [review] > > > > [SIGNED_OFF] Bug 8917 : Script to log link clicks > > > > > > > > Review of attachment 15714 [details] [review] [review] [review] [review]: > > > > ----------------------------------------------------------------- > > > > > > > > ::: opac/tracklinks.pl > > > > @@ +65,5 @@ > > > > > + print $cgi->redirect("/cgi-bin/koha/errors/404.pl"); # escape early > > > > > + exit; > > > > > +} > > > > > + > > > > > +sub trackclick { > > > > > > > > Don't we want to have this routine into a new module (in order to prevent > > > > sql code into pl file)? > > > > > > Hi Chris, > > > You didn't address this remark, isn't it relevant? > > > > I didn't think it was, no. > > So please set out your argument, mine is the coding guidelines : > http://wiki.koha-community.org/wiki/Coding_Guidelines#SQL8:_SQL_code_in_. > pl_scripts I no longer care, someone else can work on this -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 11:07:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 10:07:18 +0000 Subject: [Koha-bugs] [Bug 6813] Acquistions - duplicate search across orders, suggestions and catalog In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12714|0 |1 is obsolete| | --- Comment #32 from M. de Rooy --- Comment on attachment 12714 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12714 [SIGNED-OFF] Bug 6813: Acquistions duplicate search across orders, suggestions and catalog Obsoleting the first patch for merge conflict. Have resolved it and will send new one after applying the rest with git-bz :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 11:11:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 10:11:34 +0000 Subject: [Koha-bugs] [Bug 6813] Acquistions - duplicate search across orders, suggestions and catalog In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14009|0 |1 is obsolete| | --- Comment #33 from M. de Rooy --- Comment on attachment 14009 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14009 Bug 6813 follow-up, fix POD Obsoleting this one too. Failed, will amend the last patch for this edit. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 11:27:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 10:27:13 +0000 Subject: [Koha-bugs] [Bug 6813] Acquistions - duplicate search across orders, suggestions and catalog In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813 --- Comment #34 from M. de Rooy --- QA Comment: Amit or Savitra, Some comments have been given already. So I will not repeat them all. But I like the idea of your new tool! FindBiblios works with sql statements. That is a risk for performance. I think (like Paul) that this tool should not be in Acquisitions. Could you place it under .. Tools ? Please send a followup and I will continue on that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 11:27:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 10:27:51 +0000 Subject: [Koha-bugs] [Bug 6813] Acquistions - duplicate search across orders, suggestions and catalog In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12715|0 |1 is obsolete| | Attachment #12716|0 |1 is obsolete| | Attachment #13806|0 |1 is obsolete| | --- Comment #35 from M. de Rooy --- Created attachment 15793 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15793&action=edit Bug 6813: Acquistions duplicate search across orders, suggestions and catalog To Test: Create a an suggestion, order and catalog record for a certain title. Use the duplicate search tool available in the acquisitions menu (left navigation bar) to search and find the suggestion, order and catalog record matching the search term. Enter one or more of title, author and ISBN in the search criteria. Signed-off-by: Marc Veron Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 11:27:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 10:27:58 +0000 Subject: [Koha-bugs] [Bug 6813] Acquistions - duplicate search across orders, suggestions and catalog In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813 --- Comment #36 from M. de Rooy --- Created attachment 15794 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15794&action=edit Bug 6813: Followup: indentation + simplify conditions Signed-off-by: Marc Veron Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 11:28:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 10:28:02 +0000 Subject: [Koha-bugs] [Bug 6813] Acquistions - duplicate search across orders, suggestions and catalog In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813 --- Comment #37 from M. de Rooy --- Created attachment 15795 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15795&action=edit Bug 6813: Followup: Fix HTML4 coding, new wording, warning on empty search terms The aim of this followup is to fix issues from Comment #17: - HTML4 encoding UCfirst fixed - Warning regardig large databases - Added javascript with warning if search terms are empty - Removed not used fields from search form - Changed wording from "Duplicate search" (Google: 15'000) to "Find duplicates" (Google: 576'000) To Test: Create a an suggestion, order and catalog record for a certain title. Use the duplicate search tool available in the acquisitions menu (left navigation bar) to search and find the suggestion, order and catalog record matching the search term. Enter one or more of title, author and ISBN in the search criteria. Marc Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 11:28:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 10:28:07 +0000 Subject: [Koha-bugs] [Bug 6813] Acquistions - duplicate search across orders, suggestions and catalog In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813 --- Comment #38 from M. de Rooy --- Created attachment 15796 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15796&action=edit Bug 6813: Followup: FIX tabs and replace all occurrences of duplicate search - tabs was broken - 'duplicate search' have to be replaced with 'duplicate finder' - adds datatable instead of tablesorter Signed-off-by: Melia Meggs Incorporated Paul's POD fix for Suggestions.pm in here (marcelr 010313) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 11:37:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 10:37:33 +0000 Subject: [Koha-bugs] [Bug 9377] itemtype in duplicate biblio search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9377 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 11:37:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 10:37:46 +0000 Subject: [Koha-bugs] [Bug 9377] itemtype in duplicate biblio search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9377 --- Comment #3 from M. de Rooy --- QA: Looking now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 11:46:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 10:46:21 +0000 Subject: [Koha-bugs] [Bug 9040] uninitialized value in concatenation error in Opac-detail.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9040 Nu?o L?pez Ans?tegui changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15748|0 |1 is obsolete| | --- Comment #12 from Nu?o L?pez Ans?tegui --- Created attachment 15797 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15797&action=edit Bug 9040 - uninitialized value in concatenation error in Opac-detail.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 11:46:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 10:46:37 +0000 Subject: [Koha-bugs] [Bug 9040] uninitialized value in concatenation error in Opac-detail.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9040 Nu?o L?pez Ans?tegui changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 12:00:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 11:00:31 +0000 Subject: [Koha-bugs] [Bug 9377] itemtype in duplicate biblio search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9377 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14557|0 |1 is obsolete| | --- Comment #4 from M. de Rooy --- Created attachment 15798 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15798&action=edit Bug 9377 - itemtype in duplicate biblio search In C4::Search::FindDuplicate, when biblio has no ISBN, the duplicate search adds : $query .= " and itemtype=$result->{itemtype}". This should be only when itemtype is defined in biblio and not in items. Test plan : On a database with itemtype mapped in biblioitems and "item-level_itypes" syspref on "biblio record" : - Go to a biblio details page - Click on "Edit as new (duplicate)" - If ISBN is defined, remove it - Click on save => a duplicate is detected - Change biblio item type - Click on save => no duplicate detected - Set "item-level_itypes" syspref to "specific record" - Come back to biblio details page - Click on "Edit as new (duplicate)" - If ISBN is defined, remove it - Click on save => a duplicate is detected - Change biblio item type => a duplicate is detected Signed-off-by: Marc Veron Followed test plan. Behaves as expected. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 12:00:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 11:00:45 +0000 Subject: [Koha-bugs] [Bug 9377] itemtype in duplicate biblio search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9377 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 12:03:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 11:03:40 +0000 Subject: [Koha-bugs] [Bug 9377] itemtype in duplicate biblio search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9377 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #5 from M. de Rooy --- QA Comment: Tested. Works. Had some funny things when editing as new while changing frameworks, but apparently not related to your patch. Somewhat out of scope: But I am wondering if I save a new biblio with same title or ISBN and different itemtype (with item level biblio), if I would still like to have the warning? For the rest: Code looks good to me. Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 12:03:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 11:03:50 +0000 Subject: [Koha-bugs] [Bug 9377] itemtype in duplicate biblio search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9377 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 12:18:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 11:18:49 +0000 Subject: [Koha-bugs] [Bug 9393] Fix bad label and add note to circulation.pl if borrower has pending modifications In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9393 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy at rijksmuseum.nl QA Contact| |m.de.rooy at rijksmuseum.nl --- Comment #3 from M. de Rooy --- QA Comment: Small changes. Look good with two notes: members/members-update.pl still lists: Primary Mobile Phone (wrong case use too) I am wondering if we can do the other phone change like this. Lots of people may have entered mobile phone numbers here, and suddenly it is just an other phone. Could be that it should move to primary phone if that is not filled or so? We probably need more community consensus for such a change. Could you raise or prove that consensus? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 12:18:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 11:18:53 +0000 Subject: [Koha-bugs] [Bug 9040] uninitialized value in concatenation error in Opac-detail.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9040 --- Comment #13 from Jonathan Druart --- Comment on attachment 15797 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15797 Bug 9040 - uninitialized value in concatenation error in Opac-detail.tt Review of attachment 15797: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=9040&attachment=15797) ----------------------------------------------------------------- ::: koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt @@ +1480,4 @@ > [% IF ( itemdata_copynumber ) %][% ITEM_RESULT.copynumber %][% END %] > [% INCLUDE 'item-status.inc' item = ITEM_RESULT %] > [% IF ( itemdata_itemnotes ) %][% ITEM_RESULT.itemnotes %][% END %] > + [% IF ( itemdata_datedue ) %][% IF ITEM_RESULT.datedue %][% ITEM_RESULT.datedue | $KohaDates %][% END %] tag END missing for the first IF statement -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 12:18:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 11:18:59 +0000 Subject: [Koha-bugs] [Bug 9040] uninitialized value in concatenation error in Opac-detail.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9040 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 12:26:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 11:26:06 +0000 Subject: [Koha-bugs] [Bug 9293] action_logs not tracking payments In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9293 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #14 from Jonathan Druart --- Hi Kyle, Don't you think JSON::to_json is more adapted than Data::Dumper::Dumper here? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 12:35:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 11:35:49 +0000 Subject: [Koha-bugs] [Bug 9040] uninitialized value in concatenation error in Opac-detail.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9040 Nu?o L?pez Ans?tegui changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15797|0 |1 is obsolete| | --- Comment #14 from Nu?o L?pez Ans?tegui --- Created attachment 15799 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15799&action=edit Bug 9040 - uninitialized value in concatenation error in Opac-detail.tt thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 12:36:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 11:36:50 +0000 Subject: [Koha-bugs] [Bug 9040] uninitialized value in concatenation error in Opac-detail.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9040 Nu?o L?pez Ans?tegui changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 12:37:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 11:37:30 +0000 Subject: [Koha-bugs] [Bug 8917] Track clicks to links external to Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 --- Comment #50 from Jonathan Druart --- Chris, I feel like you are upset. Did I offense you? If it is the case, I am sorry, I didn't mean it. I am just trying to do my QA job, and this job consists in following the coding guidelines. I just would like to understand why do you think this remark is no relevant, because I though i was. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 13:59:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 12:59:08 +0000 Subject: [Koha-bugs] [Bug 9732] timestamp not updated when modifying biblio In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9732 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |INVALID --- Comment #3 from Fridolyn SOMERS --- Your right Chris, I did not knew this behavior. On a biblio edition : biblioitems.timestamp is always updated (because marcxml and marc are updated), but biblio.timestamp is updated only if a concerned column is updated (title, author, ...). Closed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 14:16:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 13:16:05 +0000 Subject: [Koha-bugs] [Bug 9739] New: more options for serialsUpdate.pl Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9739 Bug ID: 9739 Summary: more options for serialsUpdate.pl Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: gmcharlt at gmail.com Reporter: fridolyn.somers at biblibre.com Script serialsUpdate.pl must be set in crontab to run daily. It checks serials that are late, modifies status and adds a note. A library reported that this automatic note can not be changed nor disabled. So I propose to add an option to defined note (keeping default one if not defined) and and option to disable this note. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 14:28:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 13:28:55 +0000 Subject: [Koha-bugs] [Bug 2283] Poor use of "Not Found" redirect in response to corrupt MARC record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2283 MJ Ray (software.coop) changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #4 from MJ Ray (software.coop) --- Yes, that fix removed the redirect. I agree. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 14:31:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 13:31:08 +0000 Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 MJ Ray (software.coop) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mjr at software.coop Severity|new feature |blocker --- Comment #231 from MJ Ray (software.coop) --- I am upgrading this to blocker because it blocks bug 9326 which is a blocker. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 14:38:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 13:38:10 +0000 Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|blocker |new feature --- Comment #232 from Jared Camins-Esakov --- Bug 9326 is a blocker only if this feature is pushed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 14:38:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 13:38:27 +0000 Subject: [Koha-bugs] [Bug 9739] more options for serialsUpdate.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9739 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt at gmail.com |fridolyn.somers at biblibre.co | |m --- Comment #1 from Fridolyn SOMERS --- Created attachment 15800 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15800&action=edit Proposed patch See commit message. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 14:38:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 13:38:50 +0000 Subject: [Koha-bugs] [Bug 9739] more options for serialsUpdate.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9739 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 14:39:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 13:39:03 +0000 Subject: [Koha-bugs] [Bug 9739] more options for serialsUpdate.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9739 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Medium patch |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 14:41:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 13:41:07 +0000 Subject: [Koha-bugs] [Bug 9739] more options for serialsUpdate.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9739 --- Comment #2 from Fridolyn SOMERS --- Created attachment 15801 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15801&action=edit Proposed patch (followup) Follow up patch for cosmetic changes : - perltidy - q{} for SQL query instead of "" - list of columns is SQL query instead of SELECT * -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 14:53:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 13:53:07 +0000 Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 --- Comment #233 from MJ Ray (software.coop) --- Could we downgrade Bug 9326, then? I don't think 9326 should block release. Also, it appears unnecessarily high in the needs-signoff list and ahead of this bug which it depends upon. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 15:01:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 14:01:37 +0000 Subject: [Koha-bugs] [Bug 9326] New database update system suggests running duplicate updates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9326 MJ Ray (software.coop) changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|blocker |new feature --- Comment #7 from MJ Ray (software.coop) --- Downgrading to the same status as 7167 until 7167 is pushed, because this is not blocking the release. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 15:40:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 14:40:12 +0000 Subject: [Koha-bugs] [Bug 9256] Search is broken for 3.10 package-installs when marcflavour != marc21 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9256 --- Comment #9 from Magnus Enger --- So I finally got around to spending some more time on this, and looks like there are three problems here, from the point of view of a package install: * 1. usmarc.mar After bug 3087 this file gets the marcflavour of the installation. I think the solution is to have one file for each marcflavour, e.g. marc21.mar, normarc.mar and unimarc.mar. usmarc.mar is referenced by the different record.abs files for the different marcflavours, so updating them to point to the right .mar file for their flavour should be trivial. Side note: I'm not sure what role the .mar file actually plays in Zebra/Koha. I have tried changing the contents around a bit without any apparent influence on searching. The only documentation I have been able to find is this: 3.9. The MARC (ISO2709) Representation (.mar) Files This file provides rules for representing a record in the ISO2709 format. The rules pertain mostly to the values of the constant-length header of the record. http://www.indexdata.com/zebra/doc/grs-conf.html#grs-mar-files Perhaps Robin is right too, in that it could have been left as it was before Bug 3087? * 2. koha-conf.xml Occurences of hardcoded "usmarc" in debian/templates/koha-conf-site.xml.in need to be replaced with the __ZEBRA_MARC_FORMAT__ placeholder, so it can get the right values when a new site is created: >From To * 3. retrieval-info-*-*.xml To be exact: retrieval-info-auth-dom.xml retrieval-info-auth-grs1.xml retrieval-info-bib-dom.xml retrieval-info-bib-grs1.xml Similar to koha-conf.xml, the __ZEBRA_MARC_FORMAT__ placeholders in these files now get replaced with the actual marcflavour in a regular installation. In a dev install you will have one copy of each of these files for each of your installations, so verything works as expected. Not so for package installs, where these files are not genereated from templates and so continue to have the hardcoded "usmarc". Another major problem is that these files are common to all the instances on a server (in /etc/koha/zebradb). So it looks like we either have to - make the packages generate these files from templates whenever a new instance is added, and find a way to make them instance-sepecific (not shared), or - create one file for each marcflavour and make whatever references these files reference the files for the right marcflavour As far as I can tell, the files that reference these files are the koha-conf.xml files. It looks like it should not be too hard to make the retrieval-info-*.xml files instance specific and generate them from a template. That way we just have two sets of template files to keep updated, and not 3 versions of each of the files, for different marcflavours. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 15:47:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 14:47:13 +0000 Subject: [Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 --- Comment #52 from Sophie MEYNIEUX --- Derrin, if you use -html option, you have to check html on you notice template in order your email get the right content type. And KohaAdminEmailAddress is only used if Library email address is not set. This was the previous way to send overdues and this patch does not change that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 15:56:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 14:56:19 +0000 Subject: [Koha-bugs] [Bug 9445] Use DataTables in local use system preferences editor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9445 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 16:17:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 15:17:17 +0000 Subject: [Koha-bugs] [Bug 6209] Standardize on one javascript library for client-side form validation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6209 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 16:17:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 15:17:19 +0000 Subject: [Koha-bugs] [Bug 6209] Standardize on one javascript library for client-side form validation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6209 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15141|0 |1 is obsolete| | --- Comment #12 from Owen Leonard --- Created attachment 15802 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15802&action=edit Bug 6209 [Revised] Standardize on one plugin for client-side form validation This patch adds the jQuery "Validation" plugin (http://docs.jquery.com/Plugins/Validation) and includes it by default in the staff client along with an include file containing translatable strings for all of the plugin's possible messages. The staff client's main JavaScript file has been modified to perform automatic validation of any form with the class "validated." For a simple example I have modified the library entry form to mark required fields as required (something which had not been done before). Each required field has been given a class, "required" and the HTML5 attribute "required." The former adds the hook for the plugin, the latter adds browser-based validation in recent browsers (and which will be superceded by the plugin if JavaScript is enabled). This will check for inputs classed "required" without any additional configuration. More complex forms (with specific data types, for instance) will require more inline JavaScript configuration. $("#FormID").validate({ /* configuration details */ }); Also added to the library entry form are checks on the email and URL fields via classes ("email" and "url", respectively). This demonstrates validation of content without forcing the field to be required. To test, go to Administration -> Libraries and Groups and choose "New library." Submit the form without entering a library code or name. You should be prevented from submitting the form and be shown an error message by each field. Perform the same check with an existing entry. To test browser-based validation, disable JavaScript and follow the same procedure. Revision rebases the patch against current master and adds missing "// http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9740 Bug ID: 9740 Summary: using XSLT modifies record authorized values Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: fridolyn.somers at biblibre.com When using XSLT display, in detail.pl, the record (MARC::Record) is get from database. This record is given to XSLTParse4Display() to transform into HTML using XSLT. This method uses transformMARCXML4XSLT() to replace in record authorized values code by there description. The bug is that this change is made on original record and remains in the rest of the script detail.pl. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 16:35:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 15:35:06 +0000 Subject: [Koha-bugs] [Bug 9740] using XSLT modifies record authorized values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9740 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|oleonard at myacpl.org |fridolyn.somers at biblibre.co | |m --- Comment #1 from Fridolyn SOMERS --- Created attachment 15803 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15803&action=edit Proposed patch See commit message -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 16:35:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 15:35:20 +0000 Subject: [Koha-bugs] [Bug 9740] using XSLT modifies record authorized values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9740 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 16:56:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 15:56:34 +0000 Subject: [Koha-bugs] [Bug 9734] String::Random is marked as optional, but C4::Members requires it In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9734 --- Comment #3 from Kyle M Hall --- Created attachment 15804 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15804&action=edit Bug 9734 - String::Random is marked as optional, but C4::Members requires it jcamins confirmed on IRC it is not optional. To test: 1) perl koha_perl_deps.pl -a |grep String::Random 2) notice the "No" in the last column - it should be Yes 3) apply patch and repeat same steps, looking for Yes. 4) prove t/Installer_PerlModules.t # which checks String::Random is required Sponsored-by: software.coop Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 16:56:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 15:56:47 +0000 Subject: [Koha-bugs] [Bug 9734] String::Random is marked as optional, but C4::Members requires it In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9734 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15777|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 16:56:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 15:56:57 +0000 Subject: [Koha-bugs] [Bug 9734] String::Random is marked as optional, but C4::Members requires it In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9734 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 17:03:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 16:03:44 +0000 Subject: [Koha-bugs] [Bug 9730] The sub 'AnonymiseIssueHistory' fails quietly if 'AnonymousPatron' is not a valid entry In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9730 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |kyle at bywatersolutions.com --- Comment #2 from Kyle M Hall --- I believe it would be more proper to disable the "my privacy' tab if AnonymousPatron is not a valid patron. This would be more in line with how OPACPrivacy requires opacreadinghistory and the tab does not show if opacreadinghistory is not set to "Allow". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 17:06:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 16:06:23 +0000 Subject: [Koha-bugs] [Bug 9716] opaclayoutstylesheet and opaccolorstylesheet must be filled in for CCSR In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9716 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15718|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 15805 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15805&action=edit Bug 9716 - opaccolorstylesheet must be filled in for CCSR To test: Empty out your opaccolorstylesheet system preference (for fun, but not necessary, you can empty out your opaclayoutstylesheet preference too) Switch themes to CCSR Load the opac - if it doesn't go horribly wrong the patch is working. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 17:07:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 16:07:30 +0000 Subject: [Koha-bugs] [Bug 9716] opaclayoutstylesheet and opaccolorstylesheet must be filled in for CCSR In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9716 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 17:14:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 16:14:14 +0000 Subject: [Koha-bugs] [Bug 9722] Allow users to add notes when placing a hold in opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9722 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15752|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 15806 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15806&action=edit Bug 9722: Allow users to add notes when placing a hold in opac Database revision for report 9722, adding new pref OpacShowHoldNotes. This development is part of a larger one (see umbrella report 9721). Test plan: Run [your server]/cgi-bin/koha/installer/install.pl?step=3&op=updatestructure Optionally, run a new install to test sysprefs.sql. Or: Edit sysprefs.sql, leave at least the last few lines including the new one. And run from command line: mysql -p [yourdatabase] < [your-clone]/installer/data/mysql/sysprefs.sql Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 17:14:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 16:14:24 +0000 Subject: [Koha-bugs] [Bug 9722] Allow users to add notes when placing a hold in opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9722 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15753|0 |1 is obsolete| | Attachment #15806|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 15807 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15807&action=edit Bug 9722: Allow users to add notes when placing a hold in opac The option of adding a note is controlled by new pref OpacShowHoldNotes. This development is part of a larger one (see umbrella report 9721). Test plan: 1 Verify if new pref is disabled by default. Place a hold. You can't add a note. 2 Enable the pref. Place a hold and add a note. Check in staff if you can see the note in Catalogue Detail/Holds tab. 3 Toggle SingleBranchmode, AllowHoldDateInFuture/OPACAllowHoldDateInFuture, OPACShowHoldQueueDetails, or OPACItemHolds. Check the display of columns when placing a hold from opac. 4 Place a few holds with notes from opac search results in one run (enable DisplayMultiPlaceHold). Check results in staff again. Remark: A few lines already refer to mandatory note reasons. This is handled in a subsequent report. No reason to worry. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 17:14:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 16:14:31 +0000 Subject: [Koha-bugs] [Bug 9722] Allow users to add notes when placing a hold in opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9722 --- Comment #5 from Kyle M Hall --- Created attachment 15808 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15808&action=edit Bug 9722: Allow users to add notes when placing a hold in opac Database revision for report 9722, adding new pref OpacShowHoldNotes. This development is part of a larger one (see umbrella report 9721). Test plan: Run [your server]/cgi-bin/koha/installer/install.pl?step=3&op=updatestructure Optionally, run a new install to test sysprefs.sql. Or: Edit sysprefs.sql, leave at least the last few lines including the new one. And run from command line: mysql -p [yourdatabase] < [your-clone]/installer/data/mysql/sysprefs.sql Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 17:18:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 16:18:04 +0000 Subject: [Koha-bugs] [Bug 9722] Allow users to add notes when placing a hold in opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9722 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |kyle at bywatersolutions.com --- Comment #6 from Kyle M Hall --- Looks good but a couple things that should probably be taken care of before passing qa: 1) The "Show notes" buttons should probably be titled "Add notes" instead. 2) When doing a multi-hold, clicking one "Show notes" button hides the previously visible note textarea. This is jarring and may confuse patrons into thinking they can only have a note on one and only one of the holds. It would be better to make each "Show notes" button a toggle to hide it's own note textarea, and clear that textarea if it gets hidden. You could even change the text from "Add notes" to "Remove notes" when the textarea is visible. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 18:02:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 17:02:53 +0000 Subject: [Koha-bugs] [Bug 9550] Replace PazPar2 with MetaProxy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9550 Elliott Davis changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 18:15:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 17:15:54 +0000 Subject: [Koha-bugs] [Bug 7883] save and continue editing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7883 Elliott Davis changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15500|0 |1 is obsolete| | --- Comment #7 from Elliott Davis --- Created attachment 15809 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15809&action=edit Added the ability to save and continue editing in cataloging. This patch adds the ability for catalogers to save and continue editing when adding new biblios. This is helpful in the event of a power failure or perhaps in the event you step away for a sandwich and your co-worker closes your tab to look at cats. To Test: Select an existing item or create a new item in cataloging using your favorite framework. Edit the item >From the save menu in the dropdown, select the new option of "Save and continue editing" If you are missing requited fields you should still be prompted to fill them in before saving Once all required fields are in place you should be allowed to save and should be on the same page (You're fresh bib record should also be saved) http://bugs.koha-community.org/show_bug.cgi?id=7883 Modified: Changed malformed urls in form submits -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 18:16:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 17:16:13 +0000 Subject: [Koha-bugs] [Bug 7883] save and continue editing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7883 Elliott Davis changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 19:02:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 18:02:02 +0000 Subject: [Koha-bugs] [Bug 9293] action_logs not tracking payments In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9293 --- Comment #15 from Kyle M Hall --- (In reply to comment #14) > Hi Kyle, > Don't you think JSON::to_json is more adapted than Data::Dumper::Dumper here? I think that's a great idea, but Dumper is currently the way most everything is stored for the action logs. Perhaps we should submit a bug to switch everything to that and have it depend on this bug. We would have to have updatedatabase convert everything that is already in the action logs as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 19:13:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 18:13:28 +0000 Subject: [Koha-bugs] [Bug 8304] composed authorities Rameau management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8304 Pierre Angot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tredok.pierre at gmail.com --- Comment #12 from Pierre Angot --- Hello, I've tested with files added by Henri-Damien on sandbox (http://pro.pelardon.biblibre.com test/test) - search authorities "Litt?rature sentimentale", edit it and modify 250$a (Harlequin champion de l'amour) - search catalog "100 romans d'amour" - check 606 - No change : 606$a is still "Litt?rature sentimentale". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 20:46:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 19:46:22 +0000 Subject: [Koha-bugs] [Bug 9445] Use DataTables in local use system preferences editor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9445 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 20:46:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 19:46:23 +0000 Subject: [Koha-bugs] [Bug 9445] Use DataTables in local use system preferences editor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9445 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15775|0 |1 is obsolete| | --- Comment #9 from Owen Leonard --- Created attachment 15810 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15810&action=edit Bug 9445 [Revised] Use DataTables in local use system preferences editor Replace the tablesorter plugin with the DataTables plugin in the local use system preferences editor. This patch moves embedding of the toolbar and table-sorting JS from within the body of the page to the for sake of consistency. To test, open the system preferences editor to the Local Use tab. Confirm that table sorting works correctly. In this configuration there should be no pager and no results filtering. Revision corrects template path to datatables assets. Signed-off-by: Bernardo Gonzalez Kriegel Comment: Tab sorting works. No errors. Signed-off-by: Jonathan Druart Further revision removes old tablesorter code -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 20:46:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 19:46:43 +0000 Subject: [Koha-bugs] [Bug 9445] Use DataTables in local use system preferences editor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9445 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 20:47:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 19:47:10 +0000 Subject: [Koha-bugs] [Bug 9445] Use DataTables in local use system preferences editor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9445 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #10 from Owen Leonard --- Returning to "Passed QA" as per jcamins' instructions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 20:52:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 19:52:43 +0000 Subject: [Koha-bugs] [Bug 9444] Use DataTables in system preferences editor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9444 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 20:52:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 19:52:45 +0000 Subject: [Koha-bugs] [Bug 9444] Use DataTables in system preferences editor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9444 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15743|0 |1 is obsolete| | --- Comment #6 from Owen Leonard --- Created attachment 15811 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15811&action=edit Bug 9444 [Revised] Use DataTables in system preferences editor Replace the tablesorter plugin with the DataTables plugin in the "new" system preferences editor. To test, open the system preferences editor on any tab other than Local Use. Confirm that table sorting works correctly within each section. In this configuration there should be no pager and no results filtering. Revision corrects template path to datatables assets. Further revision fixes section-collapse JS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 21:52:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 20:52:08 +0000 Subject: [Koha-bugs] [Bug 8917] Track clicks to links external to Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 21:52:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 20:52:12 +0000 Subject: [Koha-bugs] [Bug 8917] Track clicks to links external to Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 --- Comment #51 from Chris Cormack --- Created attachment 15812 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15812&action=edit Bug 8917 : Shifting db dependent code to a module -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 22:01:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 21:01:44 +0000 Subject: [Koha-bugs] [Bug 9456] Add callnumber column to the cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15759|0 |1 is obsolete| | --- Comment #23 from Owen Leonard --- Created attachment 15813 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15813&action=edit Bug 9456 [Alternate] Add callnumber column to the cart This patch adds call-number sorting to the staff client cart on a title-by-title basis. Item information (library, shelving location, and call number) is moved to a table nested in each row. Location and call number columns in this table are sortable. The patch converts table sorting to DataTables. The patch does not attempt to make the larger table of titles sortable by call number. To test, add multiple titles to the staff client cart which have multiple items each. The table of titles should still be sortable by title and item type. The table of items in each row should be sortable by location and call number. Rebased on current master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 22:01:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 21:01:54 +0000 Subject: [Koha-bugs] [Bug 8917] Track clicks to links external to Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature --- Comment #52 from Chris Cormack --- Shifted the db insert to a new module. Spotted a bug with the behaviour of the links that existed before this new feature, even if we dont have a uri, we are putting an empty href in. Will do a follow up to fix this bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 22:03:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 21:03:02 +0000 Subject: [Koha-bugs] [Bug 9656] fines.pl creating a log file should be optional In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9656 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15767|0 |1 is obsolete| | --- Comment #12 from Bernardo Gonzalez Kriegel --- Created attachment 15814 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15814&action=edit [SIGNED-OFF] Bug 9656: Followup Make logging to a file optional (for fines) The -log option become optional if the -output_dir is given. Test plan: call the script with 1/ no one parameter : no log file 2/ -l : log file will be created in /tmp 3/ -o=/home/koha/var/log : log file with be created in the specified 4/ -o=/home/koha/var/log -l: Same as 3/ Signed-off-by: Bernardo Gonzalez Kriegel Comment: All combination of options tested. Works well. No errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 22:03:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 21:03:25 +0000 Subject: [Koha-bugs] [Bug 9656] fines.pl creating a log file should be optional In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9656 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 22:04:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 21:04:33 +0000 Subject: [Koha-bugs] [Bug 9456] Add callnumber column to the cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 --- Comment #24 from Owen Leonard --- I have attached a rebased copy of my patch because I think git was breaking something in it's auto-merge with the Bootstrap changes. Kyle I'm not sure why you created your patch as a follow-up to mine, since our approaches are so different. I think yours should be constructed as a separate patch and presented as an alternative rather than a follow-up to mine. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 22:15:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 21:15:28 +0000 Subject: [Koha-bugs] [Bug 8917] Track clicks to links external to Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 --- Comment #53 from Chris Cormack --- Created attachment 15815 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15815&action=edit Bug 8917 : Follow up fixing bad behaviour that existed prior to this feature But the bug only becomes visible with link tracking on Prior to this patch it would put an empty link in the html -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 22:21:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 21:21:58 +0000 Subject: [Koha-bugs] [Bug 6209] Standardize on one javascript library for client-side form validation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6209 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15802|0 |1 is obsolete| | --- Comment #13 from Bernardo Gonzalez Kriegel --- Created attachment 15816 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15816&action=edit [SIGNED-OFF] Bug 6209 [Revised] Standardize on one plugin for client-side form validation This patch adds the jQuery "Validation" plugin (http://docs.jquery.com/Plugins/Validation) and includes it by default in the staff client along with an include file containing translatable strings for all of the plugin's possible messages. The staff client's main JavaScript file has been modified to perform automatic validation of any form with the class "validated." For a simple example I have modified the library entry form to mark required fields as required (something which had not been done before). Each required field has been given a class, "required" and the HTML5 attribute "required." The former adds the hook for the plugin, the latter adds browser-based validation in recent browsers (and which will be superceded by the plugin if JavaScript is enabled). This will check for inputs classed "required" without any additional configuration. More complex forms (with specific data types, for instance) will require more inline JavaScript configuration. $("#FormID").validate({ /* configuration details */ }); Also added to the library entry form are checks on the email and URL fields via classes ("email" and "url", respectively). This demonstrates validation of content without forcing the field to be required. To test, go to Administration -> Libraries and Groups and choose "New library." Submit the form without entering a library code or name. You should be prevented from submitting the form and be shown an error message by each field. Perform the same check with an existing entry. To test browser-based validation, disable JavaScript and follow the same procedure. Revision rebases the patch against current master and adds missing "// Comment: Work as described with new or existing library. No errors. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 22:22:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 21:22:21 +0000 Subject: [Koha-bugs] [Bug 6209] Standardize on one javascript library for client-side form validation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6209 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 22:29:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 21:29:27 +0000 Subject: [Koha-bugs] [Bug 9444] Use DataTables in system preferences editor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9444 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15811|0 |1 is obsolete| | --- Comment #7 from Bernardo Gonzalez Kriegel --- Created attachment 15817 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15817&action=edit [SIGNED-OFF] Bug 9444 [Revised] Use DataTables in system preferences editor Replace the tablesorter plugin with the DataTables plugin in the "new" system preferences editor. To test, open the system preferences editor on any tab other than Local Use. Confirm that table sorting works correctly within each section. In this configuration there should be no pager and no results filtering. Revision corrects template path to datatables assets. Further revision fixes section-collapse JS Signed-off-by: Bernardo Gonzalez Kriegel Comment: Work as described. Collapsing restored. No errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 22:29:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 21:29:56 +0000 Subject: [Koha-bugs] [Bug 9444] Use DataTables in system preferences editor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9444 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 23:53:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 22:53:19 +0000 Subject: [Koha-bugs] [Bug 8917] Track clicks to links external to Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15783|0 |1 is obsolete| | --- Comment #54 from Bernardo Gonzalez Kriegel --- Created attachment 15818 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15818&action=edit [SIGNED-OFF] Bug 8917 : Creating tables and system pref, no functional changes at all Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 23:53:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 22:53:27 +0000 Subject: [Koha-bugs] [Bug 8917] Track clicks to links external to Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15784|0 |1 is obsolete| | --- Comment #55 from Bernardo Gonzalez Kriegel --- Created attachment 15819 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15819&action=edit [SIGNED-OFF] Bug 8917 : Adding link tracking to the opac detail page, without xslt Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 23:53:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 22:53:36 +0000 Subject: [Koha-bugs] [Bug 8917] Track clicks to links external to Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15785|0 |1 is obsolete| | --- Comment #56 from Bernardo Gonzalez Kriegel --- Created attachment 15820 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15820&action=edit [SIGNED-OFF] Bug 8917 : Script to log link clicks Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 23:53:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 22:53:46 +0000 Subject: [Koha-bugs] [Bug 8917] Track clicks to links external to Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15786|0 |1 is obsolete| | --- Comment #57 from Bernardo Gonzalez Kriegel --- Created attachment 15821 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15821&action=edit [SIGNED-OFF] Bug 8917 : Link tracking, changes to XSLT Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 23:53:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 22:53:55 +0000 Subject: [Koha-bugs] [Bug 8917] Track clicks to links external to Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15787|0 |1 is obsolete| | --- Comment #58 from Bernardo Gonzalez Kriegel --- Created attachment 15822 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15822&action=edit [SIGNED-OFF] Bug 8917 : Fixing a bug bgkriegel spotted and removing tabs Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 23:54:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 22:54:07 +0000 Subject: [Koha-bugs] [Bug 8917] Track clicks to links external to Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15812|0 |1 is obsolete| | --- Comment #59 from Bernardo Gonzalez Kriegel --- Created attachment 15823 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15823&action=edit [SIGNED-OFF] Bug 8917 : Shifting db dependent code to a module Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 23:54:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 22:54:18 +0000 Subject: [Koha-bugs] [Bug 8917] Track clicks to links external to Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15815|0 |1 is obsolete| | --- Comment #60 from Bernardo Gonzalez Kriegel --- Created attachment 15824 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15824&action=edit [SIGNED-OFF] Bug 8917 : Follow up fixing bad behaviour that existed prior to this feature But the bug only becomes visible with link tracking on Prior to this patch it would put an empty link in the html Signed-off-by: Bernardo Gonzalez Kriegel General comment: Work as described. No errors. Tested all preference values with and without logged in user. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 23:55:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 22:55:59 +0000 Subject: [Koha-bugs] [Bug 8917] Track clicks to links external to Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 --- Comment #61 from Bernardo Gonzalez Kriegel --- Created attachment 15825 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15825&action=edit Bug 8917 : [ Sign followup ] Track clicks to links external to Koha Remove empty pod section in Koha/Linktracker.pm to make koha-qa happy. Add missing "\n" in installer/data/mysql/updatedatabase.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 23:57:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2013 22:57:00 +0000 Subject: [Koha-bugs] [Bug 8917] Track clicks to links external to Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 01:34:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Mar 2013 00:34:18 +0000 Subject: [Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 --- Comment #53 from Derryn --- (In reply to comment #52) > Derrin, if you use -html option, you have to check html on you notice > template in order your email get the right content type. > > And KohaAdminEmailAddress is only used if Library email address is not set. > This was the previous way to send overdues and this patch does not change > that. This is without the -html option. I'm not outputting them to a file, which the -html option is for; I'm making them to email. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 02:37:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Mar 2013 01:37:32 +0000 Subject: [Koha-bugs] [Bug 5463] limit to available shows on hold items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5463 --- Comment #1 from Nicole C. Engard --- This is still an issue. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 13:25:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Mar 2013 12:25:05 +0000 Subject: [Koha-bugs] [Bug 9673] Track when items are marked as lost or withdrawn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9673 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- Hi Kyle, please add the new fields also to the deleteditems table, else deleting items won't work correctly. I was also wondering if it might be useful to add this information to action_log or statistics table? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 14:33:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Mar 2013 13:33:42 +0000 Subject: [Koha-bugs] [Bug 8218] Add a script to sanitize entity where "&" character was wrongly replaced with "& " In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8218 Christophe Croullebois changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13678|0 |1 is obsolete| | --- Comment #14 from Christophe Croullebois --- Created attachment 15826 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15826&action=edit proposed patch Hi Bernardo, thx for the test. I corrected the 'search' option, --where "search" is now ok, I added also a message. I tried to be more explicit in help. --batch is corrected now --cron is ok now, you were right about newline ;o) About the qa message... hum what do you suggest ? I use (====) to make the outpout more visual ... not very important for me I hope I haven't forget something. thx -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 14:34:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Mar 2013 13:34:02 +0000 Subject: [Koha-bugs] [Bug 8218] Add a script to sanitize entity where "&" character was wrongly replaced with "& " In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8218 Christophe Croullebois changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 15:41:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Mar 2013 14:41:45 +0000 Subject: [Koha-bugs] [Bug 9316] Add Nginx install options with plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9316 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14789|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 16:56:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Mar 2013 15:56:22 +0000 Subject: [Koha-bugs] [Bug 8218] Add a script to sanitize entity where "&" character was wrongly replaced with "& " In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8218 --- Comment #15 from Bernardo Gonzalez Kriegel --- Hi Christophe, now it works well :) A few things more (sorry): 1) in C4/Charset.pm, the line with SanitizeEntity has a tab, replace it with spaces. 2) in C4/Charset.pm are pod errors, you could write this as =head2 SanitizeEntity SanitizeEntity($marcrecord); Sanitize Entity =cut BTW, description is a little short :) 3) in C4/Charset.pm, you put this function at the bottom. As an exported function I think it must be moved up, below nsb_clean. 4) Important: make your script executable, only run if you do "perl misc/maintenance/batchSanitizeEntity.pl" 5) You can change '===' with '---' so koha-qa do not complain. Not important really (rebuild_zebra has lots) 6) The confirmation question could be 'Proceed? [yes/no]' I think that 1-4 could make this fail QA, 5-6 are suggestions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 18:03:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Mar 2013 17:03:56 +0000 Subject: [Koha-bugs] [Bug 9617] Replace YUI menu on catalog pages with Bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9617 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Jared Camins-Esakov --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 18:04:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Mar 2013 17:04:24 +0000 Subject: [Koha-bugs] [Bug 9377] itemtype in duplicate biblio search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9377 --- Comment #6 from Jared Camins-Esakov --- Why is this patch needed? Would it not be better to simply remove the itemtype check altogether, if it does not work properly? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 18:09:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Mar 2013 17:09:45 +0000 Subject: [Koha-bugs] [Bug 9674] Replace YUI buttons and menu on acquisitions pages with Bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9674 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 18:09:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Mar 2013 17:09:47 +0000 Subject: [Koha-bugs] [Bug 9674] Replace YUI buttons and menu on acquisitions pages with Bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9674 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15640|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 15827 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15827&action=edit [PASSED QA] Bug 9674 - Replace YUI buttons and menu on acquisitions pages with Bootstrap This patch converts the toolbar on acquisitions pages to Bootstrap, replacing YUI button code with Bootstrap markup. To test, view acquisitions pages and confirm that buttons look correct and work correctly: - acqui-home.pl (Acquisitions home page) - booksellers.pl (Acquisitions -> Vendor search) - supplier.pl (Acquisitions -> Vendor search -> Vendor) - aqcontract.pl (Acquisitions -> Vendor search -> Vendor -> Contracts) - uncertainprice.pl (Aquisitions -> Vendor search -> Vendor -> Uncertain prices) View these pages for vendors with and without orders. Signed-off-by: Bernardo Gonzalez Kriegel Comment: Buttons works. No errors. Tested vendors with and without orders (delete button in last case) Signed-off-by: Katrin Fischer Works nicely, changes are consistent. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 18:12:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Mar 2013 17:12:37 +0000 Subject: [Koha-bugs] [Bug 9520] Update default LOC Z39.50 target In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9520 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #11 from Jared Camins-Esakov --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 18:14:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Mar 2013 17:14:59 +0000 Subject: [Koha-bugs] [Bug 9675] Replace YUI buttons on authorities home page with Bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9675 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 18:15:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Mar 2013 17:15:02 +0000 Subject: [Koha-bugs] [Bug 9675] Replace YUI buttons on authorities home page with Bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9675 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15599|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 15828 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15828&action=edit [PASSED QA] Bug 9675 - Replace YUI buttons on authorities home page with Bootstrap This patch converts the toolbar include file used by the authorities home page and authority view page (authorities-home.pl and authorities/detail.pl) replacing YUI button and menu code with Bootstrap. To test: - View the authorities home page and confirm that the "New authority" button looks correct and works correctly. - Search for an existing authority and click the "Details" link to view. "Edit," "Delete," "Save," and "New authority" buttons should look correct and work correctly. The "Delete" button should only appear for authorities which are unused. Signed-off-by: Bernardo Gonzalez Kriegel Comment: Now it works. New and all operations on existing auth works. No errors. Signed-off-by: Katrin Fischer Works nicely, no problems found. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 18:16:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Mar 2013 17:16:37 +0000 Subject: [Koha-bugs] [Bug 9675] Replace YUI buttons on authorities home page with Bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9675 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de QA Contact| |katrin.fischer at bsz-bw.de --- Comment #7 from Katrin Fischer --- I was a bit surprised that the "New" pull down is last on an authority detail page as it's normally the first on other pages. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 18:18:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Mar 2013 17:18:13 +0000 Subject: [Koha-bugs] [Bug 9693] Remove YUI styling from buttons on the patron card creator's image manage page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9693 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de QA Contact| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 18:18:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Mar 2013 17:18:35 +0000 Subject: [Koha-bugs] [Bug 9397] Error Messages hard to find for Visually Impaired Users (Accessibility) [Returning Items] In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9397 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Jared Camins-Esakov --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 18:20:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Mar 2013 17:20:32 +0000 Subject: [Koha-bugs] [Bug 9675] Replace YUI buttons on authorities home page with Bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9675 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Jared Camins-Esakov --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 18:22:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Mar 2013 17:22:20 +0000 Subject: [Koha-bugs] [Bug 9674] Replace YUI buttons and menu on acquisitions pages with Bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9674 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jared Camins-Esakov --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 18:23:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Mar 2013 17:23:26 +0000 Subject: [Koha-bugs] [Bug 9674] Replace YUI buttons and menu on acquisitions pages with Bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9674 --- Comment #5 from Jared Camins-Esakov --- I look forward to another follow-up that adds Bootstrap on the basket groups page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 18:25:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Mar 2013 17:25:43 +0000 Subject: [Koha-bugs] [Bug 9445] Use DataTables in local use system preferences editor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9445 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #11 from Jared Camins-Esakov --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 18:35:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Mar 2013 17:35:07 +0000 Subject: [Koha-bugs] [Bug 9693] Remove YUI styling from buttons on the patron card creator's image manage page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9693 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 18:40:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Mar 2013 17:40:46 +0000 Subject: [Koha-bugs] [Bug 9693] Remove YUI styling from buttons on the patron card creator's image manage page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9693 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15637|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer --- Created attachment 15829 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15829&action=edit [PASSED QA] Bug 9693 - Remove YUI styling from buttons on the patron card creator's image manage page Buttons on the patron card creator's image manage page are styled using YUI. They can be classified as submit buttons rather than toolbar buttons, so they should have default submit button styles. This patch removes YUI styling and related JavaScript. Other minor changes: Markup corrections for validity. To test, view the patron card creator's image manage page. "Upload" and "Delete" buttons should look correct and work correctly. Upload and delete operations should function normally. Signed-off-by: Bernardo Gonzalez Kriegel Comment: Work as described. No errors. Questions answered in comments. Signed-off-by: Katrin Fischer Works nicely and is more consistent. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 18:52:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Mar 2013 17:52:22 +0000 Subject: [Koha-bugs] [Bug 9697] Replace YUI buttons on the patron cards batch edit page with Bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9697 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |katrin.fischer at bsz-bw.de --- Comment #6 from Katrin Fischer --- Owen, can you please rebase and switch back to signed-off? -------------------------- Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y Applying: Bug 9697 - Replace YUI buttons on the patron cards batch edit page with Bootstrap fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-batch.tt). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 9697 - Replace YUI buttons on the patron cards batch edit page with Bootstrap When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 19:00:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Mar 2013 18:00:39 +0000 Subject: [Koha-bugs] [Bug 9689] Replace YUI buttons on the OAI sets administration page with Bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9689 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de QA Contact| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 19:07:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Mar 2013 18:07:37 +0000 Subject: [Koha-bugs] [Bug 9689] Replace YUI buttons on the OAI sets administration page with Bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9689 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 19:07:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Mar 2013 18:07:39 +0000 Subject: [Koha-bugs] [Bug 9689] Replace YUI buttons on the OAI sets administration page with Bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9689 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15629|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 15830 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15830&action=edit [PASSED QA] Bug 9689 - Replace YUI buttons on the OAI sets administration page with Bootstrap This patch converts the toolbar on the OAI sets administration page to Bootstrap, replacing YUI button code with Bootstrap markup. To test, view the OAI sets administration page and confirm that the "New set" button looks correct and works correctly. Signed-off-by: Bernardo Gonzalez Kriegel Comment: Works and looks nice. No errors. Signed-off-by: Katrin Fischer Works nicely, no problems found. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 19:10:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Mar 2013 18:10:02 +0000 Subject: [Koha-bugs] [Bug 9676] Replace YUI buttons on authorities editor page with Bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9676 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 19:11:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Mar 2013 18:11:21 +0000 Subject: [Koha-bugs] [Bug 9676] Replace YUI buttons on authorities editor page with Bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9676 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15597|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 15831 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15831&action=edit [PASSED QA] Bug 9676 - Replace YUI buttons on authorities editor page with Bootstrap This patch converts the "Save" button on the authorities editor page to Bootstrap, replacing YUI button code with Bootstrap markup. This patch also adds the float effect to the toolbar to match that on the MARC editor page. To test, create a new authority or load an existing one. The "Save" button should look correct and work correctly. When you scroll the page down, the toolbar should "stick" to the top of the browser window so that the "Save" button stays visible. Signed-off-by: Bernardo Gonzalez Kriegel Comment: Button works and looks good. The toolbart sticks when scrolling, but I see a gap between the box of the save button, and the top of the window (tested with chrome, opera, firefox). Signed-off-by: Katrin Fischer Works nicely. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 19:11:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Mar 2013 18:11:49 +0000 Subject: [Koha-bugs] [Bug 9676] Replace YUI buttons on authorities editor page with Bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9676 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de QA Contact| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 19:37:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Mar 2013 18:37:40 +0000 Subject: [Koha-bugs] [Bug 7813] Add ability to delete local cover images In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7813 keinequal at att.net changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |keinequal at att.net --- Comment #4 from keinequal at att.net --- So, how is the ability to delete the local cover image different/similar from the ability to delete the image of the patron? There should not be that much difference in code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 19:52:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Mar 2013 18:52:58 +0000 Subject: [Koha-bugs] [Bug 7813] Add ability to delete local cover images In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7813 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #5 from Chris Cormack --- (In reply to comment #4) > So, how is the ability to delete the local cover image different/similar > from the ability to delete the image of the patron? There should not be that > much difference in code. A great learning exercise would be to look .. then send a patch implementing the feature :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 3 02:24:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Mar 2013 01:24:03 +0000 Subject: [Koha-bugs] [Bug 9735] Choose OPAC language in links to any page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9735 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Assignee|oleonard at myacpl.org |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 3 02:28:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Mar 2013 01:28:31 +0000 Subject: [Koha-bugs] [Bug 9735] Choose language using URL parameters in any page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9735 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Choose OPAC language in |Choose language using URL |links to any page |parameters in any page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 3 02:48:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Mar 2013 01:48:19 +0000 Subject: [Koha-bugs] [Bug 9735] Choose language using URL parameters in any page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9735 --- Comment #1 from Tom?s Cohen Arazi --- Created attachment 15832 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15832&action=edit Bug 9735 - Let the language be selected through URL parameters Passing language= as a parameter in any Koha's URL can be used to set the desired language. This patch touches - C4::Templates - C4::Auth Adds a new method getlanguagecookie that does exactly that, for use in get_template_and_user. Also modifies getlanguage so it checks (a) if there's a 'language' parameter in the CGI object and (b) checks if its valid and enabled for the desired interface. To test: * Without the patch - access any koha page - add ?language=code to the end of the URL (change code for a valid language code it needs to be installed using perl translate install code, and enabled either for the staff or opac interface, depending where are you testing) - Nothing happens with the language parameter * With the patch - access any koha page - add ?language=code (the same as before) and hit enter - the language should be changed to the one you chose - if you browse through some links, you will see koha 'remembers' the language you passed as a parameter (i.e. the language cookie has been updated). Regards To+ Sponsored-by: Universidad Nacional de C?rdoba -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 3 02:49:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Mar 2013 01:49:25 +0000 Subject: [Koha-bugs] [Bug 9735] Choose language using URL parameters in any page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9735 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 3 13:58:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Mar 2013 12:58:53 +0000 Subject: [Koha-bugs] [Bug 5343] Subscription cost (Link serial and acqui modules) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5343 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |bgkriegel at gmail.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 3 19:08:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Mar 2013 18:08:32 +0000 Subject: [Koha-bugs] [Bug 8088] Png-images of covers lost transparency In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8088 --- Comment #4 from Serhij Dubyk --- (In reply to comment #2) > I like the idea, but do we need the commented out transparency lines? > > Can we safely remove those? Yes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 3 19:09:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Mar 2013 18:09:09 +0000 Subject: [Koha-bugs] [Bug 8088] Png-images of covers lost transparency In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8088 Serhij Dubyk changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dubyk at library.lviv.ua -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 3 19:09:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Mar 2013 18:09:59 +0000 Subject: [Koha-bugs] [Bug 8023] Facebook share link not used current localization In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8023 Serhij Dubyk changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dubyk at library.lviv.ua -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 3 22:32:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Mar 2013 21:32:50 +0000 Subject: [Koha-bugs] [Bug 9466] Use DataTables on saved reports page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9466 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15705|0 |1 is obsolete| | --- Comment #7 from Nicole C. Engard --- Created attachment 15833 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15833&action=edit [SIGNED-OFF] Bug 9466 [Revised] Use DataTables on saved reports page Replace the tablesorter plugin with the DataTables plugin on the saved reports page. To test, open the saved reports page (Reports > Use saved). Confirm that table sorting works correctly. Revision makes default result count (20) match options for number of pagination entries (10,20,50,100,all). Further revision corrects template path to datatables assets. Signed-off-by: Nicole C. Engard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 3 22:33:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Mar 2013 21:33:09 +0000 Subject: [Koha-bugs] [Bug 9466] Use DataTables on saved reports page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9466 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 3 23:46:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Mar 2013 22:46:11 +0000 Subject: [Koha-bugs] [Bug 9256] Search is broken for 3.10 package-installs when marcflavour != marc21 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9256 --- Comment #10 from Robin Sheat --- What you're saying doesn't seem bad or too difficult. One point though: where possible, I'd like to centralise the files as much as reasonable. That is, rather than create an instance-specific version, it'd be preferable to have a file for all the combinations. We could generated these as part of the build process, if need be. My reasoning for this is simply that this means they'll get upgraded as koha gets upgraded. There will be situations where this really isn't feasible, but if it's just a handful more files, sensibly named, it should be OK. If we start having dozens of them (especially if they have to be maintained manually) then it is probably time to template a per-instance one. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 07:52:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2013 06:52:34 +0000 Subject: [Koha-bugs] [Bug 9722] Allow users to add notes when placing a hold in opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9722 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15808|0 |1 is obsolete| | --- Comment #7 from M. de Rooy --- Created attachment 15834 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15834&action=edit Bug 9722: Allow users to add notes when placing a hold in opac (dbrev) Database revision for report 9722, adding new pref OpacShowHoldNotes. This development is part of a larger one (see umbrella report 9721). Test plan: Run [your server]/cgi-bin/koha/installer/install.pl?step=3&op=updatestructure Optionally, run a new install to test sysprefs.sql. Or: Edit sysprefs.sql, leave at least the last few lines including the new one. And run from command line: mysql -p [yourdatabase] < [your-clone]/installer/data/mysql/sysprefs.sql Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 08:08:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2013 07:08:12 +0000 Subject: [Koha-bugs] [Bug 9649] Replace YUI buttons on cataloging home page with Bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9649 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de QA Contact| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 08:09:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2013 07:09:40 +0000 Subject: [Koha-bugs] [Bug 9649] Replace YUI buttons on cataloging home page with Bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9649 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 08:09:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2013 07:09:42 +0000 Subject: [Koha-bugs] [Bug 9649] Replace YUI buttons on cataloging home page with Bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9649 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15593|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 15835 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15835&action=edit [PASSED QA] Bug 9649 - Replace YUI buttons on cataloging home page with Bootstrap This patch converts the buttons on the cataloging home page to Bootstrap, replacing the YUI button and menu code with Bootstrap markup. This patch moves the functionality of cataloging-toolbar.inc into addbooks.tt since it is the only place where the include was used. cataloging-toolbar.inc is removed. To test, view the cataloging home page. Buttons and menus should look correct and work correctly. Signed-off-by: Bernardo Gonzalez Kriegel Comment: Buttons look and work well. No errors. Please sign Bug 3549 Signed-off-by: Katrin Fischer Works nicely, no problems found. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 08:17:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2013 07:17:42 +0000 Subject: [Koha-bugs] [Bug 9722] Allow users to add notes when placing a hold in opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9722 --- Comment #8 from M. de Rooy --- Created attachment 15836 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15836&action=edit Bug 9722: Toggle display of hold notes with Edit notes button Small adjustments, requested by Kyle: 1) Rename Show notes button. It is called now: Edit notes. 2) Do not hide all other notes fields. The Edit button now only toggles the corresponding hold notes field. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 08:20:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2013 07:20:54 +0000 Subject: [Koha-bugs] [Bug 9722] Allow users to add notes when placing a hold in opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9722 --- Comment #9 from M. de Rooy --- (In reply to comment #6) > 1) The "Show notes" buttons should probably be titled "Add notes" instead. Changed it to Edit notes. > 2) When doing a multi-hold, clicking one "Show notes" button hides the > previously visible note textarea. This is jarring and may confuse patrons > into thinking they can only have a note on one and only one of the holds. It > would be better to make each "Show notes" button a toggle to hide it's own > note textarea, and clear that textarea if it gets hidden. You could even > change the text from "Add notes" to "Remove notes" when the textarea is > visible. The button now only toggles its own textarea. I do not prefer to remove the notes with one click. Shift-select or Ctrl+A plus delete does the job well enough :) Thanks for testing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 08:21:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2013 07:21:11 +0000 Subject: [Koha-bugs] [Bug 9672] Replace YUI buttons on MARC editor page with Bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9672 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 08:21:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2013 07:21:14 +0000 Subject: [Koha-bugs] [Bug 9672] Replace YUI buttons on MARC editor page with Bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9672 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15595|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 15837 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15837&action=edit [PASSED QA] Bug 9672 - Replace YUI buttons on MARC editor page with Bootstrap This patch converts the buttons on the MARC editor page to Bootstrap, replacing YUI button and menu code with Bootstrap markup. Various workflows must be tested to confirm that functionality remains unchanged: - Edit existing record. Clicking the "save" button should redirect you to the default "view" page for that record. - Create a new record. Clicking the "save" button should redirect you to the add/edit items screen. - When creating or editing a record, test the dropdown menu attached to the "save" button. Each function should work correctly. - Test using a user who does not have "edit items" permission. There should be no menu attached to the "save" button. - Test using fast cataloging through circulation. A single save button should appear, redirecting to items. In all cases validation should proceed before saving. Leave a required field empty to test. Testers should also confirm that Z39.50 button works as expected and changing frameworks still works as usual. Signed-off-by: Bernardo Gonzalez Kriegel Comment: All workflows tested, with resticted and super user. All buttons worked as expected. No errors. Signed-off-by: Katrin Fischer Works nicely, no problems found. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 08:21:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2013 07:21:36 +0000 Subject: [Koha-bugs] [Bug 9672] Replace YUI buttons on MARC editor page with Bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9672 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de QA Contact| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 08:26:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2013 07:26:04 +0000 Subject: [Koha-bugs] [Bug 9741] New: Search menu missing on edit items screen Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9741 Bug ID: 9741 Summary: Search menu missing on edit items screen Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/cataloguing/additem.pl?biblionumber=1337 4&frameworkcode= OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: katrin.fischer at bsz-bw.de CC: m.de.rooy at rijksmuseum.nl Created attachment 15838 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15838&action=edit screenshot The search toolbar on top of the screen is missing on the edit items screen. Steps to reproduce: 1) Create a new record 2) Save it 3) Verify that search options on top are missing, there is nothing between navigation and breadcrumbs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 08:26:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2013 07:26:15 +0000 Subject: [Koha-bugs] [Bug 9741] Search menu missing on edit items screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9741 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 08:32:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2013 07:32:40 +0000 Subject: [Koha-bugs] [Bug 8583] Add a warning if a Z39.50 search is started from the "Edit biblio record" page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8583 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #7 from Katrin Fischer --- I am not sure I like this change - actually I think it's a bit annoying for an experienced cataloger. Wouldn't it be better to change the button labelling maybe? It could say "Z39.50 overlay" or something else that makes sense in English. Also, the prompt always appears, even for a totally empty that has not been saved yet. It's totally unnecessary in this case. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 08:38:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2013 07:38:18 +0000 Subject: [Koha-bugs] [Bug 9742] New: Confirm overlay prompt always appears on creating record from Z39.50 Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9742 Bug ID: 9742 Summary: Confirm overlay prompt always appears on creating record from Z39.50 Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: katrin.fischer at bsz-bw.de CC: m.de.rooy at rijksmuseum.nl The new confirmation on starting a z39.50 serach in cataloguing always pops up, even when you are working on a new record that has not been saved yet (see bug 8583). Steps to reproduce: 1) Go to cataloguing 2) Start a new record by picking a framework 3) Start z39.50 search -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 08:39:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2013 07:39:10 +0000 Subject: [Koha-bugs] [Bug 9742] Confirm overlay prompt always appears on creating record from Z39.50 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9742 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |8583 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 08:39:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2013 07:39:10 +0000 Subject: [Koha-bugs] [Bug 8583] Add a warning if a Z39.50 search is started from the "Edit biblio record" page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8583 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |9742 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 08:42:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2013 07:42:19 +0000 Subject: [Koha-bugs] [Bug 8583] Add a warning if a Z39.50 search is started from the "Edit biblio record" page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8583 --- Comment #8 from Katrin Fischer --- I have filed a separate bug - maybe we can just make it appear a bit less often by eliminiating the prompt for a new record (bug 9742)? I understand the idea behind this - I was only taken a bit by surprise today when testing something else. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 09:06:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2013 08:06:26 +0000 Subject: [Koha-bugs] [Bug 9743] New: Mandatory opac hold notes under specified conditions Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9743 Bug ID: 9743 Summary: Mandatory opac hold notes under specified conditions Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl CC: gmcharlt at gmail.com Make new opac holds notes mandatory under conditions controlled by syspref and depending on record status. To illustrate: we examine MARC21 300$a; if it contains multiple parts/volumes, but there is only one item, we ask the user to specify a part in the notes. In this case we could implement by: call this situation reason 1, add it in code and template, and specify reason 1 in the syspref. The syspref may contain a number of such reasons like: 1,2&3,4 meaning check successively 1, or 2 and 3, or 4 for new hold requests. This allows for future extension and flexible configuration. When extending this further, we should probably add a small interface on top of the syspref instead of typing 1,2&3 etc. but imo this may be sufficient to start with. This development is part of bug 9721 (umbrella report for hold changes to meet special library needs). The patch builds on bug 9722 which allows opac users to add hold notes. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 09:06:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2013 08:06:50 +0000 Subject: [Koha-bugs] [Bug 9743] Mandatory opac hold notes under specified conditions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9743 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Patch complexity|--- |Small patch Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 09:07:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2013 08:07:32 +0000 Subject: [Koha-bugs] [Bug 9743] Mandatory opac hold notes under specified conditions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9743 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9721 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 09:07:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2013 08:07:32 +0000 Subject: [Koha-bugs] [Bug 9721] Umbrella report for hold changes to meet special library needs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9721 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9743 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 09:08:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2013 08:08:16 +0000 Subject: [Koha-bugs] [Bug 9722] Allow users to add notes when placing a hold in opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9722 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |9743 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 09:08:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2013 08:08:16 +0000 Subject: [Koha-bugs] [Bug 9743] Mandatory opac hold notes under specified conditions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9743 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |9722 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 09:41:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2013 08:41:54 +0000 Subject: [Koha-bugs] [Bug 9293] action_logs not tracking payments In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9293 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact| |jonathan.druart at biblibre.co | |m --- Comment #16 from Jonathan Druart --- Kyle, in master, Dumper is used only 1 time with logaction. But it is not blocker. QA comment: This patch adds some logs for payments, it is clean and seems to work as expected. I am not familiar with this module (Accounts.pm) so I don't know if I tested all cases. It is a small patch and it will not introduce regression so I mark it as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 09:42:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2013 08:42:22 +0000 Subject: [Koha-bugs] [Bug 9293] action_logs not tracking payments In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9293 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15782|0 |1 is obsolete| | --- Comment #17 from Jonathan Druart --- Created attachment 15839 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15839&action=edit Bug 9293 - action_logs not tracking payments Add all fine actions to action_logs via FinesLog syspref Test Plan: 1) Enable FinesLog 2) Apply patch 3) Try all the various fine related actions possible 4) Verify that each action creates an action_logs entry Signed-off-by: MJ Ray Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 10:05:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2013 09:05:34 +0000 Subject: [Koha-bugs] [Bug 5343] Subscription cost (Link serial and acqui modules) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5343 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13011|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart --- Created attachment 15840 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15840&action=edit Bug 5343: Link serial and acqui modules DB changements: - Adds 2 fields: subscription.reneweddate and aqorders.subscriptionid. - Removes 2 unused fields: aqorders.serialid and aqorders.subscription. Main test plan: 1) Create a subscription 2) Create a bookseller and a basket 3) Add a new order 'from a subscription' 4) Search your subscription and check if results are correct 5) Click on the "order" link 6) Check the biblio information are filled in the form 7) Select a budget and fill some price information. 8) retry steps 3 and 4. Verify you cannot order the same subscription. Message:Outstanding order (only one order per subscription is allowed). 9) click on your subscription (already added) and check you have a new table "Acquisition details" with your price information in the "Ordered amount" line. 10) receive this order 11) On your subscription detail page, the "Spent amount" line must be filled with your price information. 12) Re order the same subscription. Now you are allowed to. Prices information have to be filled with the previous information. 13) Retry some orders and click on a maximum of links in order to find a bug :) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 10:05:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2013 09:05:56 +0000 Subject: [Koha-bugs] [Bug 5343] Subscription cost (Link serial and acqui modules) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5343 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 10:16:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2013 09:16:15 +0000 Subject: [Koha-bugs] [Bug 9444] Use DataTables in system preferences editor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9444 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch QA Contact| |jonathan.druart at biblibre.co | |m --- Comment #8 from Jonathan Druart --- QA comment: Now all work great. This patch add datatable on the syspref tables. The first column (syspref names) is sortable. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 10:16:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2013 09:16:35 +0000 Subject: [Koha-bugs] [Bug 9444] Use DataTables in system preferences editor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9444 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15817|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart --- Created attachment 15841 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15841&action=edit Bug 9444 [Revised] Use DataTables in system preferences editor Replace the tablesorter plugin with the DataTables plugin in the "new" system preferences editor. To test, open the system preferences editor on any tab other than Local Use. Confirm that table sorting works correctly within each section. In this configuration there should be no pager and no results filtering. Revision corrects template path to datatables assets. Further revision fixes section-collapse JS Signed-off-by: Bernardo Gonzalez Kriegel Comment: Work as described. Collapsing restored. No errors. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 11:49:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2013 10:49:56 +0000 Subject: [Koha-bugs] [Bug 5786] Move AllowOnShelfHolds system preference to the Circulation Matrix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5786 --- Comment #75 from Katrin Fischer --- *** Bug 5434 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 11:49:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2013 10:49:56 +0000 Subject: [Koha-bugs] [Bug 5434] More granular hold rules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5434 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |DUPLICATE --- Comment #1 from Katrin Fischer --- I think this is a duplicate of 5786 - please reopen if I am mistaken. *** This bug has been marked as a duplicate of bug 5786 *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 12:02:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2013 11:02:56 +0000 Subject: [Koha-bugs] [Bug 3645] Specify Duedate as part of item type In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3645 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Version|master |3.6 Resolution|--- |FIXED --- Comment #1 from Katrin Fischer --- You can now set due dates as part of the circ matrix for all combinations of patron category, itemtype and library. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 13:12:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2013 12:12:15 +0000 Subject: [Koha-bugs] [Bug 9456] Add callnumber column to the cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 --- Comment #25 from Kyle M Hall --- Owen, the entire point of having the callnumber as a column in the cart is to be able to sort all the results by callnumber. Your patch does not accomplish this. This is the reason I created and submitted this bug. (In reply to comment #24) > I have attached a rebased copy of my patch because I think git was breaking > something in it's auto-merge with the Bootstrap changes. Kyle I'm not sure > why you created your patch as a follow-up to mine, since our approaches are > so different. I think yours should be constructed as a separate patch and > presented as an alternative rather than a follow-up to mine. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 13:12:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2013 12:12:42 +0000 Subject: [Koha-bugs] [Bug 9456] Add callnumber column to the cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15759|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 13:44:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2013 12:44:34 +0000 Subject: [Koha-bugs] [Bug 9743] Mandatory opac hold notes under specified conditions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9743 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 13:44:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2013 12:44:36 +0000 Subject: [Koha-bugs] [Bug 9743] Mandatory opac hold notes under specified conditions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9743 --- Comment #1 from M. de Rooy --- Created attachment 15842 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15842&action=edit Bug 9743: Mandatory opac hold notes under specified conditions Description: Adds a new preference OPACMandatoryHoldNotes controlling when hold notes are mandatory for opac users placing a hold. In this initial implementation four reasons for a mandatory hold are added: 1) MARC21 300$a contains a reference to multiple volumes/parts 2) Biblio has one item (used in combination with 1) 3) UNIMARC 200$a contains the word test (for testing purposes only) 4) MARC21 leader pos 7 is collection A new file is added to describe the use of this pref. The opac preferences form shows a link to that file. Test plan: 1) Enable OPACShowHoldNotes. 2) Enter 1&2,4 into OPACMandatoryHoldNotes (for MARC21 testing). For UNIMARC, you could use 3. 3) Change two biblios: one with leader 7==c and one with 1 item and 300a==2 v. For UNIMARC, you could add the word test to 200$a. 4) Place a hold in opac on these two books separately. Just verify if the hold notes display the reason for mandatory notes. Do not place the holds. Test if you can place a hold if the notes are empty. You should not be allowed to do so. 5) Enable DisplayMultiPlaceHold. Place hold on both books simultaneously. Verify if you see both reasons for mandatory notes. Place the holds. Check them in staff. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 13:44:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2013 12:44:42 +0000 Subject: [Koha-bugs] [Bug 9743] Mandatory opac hold notes under specified conditions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9743 --- Comment #2 from M. de Rooy --- Created attachment 15843 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15843&action=edit Bug 9743: dbrev for mandatory hold notes Adds pref OPACMandatoryHoldNotes. Test plan: Run [your server]/cgi-bin/koha/installer/install.pl?step=3&op=updatestructure Optionally, run a new install to test sysprefs.sql. Or: Edit sysprefs.sql, leave at least the last few lines including the new one. And run from command line: mysql -p [yourdatabase] < [your-clone]/installer/data/mysql/sysprefs.sql -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 13:58:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2013 12:58:49 +0000 Subject: [Koha-bugs] [Bug 9721] Umbrella report for hold changes to meet special library needs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9721 --- Comment #2 from M. de Rooy --- Bug 9743 should realize goal number 2. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 14:24:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2013 13:24:36 +0000 Subject: [Koha-bugs] [Bug 9456] Add callnumber column to the cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 --- Comment #26 from Owen Leonard --- (In reply to comment #25) > Owen, the entire point of having the callnumber as a column in the cart is > to be able to sort all the results by callnumber. Your patch does not > accomplish this. I realize this. My point was simply that submitting your patch as a follow-up to mine, rather than as a separate patch, doesn't make sense because your solution and my solution are completely different. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 14:30:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2013 13:30:40 +0000 Subject: [Koha-bugs] [Bug 9456] Add callnumber column to the cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 --- Comment #27 from Kyle M Hall --- That's true. I'll make mine a standalone patch. Thanks for the clarification! (In reply to comment #26) > (In reply to comment #25) > > Owen, the entire point of having the callnumber as a column in the cart is > > to be able to sort all the results by callnumber. Your patch does not > > accomplish this. > > I realize this. My point was simply that submitting your patch as a > follow-up to mine, rather than as a separate patch, doesn't make sense > because your solution and my solution are completely different. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 14:39:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2013 13:39:34 +0000 Subject: [Koha-bugs] [Bug 9377] itemtype in duplicate biblio search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9377 --- Comment #7 from Fridolyn SOMERS --- (In reply to comment #6) > Why is this patch needed? Would it not be better to simply remove the > itemtype check altogether, if it does not work properly? I agree if it is accepted by community. A false duplicate on title and author must be very unusual (maybe book and movie), and better show duplicate message too often than not enough. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 14:56:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2013 13:56:48 +0000 Subject: [Koha-bugs] [Bug 9456] Add callnumber column to the cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15759|0 |1 is obsolete| | Attachment #15760|0 |1 is obsolete| | Attachment #15813|0 |1 is obsolete| | --- Comment #28 from Kyle M Hall --- Created attachment 15844 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15844&action=edit Bug 9456 - Add callnumber column to the cart - Add monospacing and padding for callnumbers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 14:57:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2013 13:57:22 +0000 Subject: [Koha-bugs] [Bug 9456] Add callnumber column to the cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15844|0 |1 is obsolete| | --- Comment #29 from Kyle M Hall --- Created attachment 15845 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15845&action=edit [SIGNED-OFF] Bug 9456 - Add callnumber column to the cart This patch adds call-number sorting to the staff client cart. Sortining is enabled on the 'Items' column which uses a custom sorting routine to sort the callnumbers. If the sort is ascending, each column will be sorted by the highest ordered callnumber for that row. Likewise, if the sort is descending the table will be sorted by the lowest valued callnumber for that row. Signed-off-by: Delaye Stephane Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 14:57:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2013 13:57:32 +0000 Subject: [Koha-bugs] [Bug 9456] Add callnumber column to the cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 --- Comment #30 from Kyle M Hall --- Created attachment 15846 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15846&action=edit Bug 9456 - Add callnumber column to the cart - Improve individual item presentation in the Items column -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 14:57:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2013 13:57:44 +0000 Subject: [Koha-bugs] [Bug 9456] Add callnumber column to the cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 --- Comment #31 from Kyle M Hall --- Created attachment 15847 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15847&action=edit Bug 9456 - Add callnumber column to the cart - Add monospacing and padding for callnumbers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 14:58:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2013 13:58:14 +0000 Subject: [Koha-bugs] [Bug 9456] Add callnumber column to the cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15847|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 14:58:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2013 13:58:39 +0000 Subject: [Koha-bugs] [Bug 9456] Add callnumber column to the cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15846|Bug 9456 - Add callnumber |Bug 9456 - Add callnumber description|column to the cart - |column to the cart - QA |Improve individual item |Followup - Improve |presentation in the Items |individual item |column |presentation in the Items | |column -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 14:58:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2013 13:58:52 +0000 Subject: [Koha-bugs] [Bug 9456] Add callnumber column to the cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 15:00:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2013 14:00:05 +0000 Subject: [Koha-bugs] [Bug 9456] Add callnumber column to the cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15846|0 |1 is obsolete| | --- Comment #32 from Kyle M Hall --- Created attachment 15848 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15848&action=edit Bug 9456 - Add callnumber column to the cart - Improve individual item presentation in the Items column -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 15:01:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2013 14:01:20 +0000 Subject: [Koha-bugs] [Bug 9456] Add callnumber column to the cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 15:03:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2013 14:03:55 +0000 Subject: [Koha-bugs] [Bug 9456] Add callnumber column to the cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 --- Comment #33 from Kyle M Hall --- (In reply to comment #22) > I am a little bit doubtful about pushing this patch as-is. Although the > sorting seems to work, it becomes hard to tell what item belongs to which > library, and even where the call numbers begin and end: > http://screencast.com/t/meDgCBj3Rwm > > Is there some way we can group information about each item together so that > it's possible to follow? This presentation-only follow addresses this issue. Each item is on a single line, with the callnumber, library and location given different emphases. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 15:08:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2013 14:08:22 +0000 Subject: [Koha-bugs] [Bug 9074] DB dependent tests for is_holiday In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9074 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |WONTFIX --- Comment #16 from Tom?s Cohen Arazi --- This bug is not being discussed. As I said in Bug 9133 we need a data set for testing purposes. That's where this should fit instead of the default standard example values. That said, I mark this resolved wontfix. If anyone feels this should be different, just change the status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 15:28:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2013 14:28:59 +0000 Subject: [Koha-bugs] [Bug 9634] Allow for parameters re-use on SQL reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 16:08:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2013 15:08:56 +0000 Subject: [Koha-bugs] [Bug 8304] composed authorities Rameau management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8304 --- Comment #13 from Pierre Angot --- The syspref "dontmerge" wasn't activated ^^ I've made a little modification, and it's ok. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 16:10:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2013 15:10:12 +0000 Subject: [Koha-bugs] [Bug 8304] composed authorities Rameau management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8304 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |paul.poulain at biblibre.com --- Comment #14 from Paul Poulain --- Patch tested with a sandbox, by Pierre Angot -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 16:10:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2013 15:10:35 +0000 Subject: [Koha-bugs] [Bug 8304] composed authorities Rameau management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8304 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14564|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 16:10:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2013 15:10:42 +0000 Subject: [Koha-bugs] [Bug 8304] composed authorities Rameau management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8304 --- Comment #15 from Paul Poulain --- Created attachment 15849 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15849&action=edit Bug 8304 : composed authorities Rameau management Bug 5635: bulkmarcimport new parameters & features This patch is designed to manage the composed authorities the Way Rameau is coping with them in France. This enables libraries to merge composed authorities and only change the heading field. It supposes that the previous data is sent to merge function so that process deletes previous heading entries. Say you have in a biblio record : - 606 $9 1214 $3 123 $a Europe $9 1215 $3 456 $y France $9 1210 $3 199 $x Politiciens $9 1216 $3 789 $z 1801-1860 And you change authority 1210 -250 $a Politiciens into -250 $a Politique You should get : - 606 $9 1214 $3 123 $a Europe $9 1215 $3 456 $y France $9 1210 $3 199 $x Politique $9 1216 $3 789 $z 1801-1860 In an other record : - 606 $9 1210 $3 199 $a Politiciens You should get : - 606 $9 1210 $3 199 $a Politique This patch changes the merge function. And adds three internal functions. merge function has been prettyfied And documentation from GuessAuthTypeCode has been updated (had not been) Signed-off-by: Pierre Angot -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 17:00:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2013 16:00:02 +0000 Subject: [Koha-bugs] [Bug 8917] Track clicks to links external to Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #62 from Jonathan Druart --- QA comment: This patch add a link tracker at the OPAC for the result and detail pages. The feature works as expected without XSLT (3 options tested). I didn't test the pages with XSLT, I am a unimarc user and this patch does not modify the unimarc XSLTs. Marked as Passed QA. Note: the update database message is not correct ("Adds feature Bug 8917, the ability to track links clicked"). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 17:00:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2013 16:00:35 +0000 Subject: [Koha-bugs] [Bug 8917] Track clicks to links external to Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15818|0 |1 is obsolete| | Attachment #15819|0 |1 is obsolete| | Attachment #15820|0 |1 is obsolete| | Attachment #15821|0 |1 is obsolete| | Attachment #15822|0 |1 is obsolete| | Attachment #15823|0 |1 is obsolete| | Attachment #15824|0 |1 is obsolete| | Attachment #15825|0 |1 is obsolete| | --- Comment #63 from Jonathan Druart --- Created attachment 15850 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15850&action=edit Bug 8917 : Creating tables and system pref, no functional changes at all Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 17:00:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2013 16:00:47 +0000 Subject: [Koha-bugs] [Bug 8917] Track clicks to links external to Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 --- Comment #65 from Jonathan Druart --- Created attachment 15852 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15852&action=edit Bug 8917 : Script to log link clicks Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 17:00:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2013 16:00:43 +0000 Subject: [Koha-bugs] [Bug 8917] Track clicks to links external to Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 --- Comment #64 from Jonathan Druart --- Created attachment 15851 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15851&action=edit Bug 8917 : Adding link tracking to the opac detail page, without xslt Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 17:00:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2013 16:00:51 +0000 Subject: [Koha-bugs] [Bug 8917] Track clicks to links external to Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 --- Comment #66 from Jonathan Druart --- Created attachment 15853 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15853&action=edit Bug 8917 : Link tracking, changes to XSLT Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 17:00:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2013 16:00:54 +0000 Subject: [Koha-bugs] [Bug 8917] Track clicks to links external to Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 --- Comment #67 from Jonathan Druart --- Created attachment 15854 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15854&action=edit Bug 8917 : Fixing a bug bgkriegel spotted and removing tabs Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 17:00:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2013 16:00:58 +0000 Subject: [Koha-bugs] [Bug 8917] Track clicks to links external to Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 --- Comment #68 from Jonathan Druart --- Created attachment 15855 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15855&action=edit Bug 8917 : Shifting db dependent code to a module Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 17:01:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2013 16:01:04 +0000 Subject: [Koha-bugs] [Bug 8917] Track clicks to links external to Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 --- Comment #69 from Jonathan Druart --- Created attachment 15856 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15856&action=edit Bug 8917 : Follow up fixing bad behaviour that existed prior to this feature But the bug only becomes visible with link tracking on Prior to this patch it would put an empty link in the html Signed-off-by: Bernardo Gonzalez Kriegel General comment: Work as described. No errors. Tested all preference values with and without logged in user. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 17:01:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2013 16:01:12 +0000 Subject: [Koha-bugs] [Bug 8917] Track clicks to links external to Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 --- Comment #71 from Jonathan Druart --- Created attachment 15858 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15858&action=edit Bug 8917: replaces tab with spaces Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 17:01:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2013 16:01:08 +0000 Subject: [Koha-bugs] [Bug 8917] Track clicks to links external to Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 --- Comment #70 from Jonathan Druart --- Created attachment 15857 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15857&action=edit Bug 8917 : [ Sign followup ] Track clicks to links external to Koha Remove empty pod section in Koha/Linktracker.pm to make koha-qa happy. Add missing "\n" in installer/data/mysql/updatedatabase.pl Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 19:13:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2013 18:13:37 +0000 Subject: [Koha-bugs] [Bug 9316] Add Nginx install options with plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9316 Elliott Davis changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14789|0 |1 is obsolete| | --- Comment #34 from Elliott Davis --- Created attachment 15859 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15859&action=edit Bug 9316: Add ability to install/configure nginx Amended permissions for plack socket and fixed type Altered mount location for opac to reflect current koha path settings Update: Resolved merge problems -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 20:04:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2013 19:04:46 +0000 Subject: [Koha-bugs] [Bug 9656] fines.pl creating a log file should be optional In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9656 Elliott Davis changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15644|0 |1 is obsolete| | --- Comment #13 from Elliott Davis --- Created attachment 15860 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15860&action=edit Bug 9656: Make logging to a file optional (for fines) To test: 1/ Before the patch run misc/cronjobs/fines.pl Notice that a file has been written to /tmp 2/ rm the file 3/ Apply the patch and run the script again Notice the file is not created 4/ run the script with -l Notice the file is created again Signed-off-by: Bernardo Gonzalez Kriegel Comment: Now it work as described. No errors. Signed-off-by: Elliott Davis -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 20:04:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2013 19:04:58 +0000 Subject: [Koha-bugs] [Bug 9656] fines.pl creating a log file should be optional In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9656 Elliott Davis changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15814|0 |1 is obsolete| | --- Comment #14 from Elliott Davis --- Created attachment 15861 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15861&action=edit Bug 9656: Followup Make logging to a file optional (for fines) The -log option become optional if the -output_dir is given. Test plan: call the script with 1/ no one parameter : no log file 2/ -l : log file will be created in /tmp 3/ -o=/home/koha/var/log : log file with be created in the specified 4/ -o=/home/koha/var/log -l: Same as 3/ Signed-off-by: Bernardo Gonzalez Kriegel Comment: All combination of options tested. Works well. No errors. Signed-off-by: Elliott Davis -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 20:09:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2013 19:09:19 +0000 Subject: [Koha-bugs] [Bug 9656] fines.pl creating a log file should be optional In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9656 Elliott Davis changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |elliott at bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 21:43:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2013 20:43:40 +0000 Subject: [Koha-bugs] [Bug 9549] Local Cover are not displayed in the Shelf Browser. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9549 Maxime Pelletier changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pelletiermaxime at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 22:13:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2013 21:13:08 +0000 Subject: [Koha-bugs] [Bug 8620] Barcode searching not working correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8620 --- Comment #9 from Jared Camins-Esakov --- Created attachment 15862 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15862&action=edit Bug 8620: Any index overfull in DOM configurations The Any index seems like it may have been having too many elements added to it. I don't understand how that is possible, but there you go. This patch tests the theory, by changing the way the Any index is populated. To test: 1) Apply patch. 2) Update the following two files: etc/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl etc/zebradb/xsl/koha-indexdefs-to-zebra.xsl 3) Reindex 4) Do a search that was previously failing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 22:26:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2013 21:26:14 +0000 Subject: [Koha-bugs] [Bug 9744] New: Add a column Fund name on the home page of acquisitions Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9744 Bug ID: 9744 Summary: Add a column Fund name on the home page of acquisitions Classification: Unclassified Change sponsored?: Sponsored Product: Koha Version: 3.8 Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: pelletiermaxime at gmail.com Here is a patch to add a column "Fund name" the the acquisition home. It also includes css to move the table below the content if the table is too big to fit in the page. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 22:26:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2013 21:26:42 +0000 Subject: [Koha-bugs] [Bug 9744] Add a column Fund name on the home page of acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9744 Maxime Pelletier changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |pelletiermaxime at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 22:35:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2013 21:35:26 +0000 Subject: [Koha-bugs] [Bug 8620] Barcode searching not working correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8620 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 22:35:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2013 21:35:28 +0000 Subject: [Koha-bugs] [Bug 8620] Barcode searching not working correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8620 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15293|0 |1 is obsolete| | Attachment #15862|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer --- Created attachment 15863 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15863&action=edit [SIGNED OFF] Bug 8620: Any index overfull in DOM configurations The Any index seems like it may have been having too many elements added to it. I don't understand how that is possible, but there you go. This patch tests the theory, by changing the way the Any index is populated. To test: 1) Apply patch. 2) Update the following two files: etc/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl etc/zebradb/xsl/koha-indexdefs-to-zebra.xsl 3) Reindex 4) Do a search that was previously failing. Signed-off-by: Katrin Fischer Fixes the problem for me - formerly not working callnumbers and barcodes are now found in keyword (any) searches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 22:36:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2013 21:36:32 +0000 Subject: [Koha-bugs] [Bug 8620] Barcode searching not working correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8620 --- Comment #11 from Katrin Fischer --- Martin or Ian, maybe you can test this patch on one of your installations too? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 22:39:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2013 21:39:21 +0000 Subject: [Koha-bugs] [Bug 8620] Barcode searching not working correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8620 --- Comment #12 from Martin Renvoize --- I'll also test this one tomorrow... would be nice to get the any index all working properly! Martin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 22:42:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2013 21:42:25 +0000 Subject: [Koha-bugs] [Bug 9744] Add a column Fund name on the home page of acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9744 --- Comment #1 from Maxime Pelletier --- Created attachment 15864 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15864&action=edit Patch based on 3.8.5 Initial patch based on 3.8.5. Will rebabase it on master soon. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 23:03:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2013 22:03:19 +0000 Subject: [Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 --- Comment #30 from Jared Camins-Esakov --- Created attachment 15865 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15865&action=edit Bug 9239 QA follow-up: fix highlighting and merge error QP searches with && broke search highlighting on the OPAC details page. This patch corrects encoding of the query_desc parameter that is passed to the details page. My last attempt at rebasing also transposed the variable for index names with the variable for operators, meaning that the dropdown in the basic search did not work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 23:08:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2013 22:08:46 +0000 Subject: [Koha-bugs] [Bug 9745] New: Don't nuke translated permissions with changes introduced in bug 9382 Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9745 Bug ID: 9745 Summary: Don't nuke translated permissions with changes introduced in bug 9382 Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Database Assignee: gmcharlt at gmail.com Reporter: liz at catalyst.net.nz We should not nuke translated sysprefs in the DB - we should look for the english strings instead. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 23:18:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2013 22:18:45 +0000 Subject: [Koha-bugs] [Bug 4164] Way to Clone Keyword Mapping to other Frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4164 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #1 from David Cook --- (In reply to comment #0) > > > ---- Reported by nengard at gmail.com 2010-02-11 15:27:06 ---- > > Right now you have to enter a keyword mapping for each framework, I would > like to say apply this to 'all' frameworks or have a way to clone it to > specific other frameworks so that I don't have to enter the same thing over > and over again. > > > > --- Bug imported by chris at bigballofwax.co.nz 2010-05-21 01:23 UTC --- > > This bug was previously known as _bug_ 4164 at > http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4164 > > Actual time not defined. Setting to 0.0 This could certainly be useful. I know that I find it rather annoying to either have to enter the same thing over and over again or resort to doing a change straight to the database. I'm actually working on making the keyword mapping more useful, so maybe this is something I'll keep in mind down the road... -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 23:25:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2013 22:25:09 +0000 Subject: [Koha-bugs] [Bug 5614] patron prefs not in categories In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5614 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #1 from David Cook --- This could certainly be useful. Serials might also benefit from a categorization of the system preferences... -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 23:28:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2013 22:28:57 +0000 Subject: [Koha-bugs] [Bug 9744] Add a column Fund name on the home page of acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9744 --- Comment #2 from Maxime Pelletier --- Created attachment 15866 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15866&action=edit Patch based on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 23:29:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2013 22:29:02 +0000 Subject: [Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15865|0 |1 is obsolete| | --- Comment #31 from Chris Cormack --- Created attachment 15867 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15867&action=edit Bug 9239 QA follow-up: fix highlighting and merge error QP searches with && broke search highlighting on the OPAC details page. This patch corrects encoding of the query_desc parameter that is passed to the details page. My last attempt at rebasing also transposed the variable for index names with the variable for operators, meaning that the dropdown in the basic search did not work. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 23:29:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2013 22:29:41 +0000 Subject: [Koha-bugs] [Bug 9744] Add a column Fund name on the home page of acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9744 Maxime Pelletier changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Version|3.8 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 23:32:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2013 22:32:01 +0000 Subject: [Koha-bugs] [Bug 5302] Replace current call number splitting code with a plug-in system based on classification source In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5302 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #1 from David Cook --- I don't know if this is really necessary. I did make a mod a while ago to allow splitting for items that use the "z" - "Other/Generic Classification Scheme", but I'm not sure that much else is needed beyond that? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 23:34:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2013 22:34:05 +0000 Subject: [Koha-bugs] [Bug 9746] New: Perl module libdbd-sqlite2|3-perl Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9746 Bug ID: 9746 Summary: Perl module libdbd-sqlite2|3-perl Classification: Unclassified Change sponsored?: --- Product: Koha Version: 3.8 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: gmcharlt at gmail.com Reporter: paul.a at aandc.org libdbd-sqlite2-perl has been replaced by libdbd-sqlite3-perl for normal apt-get use by Ubuntu. On tarball installation koha_perl_deps.pl -m gives the "2" version as "missing - not required" but after install highlights DBD::SQLite2 in bright pink (even if DBD::SQLite3 is installed.) If DBD::SQLite3 is backwards compatible maybe file 'ubuntu.12.04.packages' should be updated. I believe that any functionality of this module is limited to "offline circulation" but am not in a position to verify. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 23:49:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2013 22:49:11 +0000 Subject: [Koha-bugs] [Bug 8620] Barcode searching not working correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8620 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com --- Comment #13 from Galen Charlton --- In my testing, the bug appeared if the -x option to rebuild_zebra.pl was omitted -- i.e., searching by barcode-as-keyword didn't work then. If one of the affected records was reindexed with the -x option, it worked. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 23:52:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2013 22:52:05 +0000 Subject: [Koha-bugs] [Bug 9745] Don't nuke translated permissions with changes introduced in bug 9382 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9745 --- Comment #1 from Liz Rea --- Created attachment 15868 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15868&action=edit Bug 9745 - don't nuke translated strings in permissions on DB upgrade To test: (this is best done by someone who has a database with translated strings for user permissions - I'm looking towards Katrin. :)) Get a 3.6-3.8 era database loaded as test data - also please use a low value test database. Translate or change the strings in the database for the user permissions that follow in mysql client (for those who didn't install with a different language that has translated files at install time) - update userflags set flagdesc="Translated text 1" where flag IN('catalogue','editauthorities','reports','management','serials','updatecharges','circulate','parameters','borrowers','tools','staffaccess','edit_patrons'); (you will notice that this changes all of the permission labels in the interface to "translated text 1" for the affected permission flags. This is why I don't want you to use a high value test database.) Update that to master + this patch - your "translations" should be intact. Blow that database away, and make a brand new one 3.6-3.8 era with the english database definitions. Run the update again with this patch, the strings should be updated correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 00:38:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2013 23:38:18 +0000 Subject: [Koha-bugs] [Bug 8620] Barcode searching not working correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8620 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15863|0 |1 is obsolete| | --- Comment #14 from Galen Charlton --- Created attachment 15869 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15869&action=edit Bug 8620: Any index in DOM mode sensitive to -x flag of rebuild_zebra.pl The definition of the Any index was sensitive to whether spaces were present between (say) subfield elements in the MARCXML representation of the bib being indexed. When using the -x option to rebuild_zebra.pl, spaces would be present because of how MARC::File::XML emits MARCXML. When not using the -x option, spaces would not be present and the contents of a field would be run together, potentially as one big token. The visible behavior was that doing a keyword search by item barcode would sometimes not work. To test: 0) Make sure Zebra is using DOM mode 1) Create an item record. 2) Reindex using rebuild_zebra.pl -b -z, *without* -x 3) Do a keyword search by the barcode of the item just added; the search shouldn't work 4) Apply patch. 5) Update the following two files: etc/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl etc/zebradb/xsl/koha-indexdefs-to-zebra.xsl 6) Reindex 7) Do a search that was previously failing. Signed-off-by: Katrin Fischer Fixes the problem for me - formerly not working callnumbers and barcodes are now found in keyword (any) searches. Signed-off-by: Galen Charlton (revised commit description to better explain why it fixes the problem) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 01:00:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2013 00:00:05 +0000 Subject: [Koha-bugs] [Bug 9745] Don't nuke translated permissions with changes introduced in bug 9382 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9745 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |bgkriegel at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 01:04:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2013 00:04:16 +0000 Subject: [Koha-bugs] [Bug 9431] Use DataTables on Patron Category Administration page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9431 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 01:04:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2013 00:04:17 +0000 Subject: [Koha-bugs] [Bug 9431] Use DataTables on Patron Category Administration page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9431 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15695|0 |1 is obsolete| | --- Comment #11 from Owen Leonard --- Created attachment 15870 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15870&action=edit Bug 9431 [Revised] Use DataTables on Patron Category Administration page Replace the tablesorter plugin with the DataTables plugin on the patron category administration page. Structural changes were made to the table markup for validity and to deal with a DataTables bug which prevents it from properly parsing a with a colspan. To test, open the Patron Category Administration page (Administration -> Patron types and categories). Confirm that table sorting works correctly. Revision adds a "natural sort" plugin to the main datatables configuration JavaScript file to enable sorting of columns like those in this table which include mixed numeric and text data. Allows correct numeric sorting of data like "0 years, 1 years, 2 years, 18 years," etc. Further revision corrects template path to datatables assets. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 01:08:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2013 00:08:12 +0000 Subject: [Koha-bugs] [Bug 7884] Ergonomics & usability omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7884 Bug 7884 depends on bug 2780, which changed state. Bug 2780 Summary: Capitalize strings consistently http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2780 What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 01:08:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2013 00:08:10 +0000 Subject: [Koha-bugs] [Bug 2780] Capitalize strings consistently In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2780 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED --- Comment #161 from Owen Leonard --- I'm sure there are minor instances of this remaining to be fixed, but they can be handled individually as we find them. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 02:52:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2013 01:52:31 +0000 Subject: [Koha-bugs] [Bug 2499] Improvement on text wrapping algorithm needed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2499 wajasu changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matted-34813 at mypacks.net --- Comment #3 from wajasu --- I did write a sub-routine in C4/Labels/Labels.pm that used StrWidth for each individual character of the specified font/fontsize, such that if it was going to get truncated, it would scan back to the prior space and wrap to the next line. Typically, the title being the culprit. I did get a word or two extra in the first line. I did not add behavior to throw way the second line, if there are more lines to be written. I suppose this would also need to content with varying line height based on the fontsize, because folks might be dropping to a smaller fontsize (10 is about 4 lines, 6 might get you more). But my labels are usually: itemcallnumber, author, title (possible2 lines) in a BIBBAR printstyle. font Times Roman, fontsize 10. A title like: Salty librarians, and savvy cataloguers, dusty books : became: Salty librarians, and savvy cataloguers,dusty books : with my proportional wrap. Let me know and I'll work on sending a patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 03:10:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2013 02:10:26 +0000 Subject: [Koha-bugs] [Bug 2499] Improvement on text wrapping algorithm needed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2499 --- Comment #4 from Chris Nighswonger --- I'm not sure what approach you've taken, but here is the problem code: http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=C4/Labels/Label.pm;h=760bacfed998674f9b6544bae7a25b0f9d4aa811;hb=HEAD#l433 433 eval{$Text::Wrap::columns = $self->{'text_wrap_cols'};}; 434 my @line = split(/\n/ ,wrap('', '', $field_data)); 435 # If this is a title field, limit to two lines; all others limit to one... FIXME: this is rather arbitrary 436 if ($field->{'code'} eq 'title' && scalar(@line) >= 2) { 437 while (scalar(@line) > 2) { 438 pop @line; 439 } 440 } else { 441 while (scalar(@line) > 1) { 442 pop @line; 443 } 444 } 445 push(@label_lines, @line); 446 } As it is it is, well, rather arbitrary. A little while later we do something much more intelligent to figure line width in the justification routine: 450 my $string_width = C4::Creators::PDF->StrWidth($line, $font, $self->{'font_size'}); Something similar could be done to replace the arbitrary method back at lines 433-446. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 08:03:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2013 07:03:06 +0000 Subject: [Koha-bugs] [Bug 9688] Replace YUI button on Authority MARC framework toolbar with Bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9688 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 08:03:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2013 07:03:08 +0000 Subject: [Koha-bugs] [Bug 9688] Replace YUI button on Authority MARC framework toolbar with Bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9688 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15628|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 15871 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15871&action=edit [PASSED QA] Bug 9688 - Replace YUI button on Authority MARC framework toolbar with Bootstrap This patch converts the toolbar used on the Authority MARC framework toolbar to Bootstrap, replacing YUI button code with Bootstrap markup. To test, view auth_tag_structure.pl for any authority framework. Confirm that the 'New tag' button looks correct and works correctly. Signed-off-by: Bernardo Gonzalez Kriegel Comment: Works and looks correctly. No errors. Signed-off-by: Katrin Fischer Works nicely, no problems found. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 08:07:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2013 07:07:24 +0000 Subject: [Koha-bugs] [Bug 9696] Remove YUI styling from buttons on patron card creator edit pages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9696 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 08:13:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2013 07:13:36 +0000 Subject: [Koha-bugs] [Bug 9690] Replace YUI buttons on the catalog search results page with Bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9690 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 08:13:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2013 07:13:38 +0000 Subject: [Koha-bugs] [Bug 9690] Replace YUI buttons on the catalog search results page with Bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9690 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15636|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 15873 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15873&action=edit [PASSED QA] Bug 9690 - Replace YUI buttons on the catalog search results page with Bootstrap "Save," "Place hold," and "Z39.50 search" buttons on the catalog search results page are generated by YUI. This patch removes YUI styling from the "Save" button and uses Bootstrap to apply styling to the "Place hold" and "Z39.50 search" button. The "search to hold" split button menu is converted to Bootstrap as well. The "Save" button's appearance is inconsistent with the Bootstrap ones, but right now we don't have a good method for overriding the default submit button CSS with Bootstrap button styling. I hope this can be dealt with in a more global way in a subsequent patch. To test, search the catalog in the staff client. Confirm that the "Save," "Place hold," and "Z39.50 search" buttons look correct and work correctly. Also select a patron and "search to hold," confirming the functionality of all the opitions added to the "Place hold" button menu. Signed-off-by: Bernardo Gonzalez Kriegel Comment: All buttons works ok, nice looking. No errors. On button 'Place hold', all opitions works :) Signed-off-by: Katrin Fischer Works nicely, no problems found. Noticed that buttons here are smaller than in other places, but this has been so before. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 08:07:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2013 07:07:59 +0000 Subject: [Koha-bugs] [Bug 9696] Remove YUI styling from buttons on patron card creator edit pages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9696 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de QA Contact| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 08:07:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2013 07:07:25 +0000 Subject: [Koha-bugs] [Bug 9696] Remove YUI styling from buttons on patron card creator edit pages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9696 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15638|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 15872 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15872&action=edit [PASSED QA] Bug 9696 - Remove YUI styling from buttons on patron card creator edit pages Submit and cancel buttons on patron card creator edit pages should not be styled differently than other submit and cancel controls. This patch removes YUI styling of these controls and makes them consistent with controls on other Koha pages. The "Cancel" button has been removed altogether from the batch edit page since there is not a corresponding submit button. To test, got to the patron card creator and edit a batch, a layout, a profile, and a template. Submit and cancel controls should look correct and work correctly. Signed-off-by: Bernardo Gonzalez Kriegel Comment: Work as described. Works and looks well. No errors. Note: It's true that edit batch has not a submit button, but on the other managed pages (layout, profile, template) cancel aborts editing and takes you to a list of objects (layout, etc.) Now if we selected the wrong batch, we need to click on left menu o back button (yay). Are we loosing a consistent interface? Just thinking. Signed-off-by: Katrin Fischer Works as described, more consistent with Koha's general interface patterns. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 08:17:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2013 07:17:06 +0000 Subject: [Koha-bugs] [Bug 9690] Replace YUI buttons on the catalog search results page with Bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9690 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de QA Contact| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 08:20:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2013 07:20:21 +0000 Subject: [Koha-bugs] [Bug 9698] Replace YUI buttons on patron card creator manage toolbar with Bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9698 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 08:20:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2013 07:20:23 +0000 Subject: [Koha-bugs] [Bug 9698] Replace YUI buttons on patron card creator manage toolbar with Bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9698 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15641|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 15874 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15874&action=edit [PASSED QA] Bug 9698 - Replace YUI buttons on patron card creator manage toolbar with Bootstrap This patch converts the toolbar include file used by the patron card creator home and manage pages to Bootstrap, replacing YUI button and menu code with Bootstrap markup. This patch converts the previous menu buttons to plain buttons, removing the redundant links to the manage pages, which are in the left-hand sidebar. This keeps toolbar buttons within the general category of "action" (as opposed to "view"). To test, view the patron card creator home page and any manage page ("Manage layouts," "Manage profiles," etc). Buttons should look correct and work correctly. Signed-off-by: Bernardo Gonzalez Kriegel Comment: Work as described. No errors. No "plus" sign for this buttons? Signed-off-by: Katrin Fischer No plus signs? :) Works nicely and didn't have the plus before, so it's ok. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 08:21:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2013 07:21:57 +0000 Subject: [Koha-bugs] [Bug 9698] Replace YUI buttons on patron card creator manage toolbar with Bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9698 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de QA Contact| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 08:27:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2013 07:27:36 +0000 Subject: [Koha-bugs] [Bug 9694] Remove YUI styling from buttons on the patron card creator manage pages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9694 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 08:27:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2013 07:27:38 +0000 Subject: [Koha-bugs] [Bug 9694] Remove YUI styling from buttons on the patron card creator manage pages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9694 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15635|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 15875 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15875&action=edit [PASSED QA] Bug 9694 - Remove YUI styling from buttons on the patron card creator manage pages Buttons on the patron card creator's manage pages (manage templates, manage profiles, etc) are styled using YUI. They can be classified as submit buttons rather than toolbar buttons, so they should have default submit button styles. This patch removes YUI styling and related JavaScript. Other minor changes: Escaping strings in JavaScript for translation. To test, view the patron card creator's manage page for layouts, templates, profiles, and batches. "Edit," "Delete," and "Export" buttons should look correct and work correctly. Signed-off-by: Bernardo Gonzalez Kriegel Comment: Work as described. On errors. Tested all manage pages, edit, delete, and export buttons. Signed-off-by: Katrin Fischer Works nicely, improves consistency. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 08:28:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2013 07:28:12 +0000 Subject: [Koha-bugs] [Bug 9694] Remove YUI styling from buttons on the patron card creator manage pages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9694 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de QA Contact| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 08:33:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2013 07:33:37 +0000 Subject: [Koha-bugs] [Bug 9574] serials/subscription-add.pl does not work right under Plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9574 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 08:33:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2013 07:33:40 +0000 Subject: [Koha-bugs] [Bug 9574] serials/subscription-add.pl does not work right under Plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9574 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15314|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 15876 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15876&action=edit [PASSED QA] Bug 9574: Plack fixes for serials/subscription-add.pl This patch fixes the following warnings under Plack: * Use of uninitialized value $firstissuedate in string eq at \ /home/jcamins/kohaclone/serials/subscription-add.pl line 92. * Use of uninitialized value $firstissuedate in substr at \ /home/jcamins/kohaclone/serials/subscription-add.pl line 105. * Use of qw(...) as parentheses is deprecated at \ /home/jcamins/kohaclone/serials/subscription-add.pl line 95. * Variable "$firstissuedate" is not available at \ /home/jcamins/kohaclone/serials/subscription-add.pl line 338. To test: 1) Create a subscription. Ensure that setting the first issue's publication date works. 2) Edit a subscription. Ensure that the first issue's publication date shows up. 3) Sign off. Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer No regressions found, all tests and QA script pass. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 08:34:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2013 07:34:11 +0000 Subject: [Koha-bugs] [Bug 9574] serials/subscription-add.pl does not work right under Plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9574 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de QA Contact| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 08:42:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2013 07:42:22 +0000 Subject: [Koha-bugs] [Bug 9653] Filters on suggestion page in intranet are broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9653 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 08:42:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2013 07:42:24 +0000 Subject: [Koha-bugs] [Bug 9653] Filters on suggestion page in intranet are broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9653 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15584|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 15877 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15877&action=edit [PASSED QA] Bug 9653: FIX collapse class is used by already Bootstrap Quick, simple and dirty fix. Test plan: Apply this patch and check that filters are present on the suggestion management page. Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Filters are back on the page, regression fixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 08:43:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2013 07:43:58 +0000 Subject: [Koha-bugs] [Bug 9653] Filters on suggestion page in intranet are broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9653 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off QA Contact| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 08:44:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2013 07:44:04 +0000 Subject: [Koha-bugs] [Bug 9653] Filters on suggestion page in intranet are broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9653 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 09:30:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2013 08:30:26 +0000 Subject: [Koha-bugs] [Bug 9428] Use DataTables in Authority MARC frameworks page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9428 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch QA Contact| |jonathan.druart at biblibre.co | |m --- Comment #7 from Jonathan Druart --- QA comment: This patch replaces tablesorter with datatable on the auth framework page. Owen said me that the aLengthMenu has to be present on the patch, so I will re-add it in my sign-off patch. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 09:30:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2013 08:30:38 +0000 Subject: [Koha-bugs] [Bug 9428] Use DataTables in Authority MARC frameworks page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9428 --- Comment #8 from Jonathan Druart --- Created attachment 15878 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15878&action=edit Bug 9428 [Revised] Use DataTables in Authority MARC frameworks page Replace the tablesorter plugin with the DataTables plugin on the Authority MARC frameworks page. To test, open the Authority MARC frameworks page (Authority types -> MARC structure). Confirm that table sorting works correctly. Revision corrects template path to datatables assets. Signed-off-by: Bernardo Gonzalez Kriegel Comment: Work as described. No errors. Signed-off-by: Jonathan Druart Amended patch: Add the aLengthMenu key for DataTables -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 09:31:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2013 08:31:03 +0000 Subject: [Koha-bugs] [Bug 9428] Use DataTables in Authority MARC frameworks page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9428 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15737|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 09:40:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2013 08:40:42 +0000 Subject: [Koha-bugs] [Bug 9429] Use DataTables on Authorized Values page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9429 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart at biblibre.co | |m Patch complexity|--- |Trivial patch QA Contact| |jonathan.druart at biblibre.co | |m --- Comment #6 from Jonathan Druart --- QA comment: This patch replaces tablesorter with datatables on the authorized values page. All works great. Just one small remark: the "no limitation" is sorted after the "XXX limitations". But it is not blocker at all. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 09:41:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2013 08:41:22 +0000 Subject: [Koha-bugs] [Bug 9429] Use DataTables on Authorized Values page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9429 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15738|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 15879 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15879&action=edit Bug 9429 [Revised] Use DataTables on Authorized Values page Replace the tablesorter plugin with the DataTables plugin on the Authorized Values page. To test, open the Authorized Values page (Administration -> Authorized values). Confirm that table sorting works correctly. Revision corrects template path to datatables assets. Signed-off-by: Bernardo Gonzalez Kriegel Comment: Work as described. No errors. Signed-off-by: Jonathan Druart Amended patch: Add the aLengthMenu key for DataTables -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 09:59:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2013 08:59:47 +0000 Subject: [Koha-bugs] [Bug 9430] Use DataTables on library transfer limits page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9430 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart at biblibre.co | |m Patch complexity|--- |Trivial patch QA Contact| |jonathan.druart at biblibre.co | |m --- Comment #6 from Jonathan Druart --- QA comment: This patch replaces tablesorter with datatable on the branch transfer limits page. A little ergonomic issue: the table in the first tab has not the same width as others (the "min-width: 50%;" is not adequate). Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 10:00:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2013 09:00:43 +0000 Subject: [Koha-bugs] [Bug 9430] Use DataTables on library transfer limits page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9430 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15739|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 15880 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15880&action=edit Bug 9430 [Revised] Use DataTables on library transfer limits page Replace the tablesorter plugin with the DataTables plugin on the library transfer limits page. Also made minor changes to "check/uncheck all" function to prevent page from jumping on click, and removed unused function. To test, open the library transfer limits page (Administration -> Library transfer limits). Confirm that table sorting works correctly for all tables. Test that the "check all/uncheck all" links still work correctly. Revision corrects template path to datatables assets. Signed-off-by: Bernardo Gonzalez Kriegel Comment: Work as described. No errors. Signed-off-by: Jonathan Druart Amended patch: Add the aLengthMenu key for DataTables + delete an unused div block (used for pager) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 10:08:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2013 09:08:37 +0000 Subject: [Koha-bugs] [Bug 9435] Use DataTables on libraries and groups administration page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9435 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch QA Contact| |jonathan.druart at biblibre.co | |m --- Comment #7 from Jonathan Druart --- QA comment: This patch replaces tablesorter with datatable on one of the tables of the libraries and groups page. This page contains 3 tables, it would be great if a followup (on another report) can be provided for these 2 others tables. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 10:08:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2013 09:08:53 +0000 Subject: [Koha-bugs] [Bug 9435] Use DataTables on libraries and groups administration page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9435 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15740|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart --- Created attachment 15881 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15881&action=edit Bug 9435 [Revised] Use DataTables on libraries and groups administration page Replace the tablesorter plugin with the DataTables plugin on the libraries and groups administration page. To test, open the libraries and groups administration page (Administration -> Libraries and groups). Confirm that table sorting works correctly. Revision corrects template path to datatables assets. Signed-off-by: Bernardo Gonzalez Kriegel Comment: Sort works. No errors. Signed-off-by: Jonathan Druart Amended patch: Add the aLengthMenu key for DataTables + delete an unused div block (used for pager) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 10:28:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2013 09:28:52 +0000 Subject: [Koha-bugs] [Bug 9436] Use DataTables on cities administration page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9436 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart at biblibre.co | |m --- Comment #6 from Jonathan Druart --- QA comment: This patch replaces tablesorter with datatable on the cities admin page. The pagination is not "four_button" I don't know if it is deliberate. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 10:29:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2013 09:29:11 +0000 Subject: [Koha-bugs] [Bug 9436] Use DataTables on cities administration page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9436 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15741|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 15882 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15882&action=edit Bug 9436 [Revised] Use DataTables on cities administration page Replace the tablesorter plugin with the DataTables plugin on the cities administration page. To test, open the cities administration page (Administration -> Cities and towns). Confirm that table sorting works correctly. Revision corrects template path to datatables assets. Signed-off-by: Bernardo Gonzalez Kriegel Comment: Sorting works. No errors. Signed-off-by: Jonathan Druart Amended patch: Add the aLengthMenu key for DataTables + delete an unused div block (used for pager) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 10:29:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2013 09:29:29 +0000 Subject: [Koha-bugs] [Bug 9436] Use DataTables on cities administration page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9436 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch QA Contact| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 10:40:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2013 09:40:25 +0000 Subject: [Koha-bugs] [Bug 9437] Use DataTables on itemtypes administration page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9437 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart at biblibre.co | |m Patch complexity|--- |Trivial patch QA Contact| |jonathan.druart at biblibre.co | |m --- Comment #6 from Jonathan Druart --- QA comment: This patch replace tablesorter with DT on the itemtypes admin page. Nothing to say. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 10:41:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2013 09:41:26 +0000 Subject: [Koha-bugs] [Bug 9437] Use DataTables on itemtypes administration page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9437 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15742|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 15883 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15883&action=edit Bug 9437 [Revised] Use DataTables on itemtypes administration page Replace the tablesorter plugin with the DataTables plugin on the itemtypes administration page. To test, open the itemtypes administration page (Administration -> Item types). Confirm that table sorting works correctly. Revision corrects template path to datatables assets. Signed-off-by: Bernardo Gonzalez Kriegel Comment: Sorting works. No errors. Signed-off-by: Jonathan Druart Amended patch: Delete an unused div block (used for pager). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 10:59:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2013 09:59:26 +0000 Subject: [Koha-bugs] [Bug 9446] Use DataTables on Z39.50 servers administration page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9446 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart at biblibre.co | |m Patch complexity|--- |Trivial patch QA Contact| |jonathan.druart at biblibre.co | |m --- Comment #5 from Jonathan Druart --- QA comment: This patch replaces tablesorter with datatable on the z3950 servers admin page. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 10:59:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2013 09:59:41 +0000 Subject: [Koha-bugs] [Bug 9446] Use DataTables on Z39.50 servers administration page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9446 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15745|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 15884 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15884&action=edit Bug 9446 [Revised] Use DataTables on Z39.50 servers administration page Replace the tablesorter plugin with the DataTables plugin on the Z39.50 servers administration page. Structural changes were made to deal with a DataTables bug which prevents it from properly parsing a with a colspan. This patch also moves embedding of the toolbar and table-sorting JS from within the body of the page to the for sake of consistency. To test, open the Z39.50 servers administration page (Administration -> Z39.50 client targets). Confirm that table sorting works correctly. Revision corrects template path to datatables assets. Signed-off-by: Bernardo Gonzalez Kriegel Comment: Table sorting works. No errors. Signed-off-by: Jonathan Druart Amended patch: Add the aLengthMenu key for DataTables -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 11:12:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2013 10:12:23 +0000 Subject: [Koha-bugs] [Bug 9747] New: sort issue for the z3950 results Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9747 Bug ID: 9747 Summary: sort issue for the z3950 results Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: jonathan.druart at biblibre.com CC: m.de.rooy at rijksmuseum.nl When some results contain NSB/NSE characters (\x88 and \x89), the results are not well sorted. To reproduce: search "tintin" on the BNF server. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 11:12:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2013 10:12:40 +0000 Subject: [Koha-bugs] [Bug 9747] sort issue for the z3950 results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9747 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9450 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 11:12:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2013 10:12:41 +0000 Subject: [Koha-bugs] [Bug 9450] Use DataTables in cataloging Z39.50 search results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9450 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9747 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 11:14:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2013 10:14:35 +0000 Subject: [Koha-bugs] [Bug 9450] Use DataTables in cataloging Z39.50 search results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9450 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart at biblibre.co | |m Patch complexity|--- |Trivial patch QA Contact| |jonathan.druart at biblibre.co | |m --- Comment #8 from Jonathan Druart --- QA comment: I got the sort issue but as Galen said it caused by the NSB/NSE characters (\x88Les \x89). I opened a new bug (bug 9747). Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 11:15:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2013 10:15:01 +0000 Subject: [Koha-bugs] [Bug 9450] Use DataTables in cataloging Z39.50 search results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9450 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15747|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart --- Created attachment 15885 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15885&action=edit Bug 9450 [Revised] Use DataTables in cataloging Z39.50 search results Replace the tablesorter plugin with the DataTables plugin in cataloging Z39.50 search results. Structural changes were made to the table markup to deal with a DataTables bug which prevents it from properly parsing a with a colspan. To test, go to cataloging and perform a Z39.50 search. Confirm that table sorting works correctly. In this configuration there should be no pager and no results filtering. Revision corrects template path to datatables assets. Signed-off-by: Bernardo Gonzalez Kriegel Comment: Sorting works. No errors. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 11:23:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2013 10:23:17 +0000 Subject: [Koha-bugs] [Bug 9466] Use DataTables on saved reports page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9466 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #8 from Jonathan Druart --- QA comment: On the reports/guided_reports.pl page, I got a js error: ReferenceError: dt_add_type_uk_date is not defined (js/datatables.js is only loaded if saved1 is defined). Marked as Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 12:37:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2013 11:37:46 +0000 Subject: [Koha-bugs] [Bug 9250] Provide commands to allow handling of SIP servers in the packages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9250 --- Comment #4 from Magnus Enger --- Created attachment 15886 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15886&action=edit Bug 9250 - provide commands to manage the SIP server This adds commands required to control the SIP server. These commands are: * koha-enable-sip - copies the SIP config to the sites directory * koha-start-sip - starts the SIP server processes * koha-stop-sip - stops the SIP server processes It also calls these as appropriate from the koha-common init script. To use: 1) sudo koha-enable-sip instancename 2) sudo vim /etc/koha/sites/instancename/SIPconfig.xml Do whatever is needed for your site's SIP configuration 3) sudo koha-start-sip instancename To test: 1) Build packages with this patch 2) Ensure that sudo koha-start-sip instancename doesn't do anything 3) Run sudo koha-enable-sip instancename 4) Edit /etc/koha/sites/instancename/SIPconfig.xml if needed (probably not required for testing) 5) Run sudo koha-start-sip instancename 6) Note that the sip processes are now running 7) Run sudo koha-stop-sip instancename 8) Note that the sip processes have gone 9) Reboot your Koha server 10) Note that the sip processes are back Sponsored-By: Waitaki District Council Libraries Sponsored-By: South Taranaki District Council Libraries Sponsored-By: Horowhenua District Council Libraries Sponsored-By: Rangitikei District Council Libraries Signed-off-by: Magnus Enger Works as advertised. koha-start-sip without a prior koha-enable-sip does nothing. koha-enable-sip copies the SIP config file to the instance directory. After koha-enable-sip, koha-start-sip and koha-stop-sip works as expected. After a reboot, the SIP processes are still running. I have not actually tested the SIP servers after they have been started, but assume they work the same as always. The man pages look good. The new commands should also have been added to the man page for koha-common. I'll do a followup for that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 12:38:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2013 11:38:41 +0000 Subject: [Koha-bugs] [Bug 9250] Provide commands to allow handling of SIP servers in the packages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9250 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14179|0 |1 is obsolete| | Attachment #15886|0 |1 is obsolete| | --- Comment #5 from Magnus Enger --- Created attachment 15887 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15887&action=edit Bug 9250 - [SIGNED-OFF] provide commands to manage the SIP server This adds commands required to control the SIP server. These commands are: * koha-enable-sip - copies the SIP config to the sites directory * koha-start-sip - starts the SIP server processes * koha-stop-sip - stops the SIP server processes It also calls these as appropriate from the koha-common init script. To use: 1) sudo koha-enable-sip instancename 2) sudo vim /etc/koha/sites/instancename/SIPconfig.xml Do whatever is needed for your site's SIP configuration 3) sudo koha-start-sip instancename To test: 1) Build packages with this patch 2) Ensure that sudo koha-start-sip instancename doesn't do anything 3) Run sudo koha-enable-sip instancename 4) Edit /etc/koha/sites/instancename/SIPconfig.xml if needed (probably not required for testing) 5) Run sudo koha-start-sip instancename 6) Note that the sip processes are now running 7) Run sudo koha-stop-sip instancename 8) Note that the sip processes have gone 9) Reboot your Koha server 10) Note that the sip processes are back Sponsored-By: Waitaki District Council Libraries Sponsored-By: South Taranaki District Council Libraries Sponsored-By: Horowhenua District Council Libraries Sponsored-By: Rangitikei District Council Libraries Signed-off-by: Magnus Enger Works as advertised. koha-start-sip without a prior koha-enable-sip does nothing. koha-enable-sip copies the SIP config file to the instance directory. After koha-enable-sip, koha-start-sip and koha-stop-sip works as expected. After a reboot, the SIP processes are still running. I have not actually tested the SIP servers after they have been started, but assume they work the same as always. The man pages look good. The new commands should also have been added to the man page for koha-common. I'll do a followup for that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 12:39:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2013 11:39:31 +0000 Subject: [Koha-bugs] [Bug 9250] Provide commands to allow handling of SIP servers in the packages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9250 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |magnus at enger.priv.no -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 13:56:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2013 12:56:32 +0000 Subject: [Koha-bugs] [Bug 9250] Provide commands to allow handling of SIP servers in the packages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9250 --- Comment #6 from Magnus Enger --- Created attachment 15888 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15888&action=edit Bug 9250 - Followup to add koha-*-sip commands to koha-common.xml The original patch for Bug 9250 did not add the new commands to debian/docs/koha-common.xml, which functions as a sort of table of contents for the real commands. This patch adds them. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 14:01:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2013 13:01:17 +0000 Subject: [Koha-bugs] [Bug 9747] sort issue for the z3950 results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9747 --- Comment #1 from Jonathan Druart --- Created attachment 15889 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15889&action=edit Bug 9747: Fix sorting issues on z3950 search results At least the BNF server returns results containing non-sorting characters (NSB SNE). In order to sort results according these characters, this patch adds a new Datatable function. Test plan: - search 'tintin' on the z3950 search (cataloguing/z3950_search.pl) - sort on title (default sort) and check that results are not well sorted. - apply this patch - do the same search and check that the first result is "Herg?. Les Aventures de Tintin..." The value of the cell is: ?Herg?. Les ?Aventures de Tintin... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 14:01:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2013 13:01:47 +0000 Subject: [Koha-bugs] [Bug 9450] Use DataTables in cataloging Z39.50 search results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9450 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |9747 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 14:01:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2013 13:01:47 +0000 Subject: [Koha-bugs] [Bug 9747] sort issue for the z3950 results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9747 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch Depends on| |9450 Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 14:33:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2013 13:33:28 +0000 Subject: [Koha-bugs] [Bug 9534] No way to get back to bib detail from edit record screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9534 --- Comment #1 from Owen Leonard --- We might add a "cancel" split button (split like the "save" button is) with these options: Primary button click -> Return to view (according to BiblioDefaultView pref) - menu option: Cancel and edit items (in case you don't want to save the record before proceeding to items). - menu option: Cancel and view record (same as primary button) We could also do something as simple as making the title in the

a link back to the detail view. If the solution requires a change to the toolbar, it should wait for (or depend on) Bug 9672. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 18:40:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2013 17:40:56 +0000 Subject: [Koha-bugs] [Bug 9673] Track when items are marked as lost or withdrawn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9673 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15567|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 15890 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15890&action=edit Bug 9673 - Track when items are marked as lost or withdrawn Add date fields to track when an item was marked as lost or withdrawn. Display those fields on catalogue/moredetail.pl Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Pick a record with items, browse to the 'items' tab ( moredetail.pl ) 4) Mark an item as lost, verify the field "Lost on:" displays below the "Lost status" field with todays date. 5) Mark the item as not lost, verify the field no longer displays 6) Repeat steps 4 and 5 with the Withdrawn field. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 18:41:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2013 17:41:11 +0000 Subject: [Koha-bugs] [Bug 9673] Track when items are marked as lost or withdrawn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9673 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 18:42:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2013 17:42:04 +0000 Subject: [Koha-bugs] [Bug 9673] Track when items are marked as lost or withdrawn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9673 --- Comment #4 from Kyle M Hall --- (In reply to comment #2) > Hi Kyle, > please add the new fields also to the deleteditems table, else deleting > items won't work correctly. I was also wondering if it might be useful to > add this information to action_log or statistics table? I believe this information may already be recorded in the action logs, but is not easily accessible to librarians as the format it is stored in is not exactly user friendly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 18:45:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2013 17:45:01 +0000 Subject: [Koha-bugs] [Bug 9458] Add sorting to lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9458 --- Comment #25 from Kyle M Hall --- > I am a little bit perplexed by this line. Why did you add the || 'title' > when $sortfield has already been set? Or, equivalently, why did you set > $sortfield previously? I would have thought the simplest way to get the > desired results would be: > my $sortfield = $query->param('sort') || $sorton || 'title'; > > My chief concern is, is there some sort of side-effect in the code that > you're trying to work around with this? Nope, that's just me being stupid ; ) I'll post a small followup to fix that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 18:47:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2013 17:47:00 +0000 Subject: [Koha-bugs] [Bug 9458] Add sorting to lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9458 --- Comment #26 from Kyle M Hall --- Created attachment 15891 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15891&action=edit Bug 9458 - Add sorting to lists - QA Followup 3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 19:24:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2013 18:24:59 +0000 Subject: [Koha-bugs] [Bug 7387] Add Template::Toolkit plugin to allow caching of includes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7387 Elliott Davis changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15503|0 |1 is obsolete| | --- Comment #13 from Elliott Davis --- Created attachment 15892 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15892&action=edit Bug 7387 : Adding a caching plugin for Template::Toolkit To use this you need to do something like -[% INCLUDE 'doc-head-open.inc' %] +[% USE cache = Cache %] +[% cache.inc( + 'template' => 'doc-head-open.inc', + 'keys' => {'dochead' => 'dochead'}, + 'ttl' => 360 + ) +%] Signed-off-by: Jared Camins-Esakov Signed-off-by: Bernardo Gonzalez Kriegel Comment: Works. Tested modifying as described opac-main.tt Follow up to fix tabulations. Signed-off-by: Elliott Davis -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 19:25:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2013 18:25:13 +0000 Subject: [Koha-bugs] [Bug 7387] Add Template::Toolkit plugin to allow caching of includes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7387 Elliott Davis changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15502|0 |1 is obsolete| | --- Comment #14 from Elliott Davis --- Created attachment 15893 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15893&action=edit Follow-up Bug 7387 - Add Template::Toolkit plugin to allow caching of includes Fixes tabulations. Signed-off-by: Elliott Davis -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 19:25:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2013 18:25:25 +0000 Subject: [Koha-bugs] [Bug 7387] Add Template::Toolkit plugin to allow caching of includes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7387 Elliott Davis changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |elliott at bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 20:06:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2013 19:06:19 +0000 Subject: [Koha-bugs] [Bug 9586] Remove $ENV{DEBUG} info from Member Template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9586 --- Comment #3 from Elliott Davis --- Created attachment 15894 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15894&action=edit Bug 9586 - Remove $ENV{DEBUG} info from Member Template Currently, if $ENV{DEBUG} is set (for example to 1), the debug level will be printed on the Add/Edit Patron pages (memberentrygen.tt) in the form of: "Debug is on (level 1)". While many if not most folks might not set $ENV{DEBUG} on a production system, there is no reason to have this information printing on the member template(s). No where else in Koha is there a template that prints $ENV{DEBUG} information, with the exception of calendar.inc, although that doesn't activate until at least debug level 2 or 5, so it might be worth holding on to. It is certainly more complicated than simply printing the debug level. I don't do development on the calendars, so I'm not going to address that one. Signed-off-by: Kyle M Hall Signed-off-by: Elliott Davis -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 20:06:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2013 19:06:29 +0000 Subject: [Koha-bugs] [Bug 9586] Remove $ENV{DEBUG} info from Member Template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9586 Elliott Davis changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |elliott at bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 20:06:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2013 19:06:43 +0000 Subject: [Koha-bugs] [Bug 9586] Remove $ENV{DEBUG} info from Member Template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9586 Elliott Davis changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15351|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 20:07:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2013 19:07:35 +0000 Subject: [Koha-bugs] [Bug 9748] New: noitemlinks not being enforced Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9748 Bug ID: 9748 Summary: noitemlinks not being enforced Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Self checkout Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com It appears that the conversion from HTML::Template to TT changed noitemlinks to ISSUE.noitemlinks, hence it is being ignored. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 20:07:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2013 19:07:42 +0000 Subject: [Koha-bugs] [Bug 9748] noitemlinks not being enforced In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9748 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 20:10:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2013 19:10:00 +0000 Subject: [Koha-bugs] [Bug 9748] noitemlinks not being enforced In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9748 --- Comment #1 from Kyle M Hall --- Created attachment 15895 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15895&action=edit Bug 9748 - noitemlinks not being enforced It appears that the conversion from HTML::Template to TT changed noitemlinks to ISSUE.noitemlinks, hence it is being ignored. This is a problem for SCO kiosks where all the navigation controls are hidden. Clicking the link means leaving the SCO module and not being able to get back. Test plan: 1) Run SCO module, check for item links 2) Apply patch 3) Run SCO module, note that the items no longer have links -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 20:10:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2013 19:10:09 +0000 Subject: [Koha-bugs] [Bug 9748] noitemlinks not being enforced In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9748 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 20:39:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2013 19:39:10 +0000 Subject: [Koha-bugs] [Bug 9749] New: Placeholders in koha-conf.xml generated by the Debian packages Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9749 Bug ID: 9749 Summary: Placeholders in koha-conf.xml generated by the Debian packages Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Packaging Assignee: koha-bugs at lists.koha-community.org Reporter: magnus at enger.priv.no CC: robin at catalyst.net.nz Bug 7028 updated the file debian/templates/koha-conf-site.xml.in to be more in line with the koha-conf.xml generated by other installation methods. However this seems to have introduced some placeholders that are not actually being replaced when a new instance is created with koha-create. Here is what I see with recently created instances, both with packages built off uptodate master and the official 3.8.x packages: $ sudo grep "__" /etc/koha/sites/bergting/koha-conf.xml tcp:@:__ZEBRA_SRU_BIBLIOS_PORT__ tcp:@:__MERGE_SERVER_PORT__ __ZEBRA_SRU_HOST__ __ZEBRA_SRU_BIBLIOS_PORT__ __ZEBRA_SRU_HOST__ __ZEBRA_SRU_AUTHORITIES_PORT__ __ZEBRA_SRU_HOST__ __ZEBRA_SRU_BIBLIOS_PORT__ koha-create does these substitutions: sed -e "s/__KOHASITE__/$name/g" \ -e "s/__OPACPORT__/$OPACPORT/g" \ -e "s/__INTRAPORT__/$INTRAPORT/g" \ -e "s/__OPACSERVER__/$opacdomain/g" \ -e "s/__INTRASERVER__/$intradomain/g" \ -e "s/__ZEBRA_PASS__/$zebrapwd/g" \ -e "s/__ZEBRA_MARC_FORMAT__/$ZEBRA_MARC_FORMAT/g" \ -e "s/__ZEBRA_LANGUAGE__/$ZEBRA_LANGUAGE/g" \ -e "s/__DB_NAME__/$mysqldb/g" \ -e "s/__DB_HOST__/$mysqlhost/g" \ -e "s/__DB_USER__/$mysqluser/g" \ -e "s/__DB_PASS__/$mysqlpwd/g" \ -e "s/__UNIXUSER__/$username/g" \ -e "s/__UNIXGROUP__/$username/g" \ "/etc/koha/$1" > "$2" So unless I am missing something we should perhaps remove some of the placeholders from koha-conf-site.xml.in again? The slightly weird thing is that all these placeholders do not seem to affect Koha in any way... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 20:41:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2013 19:41:40 +0000 Subject: [Koha-bugs] [Bug 9511] DOM indexing problem In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9511 --- Comment #12 from Melia Meggs --- We've got two libraries that were previously experiencing this problem on 3.8.5. We have upgraded them to 3.8.8, and both are now reporting that this problem looks to be resolved based on their testing so far. Thanks, Galen! Melia -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 20:54:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2013 19:54:06 +0000 Subject: [Koha-bugs] [Bug 8993] LDAP authentication improvements: multiple branch and transformation modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993 Elliott Davis changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |elliott at bywatersolutions.co | |m --- Comment #16 from Elliott Davis --- Sorry fir butting in here but I am confused. Is this intended to be pushed or just for a customer? Elliott -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 22:28:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2013 21:28:56 +0000 Subject: [Koha-bugs] [Bug 9695] Use alphabet system preference on page used to browse patrons for patron card batches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9695 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 22:28:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2013 21:28:58 +0000 Subject: [Koha-bugs] [Bug 9695] Use alphabet system preference on page used to browse patrons for patron card batches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9695 --- Comment #1 from Owen Leonard --- Created attachment 15896 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15896&action=edit Bug 9695 - Use alphabet system preference on page used to browse patrons for patron card batches When adding patrons to a batch for creating patron cards, the template shows alphabet links for browsing all patrons. This patch converts the hard-coded alphabet links to use the new alphabet system preference. To test, go to the patron card creator and create a new batch. Click "Add items" to pop up the window for browsing for patrons to add to the batch. You should see a working array of alphabet letters which link to patron search results. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 00:10:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2013 23:10:40 +0000 Subject: [Koha-bugs] [Bug 9250] Provide commands to allow handling of SIP servers in the packages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9250 --- Comment #7 from Robin Sheat --- Created attachment 15897 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15897&action=edit Bug 9250 - Followup to add koha-*-sip commands to koha-common.xml The original patch for Bug 9250 did not add the new commands to debian/docs/koha-common.xml, which functions as a sort of table of contents for the real commands. This patch adds them. Signed-off-by: Robin Sheat Simple documentation patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 00:11:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2013 23:11:19 +0000 Subject: [Koha-bugs] [Bug 9250] Provide commands to allow handling of SIP servers in the packages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9250 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15888|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 01:05:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2013 00:05:40 +0000 Subject: [Koha-bugs] [Bug 9687] Subject Searching not working for records with parentheses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9687 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Component|OPAC |Searching Assignee|oleonard at myacpl.org |gmcharlt at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 01:47:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2013 00:47:29 +0000 Subject: [Koha-bugs] [Bug 2499] Improvement on text wrapping algorithm needed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2499 --- Comment #5 from wajasu --- Created attachment 15898 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15898&action=edit 0001-Bug-2499 add support for text wrapping using proportional font metrics Currently when labels are printed and the text would render past the bounding label definition, the number of chars that can be written per row is based off of a fixed size for a character in that font. This change performs text wrapping based on each character's character width metric contained in the specified font. Once truncation is detected, it scans back and breaks on a space, and continues with the next words on subsequent lines. It will allow more characters or words from a 'title' to be written per line when possible. 0001-Bug-2499-add-support-for-text-wrapping-using-proportional font metrics is an improvement, and deals with horizontal aspects, cramming more characters per line when wrapping. The original bug comment wants us to calculate the number of lines one can write vertically so we dont arbitrarily cut off after 2, but use what we can without overlaying a barcode or such. To test this patch: -With a working BIBBAR based label, use itemcallnumber,author,title as well. -With a test biblio, create a batch, and export it as a PDF. -Edit that biblio, and make the title longer (add 4 3 letter words) so that it would wrap to another line, but seems to have space to fit the words it wrapped. -APPLY PATCH -Export batch as a PDF. -Confirm that more words fit per line. To fulfill the original bug description: - perform calculations to determin the number of lines we can write without overlaying the barcode or running past the bottom of the label. - maintain this rows_to_write counter and stop writing lines accordingly, I got this patch in because it should not break anyones existing labels. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 02:10:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2013 01:10:08 +0000 Subject: [Koha-bugs] [Bug 9750] New: bring routing lists in to notices & slips Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9750 Bug ID: 9750 Summary: bring routing lists in to notices & slips Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: nengard at gmail.com Routing Lists should be managed in Notices & Slips so that people can customize them with notes or news or whatever they want. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 06:19:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2013 05:19:50 +0000 Subject: [Koha-bugs] [Bug 2499] Improvement on text wrapping algorithm needed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2499 --- Comment #6 from wajasu --- Created attachment 15899 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15899&action=edit 0002-Bug-2499-remove-arbitrary-line-limit-for-label-text 0002-Bug-2499-remove-arbitrary-line-limit-for-label-text Removes the restriction for the amount of lines that may be printed in a label. Testing: (we are testing vertical layout calculation here ) We want to see of many lines from wrapping or from many fields will print if the font size lets them, without overlay in barcode or extending beyond the label edge. - print a working label exported to PDF that employs a barcode. - edit the layout to use larger font_sizes and repeat the export to ensure the text won't overlay the barcode - edit the layout/template to add author, author, author in the list to get even more rows. repeat the export to check if overlay. - edit the layout/template to use smaller fonts (10..5) to see the effects. - also test other label types. spine labels/splitting, just in case. - possibly test other export types (xml/csv), though i don't believe they apply. Note: Since I am not getting the character font height metric from the font, I relied on the existing line_spacer calculation, which is just the font_size. 10pt font = 10, 8pt font = 8. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 06:28:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2013 05:28:56 +0000 Subject: [Koha-bugs] [Bug 2499] Improvement on text wrapping algorithm needed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2499 wajasu changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15898|0 |1 is obsolete| | --- Comment #7 from wajasu --- Created attachment 15900 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15900&action=edit 0001-Bug-2499-add-support-for-text-wrapping-using-proportional -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 06:29:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2013 05:29:54 +0000 Subject: [Koha-bugs] [Bug 2499] Improvement on text wrapping algorithm needed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2499 wajasu changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15899|0 |1 is obsolete| | --- Comment #8 from wajasu --- Created attachment 15901 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15901&action=edit 0002-Bug-2499-remove-arbitrary-line-limit-for-label-text -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 06:30:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2013 05:30:08 +0000 Subject: [Koha-bugs] [Bug 2499] Improvement on text wrapping algorithm needed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2499 wajasu changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 06:42:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2013 05:42:05 +0000 Subject: [Koha-bugs] [Bug 7062] barcode titles not truncating In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7062 wajasu changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matted-34813 at mypacks.net --- Comment #8 from wajasu --- I added proportional font support in bug 2499. I added support to draw unlimited lines. I did code some support to truncate a line if the internal text_wrap_cols == 0. But I didn't have any external way for that to be configured, so if someone wants to enhance the list of fields, they might come up with some modifier like: itemcallnumber,author,[title] such that if the list has any bracketed, that could signal the code to truncate instead of wrap. Then later in the code we could set text_wrap_cols to 0, instead of calculating it from other settings. OR itemcallnumber,author,title[TI] grab modifiers in brackets: T = truncate I = italic but then we have: "090a" and friends, and 'I Am a text string' support. OR we add a column to a layout/template/profile table. Maybe this should be dependent on bug 2499. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 08:04:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2013 07:04:03 +0000 Subject: [Koha-bugs] [Bug 9572] Opac info tooltip from branches is not well positioned In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9572 --- Comment #2 from Katrin Fischer --- Hi Owen, I noticed 9420 has been pushed, maybe you can take another look at this? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 08:07:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2013 07:07:04 +0000 Subject: [Koha-bugs] [Bug 9656] fines.pl creating a log file should be optional In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9656 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 08:12:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2013 07:12:43 +0000 Subject: [Koha-bugs] [Bug 9570] view plain not working in ccsr In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9570 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 08:12:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2013 07:12:45 +0000 Subject: [Koha-bugs] [Bug 9570] view plain not working in ccsr In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9570 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15283|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 15902 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15902&action=edit [PASSED QA] Bug 9570 - view plain not working in ccsr The code in opac-showmarc.pl isn't smart enough to find the xsl files in the "default" (prog) theme if the ccsr theme is enabled, so the "view plain" option on opac-MARCdetail.pl fails ever time. This patch copies some path-handling code from XSLT.pm to improve xsl file path handling when dealing with a "sub-theme." To test, view the MARC view in the OPAC and click the "view plain" link. This should work correctly in prog and ccsr themes and with different languages enabled (keeping in mind the ccsr theme will fail in general for languages other than en). Signed-off-by: Nicole C. Engard Signed-off-by: Katrin Fischer Checked plain view works in both prog and ccsr themes now. All tests and QA script pass. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 08:13:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2013 07:13:11 +0000 Subject: [Koha-bugs] [Bug 9570] view plain not working in ccsr In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9570 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Patch complexity|--- |Small patch QA Contact| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 08:15:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2013 07:15:25 +0000 Subject: [Koha-bugs] [Bug 8620] Barcode searching not working correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8620 --- Comment #15 from Katrin Fischer --- I am inclined to pass this QA as we have another sign-off from Galen - RM? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 08:26:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2013 07:26:01 +0000 Subject: [Koha-bugs] [Bug 9711] OPACPopupAuthorsSearch ugly in CSSR In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9711 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de QA Contact| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer --- It seems I can't get this to work with my data - no checkboxes appear. Can I get some more information about the new pref and about the conditions for the checkboxes to appear? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 08:41:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2013 07:41:25 +0000 Subject: [Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 --- Comment #32 from Katrin Fischer --- Working on this again... we are getting close! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 09:38:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2013 08:38:55 +0000 Subject: [Koha-bugs] [Bug 9711] OPACPopupAuthorsSearch ugly in CSSR In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9711 --- Comment #5 from Jonathan Druart --- (In reply to comment #4) > It seems I can't get this to work with my data - no checkboxes appear. > Can I get some more information about the new pref and about the conditions > for the checkboxes to appear? Katrin, you must have Additional authors and/or Subject(s) for your record. Checkboxes appear when clicking on one of them. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 09:41:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2013 08:41:39 +0000 Subject: [Koha-bugs] [Bug 9711] OPACPopupAuthorsSearch ugly in CSSR In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9711 --- Comment #6 from Katrin Fischer --- Hi Jonathan, I had checked records with more than one other shown in the by line - is there more to it? Which fields? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 10:47:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2013 09:47:17 +0000 Subject: [Koha-bugs] [Bug 9256] Search is broken for 3.10 package-installs when marcflavour != marc21 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9256 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |magnus at enger.priv.no |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 11:20:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2013 10:20:55 +0000 Subject: [Koha-bugs] [Bug 9751] New: Patron flags red in moremember.pl like in circulation.pl Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9751 Bug ID: 9751 Summary: Patron flags red in moremember.pl like in circulation.pl Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: fridolyn.somers at biblibre.com CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com In a patron detail page (moremember.pl), when looking at a patron with one or more flags, for example : . Patron is restricted until 30/03/2013 (debarr comment) . Patron's address is in doubt. . Patron's card has been reported lost. Click on Check out tab and look at circulation page : flags are red. It is more attractive for librarian. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 11:26:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2013 10:26:20 +0000 Subject: [Koha-bugs] [Bug 9751] Patron flags red in moremember.pl like in circulation.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9751 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |fridolyn.somers at biblibre.co |ity.org |m --- Comment #1 from Fridolyn SOMERS --- Created attachment 15903 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15903&action=edit Proposed patch See commit comment -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 11:28:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2013 10:28:40 +0000 Subject: [Koha-bugs] [Bug 9752] New: Set marcflavor = normarc when NORMARC is chosen in the web installer Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9752 Bug ID: 9752 Summary: Set marcflavor = normarc when NORMARC is chosen in the web installer Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: magnus at enger.priv.no Reporter: magnus at enger.priv.no CC: gmcharlt at gmail.com I thought this was already being done, but alas. If you do a web install in Norwegian and choose NORMARC as the MARC dialect, the marcflavor syspref gets set to MARC21, not NORMARC. I hope the solution can be as simple as including something like this in the SQL file for the default NORMARC framework: UPDATE systempreferences SET value = 'normarc' WHERE variable = 'marcflavor'; But I will have to look at the order in which things are loaded by the webinstaller first. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 11:30:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2013 10:30:08 +0000 Subject: [Koha-bugs] [Bug 9751] Patron flags red in moremember.pl like in circulation.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9751 --- Comment #2 from Fridolyn SOMERS --- Created attachment 15904 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15904&action=edit screen-shot with patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 11:41:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2013 10:41:21 +0000 Subject: [Koha-bugs] [Bug 8620] Barcode searching not working correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8620 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15869|0 |1 is obsolete| | --- Comment #16 from Martin Renvoize --- Created attachment 15905 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15905&action=edit Bug 8620: Any index in DOM mode sensitive to -x flag of rebuild_zebra.pl Works as expected; Will be glad to see this get pushed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 12:07:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2013 11:07:44 +0000 Subject: [Koha-bugs] [Bug 9711] OPACPopupAuthorsSearch ugly in CSSR In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9711 --- Comment #7 from Jonathan Druart --- It is not the "by" line but the "Additional authors:" and "Subject(s):" lines. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 12:31:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2013 11:31:34 +0000 Subject: [Koha-bugs] [Bug 8620] Barcode searching not working correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8620 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact| |katrin.fischer at bsz-bw.de --- Comment #17 from Katrin Fischer --- Switching this to Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 12:31:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2013 11:31:49 +0000 Subject: [Koha-bugs] [Bug 8620] Barcode searching not working correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8620 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |critical -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 13:05:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2013 12:05:27 +0000 Subject: [Koha-bugs] [Bug 2523] holds queue report needs additional fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2523 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #1 from Nicole C. Engard --- This is still desired. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 13:09:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2013 12:09:11 +0000 Subject: [Koha-bugs] [Bug 9753] New: XSLT on holds queue Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9753 Bug ID: 9753 Summary: XSLT on holds queue Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: nengard at gmail.com It would be nice if XSLT were used for the Holds queue - or if there was some way to customize the bib display. Some libraries want series info to show on here but it's not going to be wanted in all libraries so XSLT was the first thing I thought of. Maybe keyword to marc mapping would work as well ... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 13:22:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2013 12:22:14 +0000 Subject: [Koha-bugs] [Bug 9377] itemtype in duplicate biblio search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9377 --- Comment #8 from M. de Rooy --- (In reply to comment #7) > I agree if it is accepted by community. > A false duplicate on title and author must be very unusual (maybe book and > movie), and better show duplicate message too often than not enough. +1 from me Please send an adjusted patch or followup. I will be happy to sign off if needed.. Please change status accordingly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 13:55:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2013 12:55:52 +0000 Subject: [Koha-bugs] [Bug 9754] New: koha-remove does not remove the stuff in /var/lib/koha/ Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9754 Bug ID: 9754 Summary: koha-remove does not remove the stuff in /var/lib/koha/ Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Packaging Assignee: koha-bugs at lists.koha-community.org Reporter: magnus at enger.priv.no CC: robin at catalyst.net.nz While testing something else, I have created and removed quite a number of instances on the same server. By chance I discovered that removing instances has not removed the instance-specific direcories below /var/lib/koha/, and the permissions on these directories are completely off: $ ls -l /var/lib/koha/ total 44 drwxr-xr-x 4 test-koha test-koha 4096 2012-11-21 15:59 buskfylk drwxr-xr-x 4 norge-koha norge-koha 4096 2012-12-09 21:14 esme drwxr-xr-x 4 test1-koha test1-koha 4096 2012-11-09 14:15 marc21 drwxr-xr-x 4 1005 1005 4096 2012-12-28 13:00 munka21 drwxr-xr-x 4 norge-koha norge-koha 4096 2013-03-05 17:54 mytest drwxr-xr-x 4 usa-koha usa-koha 4096 2013-03-06 11:12 norge drwxr-xr-x 4 usa-koha usa-koha 4096 2012-12-10 18:47 normarc drwxr-xr-x 4 norge-koha norge-koha 4096 2011-12-03 18:13 sksk drwxr-xr-x 4 test-koha test-koha 4096 2012-12-10 08:36 test drwxr-xr-x 4 test1-koha test1-koha 4096 2013-03-05 17:54 test1 drwxr-xr-x 4 usa-koha usa-koha 4096 2013-03-06 13:17 usa The prmissions for test and test1 are OK, the others are not. I created an instance called "norge", then removed it and created it again. As a result of the situation above I now get a permission error when I try to re-index Zebra for this instance, but I still get hits from the previous incarnation of the instance, presumably because the indexes etc are still there. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 14:19:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2013 13:19:48 +0000 Subject: [Koha-bugs] [Bug 9256] Search is broken for 3.10 package-installs when marcflavour != marc21 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9256 --- Comment #11 from Magnus Enger --- Created attachment 15906 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15906&action=edit Bug 9256 - Fix search for the packages See the bug for a description of the problem. This patch tries to restore searching for marcflavour != MARC21 as well as allowing instances with different marcflavors to co-exist on the same server. To test: - Do a package install with e.g. the official squeeze-dev packages and create at least two instances, with different marcflavours, e.g.: sudo koha-create --create-db --marcflavor marc21 test1 sudo koha-create --create-db --marcflavor normarc test2 - Run through the web installers for both instances and add a couple of records to each. Wait for the records to be indexed or run indexing manually with sudo koha-rebuild-zebra -f test1 sudo koha-rebuild-zebra -f test2 - Try searching for the records you added. It should work in test1 but not in test2. - Apply the patch and build packages with the build-git-snapshot script - Install the new koha-common package - Create two instances (because of Bug 9754 it is probably best to give the instances different names than the ones you created above, or to do this on a fresh VM or similar) and add records, as described above. Searching should now work equally well for both instances. Please note: Because of Bug 9752 you will have to set marcflavour = NORMARC by hand before you do the searching, if you choose NORMARC as the marc flavour on one of the instances you create. Please note too: I am not confident that this is the perfect solution, so merciless and thorough testing is necessary! ;-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 14:20:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2013 13:20:28 +0000 Subject: [Koha-bugs] [Bug 9256] Search is broken for 3.10 package-installs when marcflavour != marc21 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9256 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 14:25:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2013 13:25:31 +0000 Subject: [Koha-bugs] [Bug 9256] Search is broken for 3.10 package-installs when marcflavour != marc21 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9256 --- Comment #12 from Magnus Enger --- Oh, testing that this does not bring back the problems described by Bug 3087 is probably a good idea too... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 14:32:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2013 13:32:33 +0000 Subject: [Koha-bugs] [Bug 9697] Replace YUI buttons on the patron cards batch edit page with Bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9697 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 14:37:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2013 13:37:01 +0000 Subject: [Koha-bugs] [Bug 9296] overduerules table needs restructuring to allow future extension In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9296 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15779|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall --- Created attachment 15907 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15907&action=edit Bug 9296 - restructure overduerules table to allow future extension The overduerules table is rather hardcoded to three notices. This patch restructures it so we could have more in future, but should not change anything noticeable yet. To test: 1) edit Tools: Overdue notices 2) cause some notices to be sent 3) notice how everything behaves the same as before Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 14:37:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2013 13:37:11 +0000 Subject: [Koha-bugs] [Bug 9296] overduerules table needs restructuring to allow future extension In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9296 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 14:40:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2013 13:40:32 +0000 Subject: [Koha-bugs] [Bug 9377] itemtype in duplicate biblio search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9377 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #9 from Katrin Fischer --- +1 from me too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 15:01:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2013 14:01:12 +0000 Subject: [Koha-bugs] [Bug 9750] bring routing lists in to notices & slips In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9750 --- Comment #1 from Nicole C. Engard --- and by 'whatever they want' I include things like phone number, email, address etc. Nicole -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 15:02:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2013 14:02:22 +0000 Subject: [Koha-bugs] [Bug 2499] Improvement on text wrapping algorithm needed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2499 --- Comment #9 from wajasu --- Created attachment 15908 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15908&action=edit example barcode with extra info the title smaller fonts get you more lines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 15:25:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2013 14:25:26 +0000 Subject: [Koha-bugs] [Bug 9752] Set marcflavor = normarc when NORMARC is chosen in the web installer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9752 --- Comment #1 from Magnus Enger --- Created attachment 15909 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15909&action=edit Bug 9752 - Set marcflavour = NORMARC when NORMARC is chosen Currently, if you install the Norwegian translations and run through the web installer in Norwegian, choosing NORMARC as you marcflavour, the marcflavour syspref is set to MARC21. To test: - Apply the patch - Install nb-NO - Run through the web installer, choosing nb-NO as the language - Choose NORMARC as the MARC dialect - When the web installer is done, check the value of the marcflavour syspref. It should be NORMARC, not MARC21. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 15:26:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2013 14:26:29 +0000 Subject: [Koha-bugs] [Bug 9752] Set marcflavor = normarc when NORMARC is chosen in the web installer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9752 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #2 from Magnus Enger --- So the solution was not in the SQL file as I initially thought, but in Installer.pm. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 15:36:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2013 14:36:28 +0000 Subject: [Koha-bugs] [Bug 9743] Mandatory opac hold notes under specified conditions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9743 --- Comment #3 from M. de Rooy --- Created attachment 15910 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15910&action=edit Bug 9743: Unit test for mandatory hold notes Test plan: Export PERL5LIB and KOHA_CONF to your test database. Run t/db_dependent/Reserves.t. You should have 7 tests running ok. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 16:08:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2013 15:08:29 +0000 Subject: [Koha-bugs] [Bug 9738] Confirming a hold crashes on datetime duration error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9738 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WONTFIX --- Comment #1 from M. de Rooy --- Found it. Result of testing work that deletes the ReservesMaxPickupDelay pref. Closing this report. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 16:08:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2013 15:08:38 +0000 Subject: [Koha-bugs] [Bug 9738] Confirming a hold crashes on datetime duration error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9738 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 16:15:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2013 15:15:09 +0000 Subject: [Koha-bugs] [Bug 9377] itemtype in duplicate biblio search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9377 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 16:24:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2013 15:24:45 +0000 Subject: [Koha-bugs] [Bug 9755] New: Record merge code needs to be refactored Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9755 Bug ID: 9755 Summary: Record merge code needs to be refactored Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jcamins at cpbibliography.com Reporter: jcamins at cpbibliography.com Blocks: 5202 In order to make it possible to merge authority records, the record merge functionality in Koha needs to be refactored so that there is less duplicated code and the code can be used for both bibs and authorities. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 16:24:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2013 15:24:45 +0000 Subject: [Koha-bugs] [Bug 5202] Merge authority records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5202 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |9755 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 17:16:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2013 16:16:14 +0000 Subject: [Koha-bugs] [Bug 9267] Ubuntu 12.04 install docs broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9267 Elliott Davis changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |elliott at bywatersolutions.co | |m --- Comment #4 from Elliott Davis --- This patch looks like it adheres to the coding standards. My only concern has been documented in splinter. I am still marking it passed QA since the change doesn't appear to have changed anything. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 17:19:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2013 16:19:29 +0000 Subject: [Koha-bugs] [Bug 9756] New: Patron self registration missing the system preference PatronSelfRegistrationAdditionalInstructions Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9756 Bug ID: 9756 Summary: Patron self registration missing the system preference PatronSelfRegistrationAdditionalInstructions Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: kyle at bywatersolutions.com The patron self registration system references a system preference PatronSelfRegistrationAdditionalInstructions as a free text field to add additional instructions for newly self registered patrons, but the system preference in neither created in the database, nor exposed via the staff interface. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 17:19:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2013 16:19:35 +0000 Subject: [Koha-bugs] [Bug 9756] Patron self registration missing the system preference PatronSelfRegistrationAdditionalInstructions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9756 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 17:34:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2013 16:34:10 +0000 Subject: [Koha-bugs] [Bug 9756] Patron self registration missing the system preference PatronSelfRegistrationAdditionalInstructions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9756 --- Comment #1 from Kyle M Hall --- Created attachment 15911 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15911&action=edit Bug 9756 - Patron self registration missing the system preference PatronSelfRegistrationAdditionalInstructions The patron self registration system references a system preference PatronSelfRegistrationAdditionalInstructions as a free text field to add additional instructions for newly self registered patrons, but the system preference in neither created in the database, nor exposed via the staff interface. Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Add some text to the new system preference PatronSelfRegistrationAdditionalInstructions 4) Enable opac self registrations and complete a self registration 5) Note the additional instructions you entered appear on the "registration complete" page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 17:34:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2013 16:34:29 +0000 Subject: [Koha-bugs] [Bug 9756] Patron self registration missing the system preference PatronSelfRegistrationAdditionalInstructions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9756 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 17:34:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2013 16:34:38 +0000 Subject: [Koha-bugs] [Bug 9756] Patron self registration missing the system preference PatronSelfRegistrationAdditionalInstructions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9756 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 17:47:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2013 16:47:59 +0000 Subject: [Koha-bugs] [Bug 9652] Call number column on list view displays commas when no callnumbers exist In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9652 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |9757 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 17:47:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2013 16:47:59 +0000 Subject: [Koha-bugs] [Bug 9757] New: Make staff client list contents view more like search results Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9757 Bug ID: 9757 Summary: Make staff client list contents view more like search results Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Lists Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org CC: m.de.rooy at rijksmuseum.nl Blocks: 9652 Created attachment 15912 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15912&action=edit Screenshot of revised interface Just as we made the view of a list's contents in the OPAC look similar to the OPAC search results page, the staff client lists interface should match the staff client's search results page. Proposed changes include: - XSLT-based display of record information - Search results-like toolbar with controls for placing hold, adding to cart, etc. - Additional item information (and a fix for Bug 9652) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 17:52:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2013 16:52:52 +0000 Subject: [Koha-bugs] [Bug 9755] Record merge code needs to be refactored In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9755 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 17:52:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2013 16:52:53 +0000 Subject: [Koha-bugs] [Bug 9755] Record merge code needs to be refactored In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9755 --- Comment #1 from Jared Camins-Esakov --- Created attachment 15913 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15913&action=edit Bug 9755: Refactor record merge functionality This patch refactors the merge record interface and code a little bit in preparation for making it possible to merge authority records. To test: 1) Apply patch. 2) Try merging two records: a) Create a list. b) Add two records you would like to (or be willing to) merge to said list. c) View said list. d) Check the checkboxes next to the two records you added. e) Click "Merge selected records." f) Choose a merge reference. g) Choose fields from each record that you want to keep. h) Click "Merge." 3) Confirm that your merged record has the fields and subfields you wanted. 4) Run the unit tests for the two files that were changed: prove t/Koha_Record.t t/db_dependent/Koha_Authority.t 5) Sign off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 18:06:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2013 17:06:43 +0000 Subject: [Koha-bugs] [Bug 7129] actual cost showing too many zeros In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7129 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby at univ-rennes2.f | |r --- Comment #24 from mathieu saby --- Hello We have just discovered the problem, and I agree with Christophe Croullebois, it must be solved. I will test transitional patch tomorrow. M. Saby Rennes 2 university -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 19:01:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2013 18:01:52 +0000 Subject: [Koha-bugs] [Bug 9434] Static variables used for caches are not Plack-friendly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9434 Elliott Davis changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |elliott at bywatersolutions.co | |m --- Comment #4 from Elliott Davis --- I am getting a failed test with the unit test provided. elliott at ByWater-Test:~/kohaclone$ prove ./t/Cache.t ./t/Cache.t .. 1/29 Use of uninitialized value $ip in hash element at /usr/share/perl5/Cache/Memcached.pm line 253. Use of uninitialized value in subroutine entry at /usr/share/perl5/Cache/Memcached.pm line 288. # Failed test 'use C4::Context;' # at ./t/Cache.t line 15. # Tried to use 'C4::Context'. # Error: Bad arg length for Socket::pack_sockaddr_in, length is 0, should be 4 at /usr/lib/perl/5.10/Socket.pm line 214. # BEGIN failed--compilation aborted at /home/elliott/kohaclone/C4/Context.pm line 99. # Compilation failed in require at (eval 14) line 2. # BEGIN failed--compilation aborted at (eval 14) line 2. ./t/Cache.t .. 5/29 # Failed test 'fetching valid item from cache' # at ./t/Cache.t line 39. # got: undef # expected: 'I AM MORE DATA' # Failed test 'fetching valid item from cache (after clearing another item)' # at ./t/Cache.t line 49. # got: undef # expected: 'I AM MORE DATA22' # Failed test 'Data retrieved from cache' # at ./t/Cache.t line 76. # got: '2' # expected: '1' ./t/Cache.t .. 14/29 # Failed test 'Constructor called again when timeout reached' # at ./t/Cache.t line 78. # got: '3' # expected: '2' # Failed test 'Stored new value to cache' # at ./t/Cache.t line 80. # got: '4' # expected: '5' # Failed test 'Constructor not called after storing value' # at ./t/Cache.t line 81. # got: '4' # expected: '2' # Failed test 'Setting hash member worked' # at ./t/Cache.t line 104. # got: undef # expected: 'surprise' ./t/Cache.t .. 25/29 # Looks like you failed 8 tests of 29. ./t/Cache.t .. Dubious, test returned 8 (wstat 2048, 0x800) Failed 8/29 subtests Test Summary Report ------------------- ./t/Cache.t (Wstat: 2048 Tests: 29 Failed: 8) Failed tests: 3, 6, 8, 13-16, 21 Non-zero exit status: 8 Files=1, Tests=29, 8 wallclock secs ( 0.04 usr 0.01 sys + 0.14 cusr 0.03 csys = 0.22 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 19:45:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2013 18:45:06 +0000 Subject: [Koha-bugs] [Bug 8956] Split serials enumeration data into separate fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13041|0 |1 is obsolete| | Attachment #13042|0 |1 is obsolete| | Attachment #13043|0 |1 is obsolete| | Attachment #13044|0 |1 is obsolete| | Attachment #13045|0 |1 is obsolete| | Attachment #13046|0 |1 is obsolete| | Attachment #13047|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall --- Created attachment 15914 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15914&action=edit Bug 8956 - Split serials enumeration data into separate fields - Part 1 - Add fields to DB -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 19:45:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2013 18:45:16 +0000 Subject: [Koha-bugs] [Bug 8956] Split serials enumeration data into separate fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 --- Comment #11 from Kyle M Hall --- Created attachment 15915 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15915&action=edit Bug 8956 - Split serials enumeration data into separate fields - Part 2 - Store x, y and z in DB when generating new serials -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 19:45:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2013 18:45:23 +0000 Subject: [Koha-bugs] [Bug 8956] Split serials enumeration data into separate fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 --- Comment #12 from Kyle M Hall --- Created attachment 15916 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15916&action=edit Bug 8956 - Split serials enumeration data into separate fields - Part 3 - Add date pickers to serials-edit.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 19:45:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2013 18:45:28 +0000 Subject: [Koha-bugs] [Bug 8956] Split serials enumeration data into separate fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 --- Comment #13 from Kyle M Hall --- Created attachment 15917 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15917&action=edit Bug 8956 - Split serials enumeration data into separate fields - Part 4 - Add saving/editing of published end date for bound volumes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 19:45:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2013 18:45:34 +0000 Subject: [Koha-bugs] [Bug 8956] Split serials enumeration data into separate fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 --- Comment #14 from Kyle M Hall --- Created attachment 15918 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15918&action=edit Bug 8956 - Split serials enumeration data into separate fields - Part 5 - Add label fields to subscription editor. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 19:45:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2013 18:45:40 +0000 Subject: [Koha-bugs] [Bug 8956] Split serials enumeration data into separate fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 --- Comment #15 from Kyle M Hall --- Created attachment 15919 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15919&action=edit Bug 8956 - Split serials enumeration data into separate fields - Part 6 - Perltidy serials/subscription-add.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 19:45:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2013 18:45:52 +0000 Subject: [Koha-bugs] [Bug 8956] Split serials enumeration data into separate fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 --- Comment #16 from Kyle M Hall --- Created attachment 15920 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15920&action=edit Bug 8956 - Split serials enumeration data into separate fields - Part 7 - Add backend processing of field labels. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 20:02:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2013 19:02:25 +0000 Subject: [Koha-bugs] [Bug 9757] Make staff client list contents view more like search results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9757 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 20:02:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2013 19:02:27 +0000 Subject: [Koha-bugs] [Bug 9757] Make staff client list contents view more like search results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9757 --- Comment #1 from Owen Leonard --- Created attachment 15921 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15921&action=edit Bug 9757 - Make staff client list contents view more like search results This patch revises the staff client list contents view to better match staff client search results, showing more information and offering more ways to interact with the contents than before. - List contents output has been modified so that the staff client can use XSLT-formatted data just as the OPAC can. As in the OPAC it depends on XSLTResultsDisplay being enabled. - A "toolbar" has been added which is similar to that in search results, offering the option to add items to a Cart, add them to a different list, place multiple holds, remove items from the list, or merge records. - This toolbar has been made to float on scroll like the one on the MARC edit page. - Library and shelving location have been added to the display of call numbers. Call numbers are linked to a search as they are in search results. - Edit links are included just as they are in search results. - Automatic focus on the add by barcode form has been removed so that the page doesn't jump to the bottom unnecessarily. - basket.js's "addMultiple" function has been modified so that it receives an array of checkboxes rather than looking for checkboxes in a specific form. This helps abstract its functionality for use on both search results and lists. results.tt is modified accordingly. - The page layout has been widened to make room for the increased amount of information on the page. - A new "merge" icon has been added to the default Bootstrap sprite. To test: - View both public and private lists in the staff client. - View lists with and without contents. - Test the functionality of options in the toolbar: Add to cart, add to lists, place multiple holds, remove items, merge items. - Test with users with and without cataloging privileges to confirm that catalog-related controls are correctly shown or hidden. - Test with XSLTResultsDisplay set both to "default" and empty. - Since the staff client and OPAC use some of the same code, test that lists in the OPAC have not broken. - Since JavaScript was modified which affects both lists and search results, confirm that adding items to the Cart and Lists from search results hasn't been broken by this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 21:13:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2013 20:13:03 +0000 Subject: [Koha-bugs] [Bug 5079] Make display of shelving location and call number in XSLT results controlled by sysprefs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5079 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #48 from Jared Camins-Esakov --- Per comment 46, I consider this to have passed QA, as the only objection to the code is one that I do not recognize as grounds for refusal from inclusion in 3.12. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 21:32:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2013 20:32:14 +0000 Subject: [Koha-bugs] [Bug 2720] Overdues which debar automatically should undebar automatically when returned In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2720 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #15 from Owen Leonard --- Some test results: - There is a typo in updatedatabase, a reversed end parenthesis. - There is at least once instance of "debar" being used instead of "restrict" - I think the "X" icon isn't appropriate here. It would be simpler and more clear to use text ("Remove"). - The table of restrictions doesn't look correct if there are no restrictions--probably because there is nothing in ? Anyway I think it would be more consistent to separate the entry from from the table. Wrapping
around is invalid. - onclick="return confirm(_('Remove debarment?'))" at line 24 of borrower_debarments.inc is not translatable. The action should be moved to a function. - borrower_debarments.inc has a couple of unescaped ampersands in line 24. I don't think the "Restrictions" tab should be present on circulation.pl at all times. Being able to add a restriction to an account is certainly not something which happens so frequently that it needs to be only one click away. It's useful to be able to see information about all restrictions, but the full information could just as easily be displayed in the main block of "Cannot check out!" messages at the top. There's no reason to conserve space there if the patron is restricted anyway. If we mimicked the current method for displaying restrictions we could simply make it possible to display more than one line of restrictions, each with the same "lift restriction" button or link. If we did this then we could move the form for adding a manual restriction either back into the patron edit form (where people still expect to find it) or onto its own page (not as good an option IMO). One idea for an improvement: Perhaps the overdue notices job could set a restricted comment with the datetime of the job? "Restriction added by overdues process 2013-03-05 00:20:00" -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 21:33:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2013 20:33:10 +0000 Subject: [Koha-bugs] [Bug 9620] IncludeSeeFromInSearches ON and data in $9 subfields can break indexing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9620 Elliott Davis changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |elliott at bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 21:55:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2013 20:55:14 +0000 Subject: [Koha-bugs] [Bug 9755] Record merge code needs to be refactored In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9755 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |paul.poulain at biblibre.com --- Comment #2 from Paul Poulain --- Patch tested with a sandbox, by Mathieu Saby -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 21:55:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2013 20:55:27 +0000 Subject: [Koha-bugs] [Bug 9755] Record merge code needs to be refactored In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9755 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15913|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 21:55:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2013 20:55:32 +0000 Subject: [Koha-bugs] [Bug 9755] Record merge code needs to be refactored In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9755 --- Comment #3 from Paul Poulain --- Created attachment 15922 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15922&action=edit Bug 9755: Refactor record merge functionality This patch refactors the merge record interface and code a little bit in preparation for making it possible to merge authority records. To test: 1) Apply patch. 2) Try merging two records: a) Create a list. b) Add two records you would like to (or be willing to) merge to said list. c) View said list. d) Check the checkboxes next to the two records you added. e) Click "Merge selected records." f) Choose a merge reference. g) Choose fields from each record that you want to keep. h) Click "Merge." 3) Confirm that your merged record has the fields and subfields you wanted. 4) Run the unit tests for the two files that were changed: prove t/Koha_Record.t t/db_dependent/Koha_Authority.t 5) Sign off. Signed-off-by: Mathieu Saby -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 21:58:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2013 20:58:39 +0000 Subject: [Koha-bugs] [Bug 9755] Record merge code needs to be refactored In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9755 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby at univ-rennes2.f | |r --- Comment #4 from mathieu saby --- I tested on sandbox 3. I merged records biblionumber 94 and 97, keeping the 94. I tried to copy some fields of the 97, and to suppress some fields of the 94. I tried to copy some non repeatable fields. It works as before. M. Saby -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 22:10:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2013 21:10:14 +0000 Subject: [Koha-bugs] [Bug 9572] Opac info tooltip from branches is not well positioned In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9572 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 22:10:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2013 21:10:18 +0000 Subject: [Koha-bugs] [Bug 9572] Opac info tooltip from branches is not well positioned In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9572 --- Comment #3 from Owen Leonard --- Created attachment 15923 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15923&action=edit Bug 9572 - Opac info tooltip from branches is not well positioned This patch removes the jQuery plugin previously used to display the library information tooltip on opac-detail.pl and implements the functionality using jQueryUI's tooltip widget. jQueryUI has been upgraded to 1.9.2 in the process, which required some ammendments to jQueryUI-related CSS. To test, make sure at least one of your libraries has "OPAC info" stored as part of its configuration. View a record in the OPAC which is owned by that library. Hover over the library's name in the holdings table and you should see a properly-positioned tooltip showing the "OPAC info." Also test other jQueryUI-related functionality to confirm that the upgrade didn't break anything: Tabs and datepickers should still work correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 22:15:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2013 21:15:48 +0000 Subject: [Koha-bugs] [Bug 9620] IncludeSeeFromInSearches ON and data in $9 subfields can break indexing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9620 Elliott Davis changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15422|0 |1 is obsolete| | --- Comment #5 from Elliott Davis --- Created attachment 15924 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15924&action=edit Bug 9620: IncludeSeeFromInSearches and date in $9 subfields can break indexing In Germany 020$9 is used to store the ISBN with hyphens. In rare cases this can break indexing in combination with IncludeSeeFromInSearches. To reproduce: 1) Change your frameworks: * Make sure 084 $a is visible * Create a 084 $9 that you link to PERSO_NAME authorities. 2) Create a record or edit an existing one: * Use the plugin on 084 to link the record to an authority. * Make sure 400 is filled in your authority record. Preparations all done, now test indexing: 3) Make sure IncludeSeeFromInSearches is OFF * Reindexing should work without any problems. 4) Activate IncludeSeeFromInSearches * Reindexing should throw an error and stop: 201.Subfields are only for data fields (generally, just tags >= 010 at /home/koha/Koha/Filter/MARC/EmbedSee FromHEadings.pm line 94 5) Apply patch and reindex. * No error should occur. * Test 4xx fields from other tags were properly indexed. What causes the problem is the fact, that Koha tries to store the date from the 400 in the bibliographic record for indexing. For this it calculates a tag in the bibliographic record from the tag it found the authority link in and the 4xx tags used in the authority record. If you have an authority linked to a 0xx field and the matching authority has a 4xx where xx < 10, the calculated tag will be a control field. The attempt to add subfields to this control field, is causing the error and breaks the indexing process. Signed-off-by: Bernardo Gonzalez Kriegel Comment: Work as described, and is a long description :) Test: 1) Enabled 084 (all subfields visible), added 084_9 (missing from default framework) linked to PERSO_NAME 2) Edited authority record and added some data to 400 3) Edited bib record, linked 084 to previous auth record 4) With IncludeSeeFromInSearches OFF, re-index without problem 5) With IncludeSeeFromInSearches ON, re-index problems!!! ==================== exporting biblio ==================== 1...Subfields are only for data fields (generally, just tags >= 010) at... Abort 6) Applied patch 7) With IncludeSeeFromInSearches ON, re-index without problem ... ==================== 5001.................................................................................................... Records exported: 5060 ==================== ... ==================== 2001.................................................................................................... Records exported: 2024 ==================== CLEANING ==================== Good! *) That's "works as described", don't know if other tests are needed. No errors from koha-qa Signed-off-by: Elliott Davis -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 23:32:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2013 22:32:32 +0000 Subject: [Koha-bugs] [Bug 9754] koha-remove does not remove the stuff in /var/lib/koha/ In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9754 --- Comment #1 from Robin Sheat --- Hmm. I'm not sure that it should remove user-generated data (perhaps a --purge option would be good for this), and by the same token it probably shouldn't overwrite existing data. However the permissions being wrong is obviously an issue. I think perhaps the correct approach is to ensure the permissions are correct and set a flag to do a full zebra reindex. I'm open to other ideas though, I'm not totally sure what the best approach is. Another option is perhaps to have an existing directory renamed out of the way if koha-create would cause a name conflict. Thoughts on this? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 23:51:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2013 22:51:21 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #13 from mathieu saby --- I tested again on my VM and sandbox 3 => Failed Budget, sort1 and sort2 are not imported from records. Here is the detail : connected to Koha with a bib user (not the admin user) no acq framework default framework includes 947$c, 969$h, 922$a, 010$d, 969$d, 923$a, 924$a currency : EUR vendor with - gst = 0 - discount = 5 - list price include tax budget : "test", with fund code "budgetok" (fund name "budgetok") No importing matching rule parameters for MarcFieldsToOrder : price: 947$c quantity: 969$h budget_code: 922$a rrp: 010$d discount: 969$d sort1: 923$a sort2: 924$a ------ Batch of 7 records 200 1 $a Eudora Welty $b Texte imprim? $f edited and with an introduction by Harold Bloom,... 010 $d 11 EUR 922 $a budgetok 947 $c 10.00 969 $a 3 $h 3 200 1 $a Le th??tre du Marais $h 1 $i La p?riode de gloire et de fortune, 1634(1629)-1648 $b Texte imprim? $f S. Wilma Deierkauf-Holsboer 010 $d 10,50 EUR 922 $a budgetbidon 923 $a stat1 924 $a stat2 947 $c 10.50 969 $a 2 $h 2 200 1 $a Paul Val?ry et Pascal $b Texte imprim? $f Antonio G. Rodriguez 010 $d 23,70 EUR 923 $a stat1 947 $c 23.70 969 $a 1 $h 1 200 1 $a Arthur Miller's "Death of a salesman" $f ed. and with an introd. by Harold Bloom 010 $d 100.00 EUR 922 $a budgetok 923 $a stat1 924 $a stat2 947 $c 90.00 969 $a 3 $d 50 $h 3 200 1 $a Didactique de l'orthographe fran?aise $b Texte imprim? $e m?thode, exp?riences et exercices p?dagogiques $f Michel Gey 010 $d 12.50 EUR 922 $a budgetok 923 $a tri1 969 $a 1 $h 1 $d 10.50 200 1 $a Histoire de la sculpture $b Texte imprim? $f par Luc Benoist 922 $a budgetok 923 $a tri1 947 $c 15.50 969 $a 1 $h 1 $d 10 200 1 $a Premiers exercices de grammaire $f Sabine Dupr? la Tour et Genevi?ve-Dominique de Salins 010 $d $ 10.00 922 $a budgetok 923 $a tri1 947 $c 10.50 969 $a 2 $d 20.50 $h 2 M. Saby -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 03:56:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 02:56:28 +0000 Subject: [Koha-bugs] [Bug 9534] No way to get back to bib detail from edit record screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9534 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 03:56:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 02:56:31 +0000 Subject: [Koha-bugs] [Bug 9534] No way to get back to bib detail from edit record screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9534 --- Comment #2 from Liz Rea --- Created attachment 15925 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15925&action=edit Bug 9534 - No way to get back to bib detail from edit record To test: * Set your BiblioDefaultDisplay to one of the options (go through all three of them) * view a record * click "Edit Record" * you should see a "Cancel" button on the toolbar - click it * you will be redirected back to the detail page, in the default display method you have picked * Click More -> Cataloging * Click the Cancel button * you should be redirected back to the cataloguing home page This patch only applies on top of the patch for bug 9672 as it uses the bootstrap buttons. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 10:15:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 09:15:21 +0000 Subject: [Koha-bugs] [Bug 9685] Allow sort baskets by number In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9685 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |paul.poulain at biblibre.com --- Comment #5 from Paul Poulain --- Patch tested with a sandbox, by Marc Sabin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 10:15:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 09:15:37 +0000 Subject: [Koha-bugs] [Bug 9685] Allow sort baskets by number In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9685 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15766|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 10:15:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 09:15:44 +0000 Subject: [Koha-bugs] [Bug 9685] Allow sort baskets by number In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9685 --- Comment #6 from Paul Poulain --- Created attachment 15926 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15926&action=edit Add robots txt file to deny all bots Signed-off-by: Marc Sabin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 10:47:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 09:47:02 +0000 Subject: [Koha-bugs] [Bug 8306] Patron stats, patron activity : no active doesn't work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8306 Marc Sabin changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marc.sabin at sciencespo-greno | |ble.fr --- Comment #4 from Marc Sabin --- Following the test plan, the 4th step (inactive) doesn't work : either "no result" or "504 Gatewat Time Out". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 11:08:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 10:08:03 +0000 Subject: [Koha-bugs] [Bug 8306] Patron stats, patron activity : no active doesn't work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8306 --- Comment #5 from Marc Sabin --- I've just test on a sandbox and the patch seems to work. The last step (select "inactive" in the "Patron activity" parameter) gives me the stats for the inactive patrons. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 11:29:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 10:29:44 +0000 Subject: [Koha-bugs] [Bug 9758] New: sudo update-rc.d koha-zebraqueue-daemon defaults Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9758 Bug ID: 9758 Summary: sudo update-rc.d koha-zebraqueue-daemon defaults Classification: Unclassified Change sponsored?: --- Product: Koha Version: 3.10 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs at lists.koha-community.org Reporter: shade1947 at gmail.com CC: gmcharlt at gmail.com Hi frnds, while i was trying to install koha 3.10.03, i faced proble in installing zebraqueue sudo ln -s /usr/share/koha/bin/koha-zebraqueue-ctl.sh /etc/init.d/koha-zebraqueue-daemon sudo update-rc.d koha-zebraqueue-daemon defaults it shows the error mssage file does not exists could you please any one help me out -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 11:32:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 10:32:56 +0000 Subject: [Koha-bugs] [Bug 9685] Allow sort baskets by number In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9685 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #7 from M. de Rooy --- (In reply to comment #6) > Created attachment 15926 [details] [review] > Add robots txt file to deny all bots > > Signed-off-by: Marc Sabin Looks like a mistake... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 11:54:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 10:54:37 +0000 Subject: [Koha-bugs] [Bug 9759] New: last subfield can be deleted Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9759 Bug ID: 9759 Summary: last subfield can be deleted Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: fridolyn.somers at biblibre.com CC: m.de.rooy at rijksmuseum.nl In authorities and biblios editors, a repeatable subfield can be deleted (small icon next to input). Clone subfields are really deleted but last existing subfield is just set empty instead of deleted. But when same field is repeated, the last subfield can be deleted. The code checks for existing subfields in all fields instead of in field of the deleting subfield. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 12:09:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 11:09:59 +0000 Subject: [Koha-bugs] [Bug 9759] last subfield can be deleted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9759 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt at gmail.com |fridolyn.somers at biblibre.co | |m --- Comment #1 from Fridolyn SOMERS --- Created attachment 15927 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15927&action=edit Proposed patch See commit message -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 12:10:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 11:10:05 +0000 Subject: [Koha-bugs] [Bug 9759] last subfield can be deleted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9759 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 12:14:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 11:14:44 +0000 Subject: [Koha-bugs] [Bug 6279] Can't delete lists from the second page of lists in the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6279 --- Comment #5 from Fridolyn SOMERS --- Seems lists need some revamping. It is just impossible to correct this bug with current code. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 12:32:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 11:32:46 +0000 Subject: [Koha-bugs] [Bug 8507] koha-create should be updated to use DOM indexing for bib In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8507 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|3.8 |master --- Comment #1 from Katrin Fischer --- Giving this a little nudge and updating version. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 12:45:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 11:45:14 +0000 Subject: [Koha-bugs] [Bug 9758] sudo update-rc.d koha-zebraqueue-daemon defaults In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9758 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #1 from Jared Camins-Esakov --- Please send support questions to the mailing list rather than opening bugs on Bugzilla in the future. Zebraqueue daemon has been deprecated since version 3.2, at least, and was removed in 3.10. You need to use the Zebra cron jobs, as directed in the installation instructions. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 13:19:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 12:19:42 +0000 Subject: [Koha-bugs] [Bug 9760] New: Simplify local use preferences Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9760 Bug ID: 9760 Summary: Simplify local use preferences Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: System Administration Assignee: m.de.rooy at rijksmuseum.nl Reporter: m.de.rooy at rijksmuseum.nl CC: gmcharlt at gmail.com A lot of code in systempreferences.pl should be obsoleted. It is the old code for preferences. Only code pertaining to local use preferences should be kept. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 13:22:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 12:22:19 +0000 Subject: [Koha-bugs] [Bug 9760] Simplify local use preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9760 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 13:22:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 12:22:21 +0000 Subject: [Koha-bugs] [Bug 9760] Simplify local use preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9760 --- Comment #1 from M. de Rooy --- Created attachment 15928 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15928&action=edit Bug 9760: Simplify local use preferences Removes a lot of code that was needed to handle prefs the old way. Test plan: Goto Local use preferences. Do you see some local preferences? Add a new pref, edit and delete it. Modify the url to systempreferences.pl?tab=OPAC or tab=log. You should only see a short message. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 13:23:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 12:23:32 +0000 Subject: [Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 --- Comment #33 from Jared Camins-Esakov --- Created attachment 15929 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15929&action=edit Bug 9239 QA-follow-up: quiet warnings and fix problem with limits -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 13:31:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 12:31:29 +0000 Subject: [Koha-bugs] [Bug 9761] New: Make it possible to confirm future hold requests at checkin time Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9761 Bug ID: 9761 Summary: Make it possible to confirm future hold requests at checkin time Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: m.de.rooy at rijksmuseum.nl Reporter: m.de.rooy at rijksmuseum.nl CC: gmcharlt at gmail.com Make it possible to confirm future hold requests at checkin time. Part of developments for bug 9721. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 13:31:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 12:31:52 +0000 Subject: [Koha-bugs] [Bug 9761] Make it possible to confirm future hold requests at checkin time In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9761 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9721 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 13:31:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 12:31:52 +0000 Subject: [Koha-bugs] [Bug 9721] Umbrella report for hold changes to meet special library needs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9721 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9761 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 13:32:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 12:32:31 +0000 Subject: [Koha-bugs] [Bug 9721] Umbrella report for hold changes to meet special library needs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9721 --- Comment #3 from M. de Rooy --- Created bug 9761 to realize goal 3. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 14:01:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 13:01:25 +0000 Subject: [Koha-bugs] [Bug 9762] New: wait to track overrides Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762 Bug ID: 9762 Summary: wait to track overrides Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com It would be great if there were a way to track whenever someone overrides a warning message in circulation. Whether it's ignoring a hold for someone or checking out even though the patron owes too much - any of the warnings with buttons listed here: http://manual.koha-community.org/3.12/en/circulation.html#checkoutwarn or here: http://manual.koha-community.org/3.12/en/checkingin.html#checkinmsg would be tracked. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 14:02:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 13:02:05 +0000 Subject: [Koha-bugs] [Bug 9762] way to track overrides In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|wait to track overrides |way to track overrides -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 14:07:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 13:07:19 +0000 Subject: [Koha-bugs] [Bug 7131] way to overlay items in in marc import In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7131 --- Comment #12 from Kyle M Hall --- Comment on attachment 14475 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14475 Patch adds the ability to overlay items when Staging Review of attachment 14475: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=7131&attachment=14475) ----------------------------------------------------------------- ::: C4/ImportBatch.pm @@ +696,5 @@ > $sth->execute(); > while (my $row = $sth->fetchrow_hashref()) { > my $item_marc = MARC::Record->new_from_xml(StripNonXmlChars($row->{'marcxml'}), 'UTF-8', $row->{'encoding'}); > + #delete date_due subfield as to not accidentally delete item checkout due dates > + $item_marc->field('952')->delete_subfield(code => 'q'); This is a problem. Not all frameworks will have items.onloan mapped to 952$q. We need to look up the problem tag/subtag here using C4::Biblio::GetMarcFromKohaField or get the value via C4::Biblio::GetRecordValue. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 14:09:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 13:09:23 +0000 Subject: [Koha-bugs] [Bug 7131] way to overlay items in in marc import In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7131 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #13 from Kyle M Hall --- (In reply to comment #12) > Comment on attachment 14475 [details] [review] > Patch adds the ability to overlay items when Staging > > Review of attachment 14475 [details] [review]: > ----------------------------------------------------------------- > > ::: C4/ImportBatch.pm > @@ +696,5 @@ > > $sth->execute(); > > while (my $row = $sth->fetchrow_hashref()) { > > my $item_marc = MARC::Record->new_from_xml(StripNonXmlChars($row->{'marcxml'}), 'UTF-8', $row->{'encoding'}); > > + #delete date_due subfield as to not accidentally delete item checkout due dates > > + $item_marc->field('952')->delete_subfield(code => 'q'); > > This is a problem. Not all frameworks will have items.onloan mapped to > 952$q. We need to look up the problem tag/subtag here using > C4::Biblio::GetMarcFromKohaField or get the value via > C4::Biblio::GetRecordValue. I just realized GetRecordValue will be useless in this scenario, you need to use GetMarcFromKohaField. ($MARCfield,$MARCsubfield)=GetMarcFromKohaField($kohafield,$frameworkcode); -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 14:09:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 13:09:53 +0000 Subject: [Koha-bugs] [Bug 7131] way to overlay items in in marc import In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7131 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 14:58:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 13:58:20 +0000 Subject: [Koha-bugs] [Bug 9763] New: Add callnumber column to "print summary" for moremember.pl Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9763 Bug ID: 9763 Summary: Add callnumber column to "print summary" for moremember.pl Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 15:00:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 14:00:23 +0000 Subject: [Koha-bugs] [Bug 9763] Add callnumber column to "print summary" for moremember.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9763 --- Comment #1 from Kyle M Hall --- Created attachment 15930 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15930&action=edit Bug 9763 - Add callnumber column to "print summary" for moremember.pl Test plan: 1) Apply patch 2) Check out some items to a borrower 3) Choose "Print summary" from the "Print" pulldown 4) Observe the new callnumber column after "Author: and before "Item type" 5) Note that the totals in the footer are still aligned correctly -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 15:00:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 14:00:34 +0000 Subject: [Koha-bugs] [Bug 9763] Add callnumber column to "print summary" for moremember.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9763 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 15:00:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 14:00:41 +0000 Subject: [Koha-bugs] [Bug 9763] Add callnumber column to "print summary" for moremember.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9763 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 15:00:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 14:00:48 +0000 Subject: [Koha-bugs] [Bug 9763] Add callnumber column to "print summary" for moremember.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9763 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 15:07:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 14:07:10 +0000 Subject: [Koha-bugs] [Bug 9103] overdue_notices.pl should use AutoEmailPrimaryAddress syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9103 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13511|0 |1 is obsolete| | --- Comment #5 from Fridolyn SOMERS --- Created attachment 15931 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15931&action=edit Proposed patch (revised) Due to Bug 6835 integration in master, I've rewritten patch. New patch renames as asked method GetPrimaryEmailAddress into GetNoticeEmailAddress, meaning the email used to sent notices. Bug 6835 added a GetMember() call to get emails. I changed to get them in the existing query. A consequence is the use of fetchrow_hashref to have datas into a hash. This is more useful and generally used to get query results. Also, prepare_letter_for_printing was called twice where it can be once. See test plan on comment 3. Note that if --email option is used, it overrides notice email address. I could uses some help on a more complex one and for unit test. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 15:07:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 14:07:17 +0000 Subject: [Koha-bugs] [Bug 9103] overdue_notices.pl should use AutoEmailPrimaryAddress syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9103 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 15:07:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 14:07:40 +0000 Subject: [Koha-bugs] [Bug 9103] overdue_notices.pl should use AutoEmailPrimaryAddress syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9103 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 15:09:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 14:09:58 +0000 Subject: [Koha-bugs] [Bug 9761] Make it possible to confirm future hold requests at checkin time In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9761 --- Comment #1 from M. de Rooy --- Created attachment 15932 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15932&action=edit Bug 9761: Make it possible to confirm future hold requests at checkin time Description: A new pref ConfirmFutureHolds is added. When confirming a hold at checkin time, the number of days in this pref is taken into account when looking for reserves. Note that this pref does not interfere with renewing, issuing or transferring a book. For report Holds to pull, the default end date is calculated with this new preference. The use of ConfirmFutureHolds is useful only when future holds are allowed. Test plan: 1) Enable future holds. Add a number of days into ConfirmFutureHolds. 2) Place a future hold within this number of days. 3) Run holds to pull report. Check default startdate and enddate. 4) Check this book in. Can you confirm the hold? Do not confirm. 5) Issue the book to another patron. You should not see a warning. 6) Renew the book for this patron via opac or staff. No warning either. 7) Check in again. Warning pops up again. 8) Transfer book. Switch branch. Check in. Hold found pops up. Do not confirm. 9) Back to first branch. Check in (with popup). Remove the hold. Add new future hold past the number of days. Check in (no warn). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 15:11:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 14:11:19 +0000 Subject: [Koha-bugs] [Bug 9761] Make it possible to confirm future hold requests at checkin time In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9761 --- Comment #2 from M. de Rooy --- Created attachment 15933 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15933&action=edit Bug 9761: dbrev for ConfirmFutureHolds Db rev for new pref ConfirmFutureHolds. Test plan: Run [your server]/cgi-bin/koha/installer/install.pl?step=3&op=updatestructure Optionally, run a new install to test sysprefs.sql. Or: Edit sysprefs.sql, leave at least the last few lines including the new one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 15:11:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 14:11:44 +0000 Subject: [Koha-bugs] [Bug 9761] Make it possible to confirm future hold requests at checkin time In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9761 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 15:18:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 14:18:26 +0000 Subject: [Koha-bugs] [Bug 9574] serials/subscription-add.pl does not work right under Plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9574 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Jared Camins-Esakov --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 15:20:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 14:20:09 +0000 Subject: [Koha-bugs] [Bug 8620] Barcode searching not working correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8620 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #18 from Jared Camins-Esakov --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 15:27:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 14:27:43 +0000 Subject: [Koha-bugs] [Bug 9656] fines.pl creating a log file should be optional In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9656 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #15 from Jared Camins-Esakov --- This patch has been pushed to master. The output directory is not set according to an environment variable as claimed by the help, but the help was wrong prior to these patches so I am pushing them anyway. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 15:29:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 14:29:05 +0000 Subject: [Koha-bugs] [Bug 9653] Filters on suggestion page in intranet are broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9653 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Jared Camins-Esakov --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 15:31:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 14:31:40 +0000 Subject: [Koha-bugs] [Bug 9620] IncludeSeeFromInSearches ON and data in $9 subfields can break indexing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9620 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Jared Camins-Esakov --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 15:32:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 14:32:41 +0000 Subject: [Koha-bugs] [Bug 9761] Make it possible to confirm future hold requests at checkin time In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9761 --- Comment #3 from M. de Rooy --- Will also add some comments as results of code analysis for these patches here too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 15:34:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 14:34:30 +0000 Subject: [Koha-bugs] [Bug 8585] Add System Preference to specify Holds to Pull List Start Date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8585 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9761 --- Comment #20 from M. de Rooy --- Bug 9761 adds a similar preference for the end date. This does not only apply to Holds to pull but does extend to confirming future pending holds. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 15:34:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 14:34:30 +0000 Subject: [Koha-bugs] [Bug 9761] Make it possible to confirm future hold requests at checkin time In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9761 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8585 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 15:34:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 14:34:48 +0000 Subject: [Koha-bugs] [Bug 9570] view plain not working in ccsr In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9570 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jared Camins-Esakov --- This patch has been pushed to master. It would be great to handle the XSLT for the MARC view in C4::XSLT, but this fix is suitable for the time being. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 15:45:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 14:45:39 +0000 Subject: [Koha-bugs] [Bug 9267] Ubuntu 12.04 install docs broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9267 --- Comment #5 from Elliott Davis --- Comment on attachment 14654 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14654 Bug 9267 - Ubuntu 12.04 install docs broken Review of attachment 14654: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=9267&attachment=14654) ----------------------------------------------------------------- ::: install_misc/ubuntu.12.04.packages @@ +64,4 @@ > libdatetime-perl install > libdatetime-event-ical-perl install > libdatetime-format-dateparse-perl install > +libdatetime-format-ical-perl install Why is this modified? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 15:47:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 14:47:48 +0000 Subject: [Koha-bugs] [Bug 9267] Ubuntu 12.04 install docs broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9267 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Jared Camins-Esakov --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 15:50:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 14:50:16 +0000 Subject: [Koha-bugs] [Bug 9586] Remove $ENV{DEBUG} info from Member Template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9586 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jared Camins-Esakov --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 15:52:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 14:52:43 +0000 Subject: [Koha-bugs] [Bug 9698] Replace YUI buttons on patron card creator manage toolbar with Bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9698 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jared Camins-Esakov --- This patch has been pushed to master. Plus sign icons would be a nice follow-up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 15:55:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 14:55:34 +0000 Subject: [Koha-bugs] [Bug 9696] Remove YUI styling from buttons on patron card creator edit pages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9696 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jared Camins-Esakov --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 15:57:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 14:57:54 +0000 Subject: [Koha-bugs] [Bug 9694] Remove YUI styling from buttons on the patron card creator manage pages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9694 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jared Camins-Esakov --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 16:03:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 15:03:59 +0000 Subject: [Koha-bugs] [Bug 9693] Remove YUI styling from buttons on the patron card creator's image manage page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9693 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #10 from Jared Camins-Esakov --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 16:11:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 15:11:46 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #14 from Jonathan Druart --- Created attachment 15934 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15934&action=edit Bug 7180: Fix typo, budget_code is a var, not a string... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 16:11:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 15:11:50 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #15 from Jonathan Druart --- Created attachment 15935 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15935&action=edit Bug 7180: FIX ergonomic issue on selecting record Before this patch, all labels were active for the first checkbox. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 16:13:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 15:13:21 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #16 from Jonathan Druart --- Hello Mathieu, Very stupid error, my fault. Fixed in the first followup. However for sort1 and sort2, you must to fill the statistic fields (sort1 and sort2) for your budget with an authorized values categories (like asort1, LOC, DAMAGED, etc.). Then fill 923$a and 924$a with a corresponding authorized value. e.g. budget.sort1 = LOC and 923$a=CART -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 16:15:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 15:15:00 +0000 Subject: [Koha-bugs] [Bug 7518] searches with quotation marks don't work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7518 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14187|0 |1 is obsolete| | --- Comment #16 from Fridolyn SOMERS --- Created attachment 15936 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15936&action=edit Proposed patch Rewritten patch. Problem comes only from C4::Seach::_build_weighted_query, depending on QueryWeightFields syspref. This code builds a complex CCL query using " around search words. So if a search word contains a ", the CCL query is wrong and you get no results. This patch simply replaces " by a space in _build_weighted_query. See commit comment. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 16:15:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 15:15:19 +0000 Subject: [Koha-bugs] [Bug 7518] searches with quotation marks don't work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7518 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 16:16:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 15:16:57 +0000 Subject: [Koha-bugs] [Bug 9689] Replace YUI buttons on the OAI sets administration page with Bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9689 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jared Camins-Esakov --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 16:18:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 15:18:31 +0000 Subject: [Koha-bugs] [Bug 9688] Replace YUI button on Authority MARC framework toolbar with Bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9688 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jared Camins-Esakov --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 16:20:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 15:20:54 +0000 Subject: [Koha-bugs] [Bug 9676] Replace YUI buttons on authorities editor page with Bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9676 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jared Camins-Esakov --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 16:25:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 15:25:29 +0000 Subject: [Koha-bugs] [Bug 9672] Replace YUI buttons on MARC editor page with Bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9672 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jared Camins-Esakov --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 16:29:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 15:29:04 +0000 Subject: [Koha-bugs] [Bug 9649] Replace YUI buttons on cataloging home page with Bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9649 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jared Camins-Esakov --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 16:31:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 15:31:47 +0000 Subject: [Koha-bugs] [Bug 9456] Add callnumber column to the cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 --- Comment #34 from Jared Camins-Esakov --- Kyle, The patch you uploaded is the one from Owen with sign-offs by Stephane and Jonathan. If Owen agrees that we should go with your patch, could you please attach the standalone version (you might as well squash the follow-up) and mark it Needs Signoff so that we can move it through the QA process? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 16:36:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 15:36:13 +0000 Subject: [Koha-bugs] [Bug 9458] Add sorting to lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9458 --- Comment #27 from Jared Camins-Esakov --- I've noticed something very odd about sorting on the staff client: if I choose to sort by title (for example), it always defaults to sorting in *descending* order, from Z-A. Is there any way to fix that so that it sorts according to what we might expect? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 16:38:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 15:38:55 +0000 Subject: [Koha-bugs] [Bug 9450] Use DataTables in cataloging Z39.50 search results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9450 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #10 from Jared Camins-Esakov --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 16:41:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 15:41:35 +0000 Subject: [Koha-bugs] [Bug 9456] Add callnumber column to the cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15845|0 |1 is obsolete| | Attachment #15848|0 |1 is obsolete| | --- Comment #35 from Kyle M Hall --- Created attachment 15937 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15937&action=edit Bug 9456 - Add callnumber column to the cart This patch adds call-number sorting to the staff client cart. Sortining is enabled on the 'Items' column which uses a custom sorting routine to sort the callnumbers. If the sort is ascending, each column will be sorted by the highest ordered callnumber for that row. Likewise, if the sort is descending the table will be sorted by the lowest valued callnumber for that row. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 16:41:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 15:41:55 +0000 Subject: [Koha-bugs] [Bug 9446] Use DataTables on Z39.50 servers administration page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9446 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Jared Camins-Esakov --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 16:43:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 15:43:30 +0000 Subject: [Koha-bugs] [Bug 9444] Use DataTables in system preferences editor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9444 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #10 from Jared Camins-Esakov --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 16:46:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 15:46:05 +0000 Subject: [Koha-bugs] [Bug 9437] Use DataTables on itemtypes administration page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9437 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Jared Camins-Esakov --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 16:48:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 15:48:07 +0000 Subject: [Koha-bugs] [Bug 9436] Use DataTables on cities administration page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9436 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #8 from Jared Camins-Esakov --- This conflicts with the Bootstrap button for creating a new city. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 16:50:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 15:50:12 +0000 Subject: [Koha-bugs] [Bug 9456] Add callnumber column to the cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 --- Comment #36 from Kyle M Hall --- Created attachment 15938 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15938&action=edit Bug 9456 - Add callnumber column to the cart - add tooltip -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 16:50:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 15:50:43 +0000 Subject: [Koha-bugs] [Bug 9430] Use DataTables on library transfer limits page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9430 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Jared Camins-Esakov --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 16:51:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 15:51:56 +0000 Subject: [Koha-bugs] [Bug 9456] Add callnumber column to the cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 --- Comment #37 from Kyle M Hall --- (In reply to comment #34) > Kyle, > > The patch you uploaded is the one from Owen with sign-offs by Stephane and > Jonathan. If Owen agrees that we should go with your patch, could you please > attach the standalone version (you might as well squash the follow-up) and > mark it Needs Signoff so that we can move it through the QA process? Fixed! Seeing as I cannot let well enough alone, I've included another followup that adds a tooltip to the items sorting explaining it's behavior. If everyone thinks this is a good addition, I can squash it into the primary patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 16:52:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 15:52:27 +0000 Subject: [Koha-bugs] [Bug 9429] Use DataTables on Authorized Values page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9429 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Jared Camins-Esakov --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 16:54:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 15:54:51 +0000 Subject: [Koha-bugs] [Bug 9428] Use DataTables in Authority MARC frameworks page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9428 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #9 from Jared Camins-Esakov --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 16:56:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 15:56:35 +0000 Subject: [Koha-bugs] [Bug 9435] Use DataTables on libraries and groups administration page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9435 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #9 from Jared Camins-Esakov --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 16:59:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 15:59:27 +0000 Subject: [Koha-bugs] [Bug 7387] Add Template::Toolkit plugin to allow caching of includes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7387 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #15 from Jared Camins-Esakov --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 17:06:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 16:06:04 +0000 Subject: [Koha-bugs] [Bug 5079] Make display of shelving location and call number in XSLT results controlled by sysprefs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5079 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #49 from Jared Camins-Esakov --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 17:08:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 16:08:30 +0000 Subject: [Koha-bugs] [Bug 1047] Punctuation in site names breaks Edit/Delete z39.50 server administration In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1047 Isaac changed: What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |REOPENED CC| |isaacbrodsky at live.com Resolution|FIXED |--- --- Comment #1 from Isaac --- Reopening: I'm experiencing this issue with Koha 3.08 on Debian. I entered a Z39.50 server name containing an ampersand and system administration does not seem to be able to handle it. (Edit & delete break as described, searching on server seems to work fine.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 17:10:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 16:10:38 +0000 Subject: [Koha-bugs] [Bug 9456] Add callnumber column to the cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15813|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 17:12:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 16:12:47 +0000 Subject: [Koha-bugs] [Bug 5534] koha does not ignore punctuation when searching In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5534 Isaac changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |isaacbrodsky at live.com --- Comment #7 from Isaac --- Just to add my two cents, a user could want to search for punctuation. (So searching for "C++" actually searches for "C", which is undesirable.) Is this intended? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 17:13:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 16:13:46 +0000 Subject: [Koha-bugs] [Bug 6898] circulation librarians can't run overdues without reports permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 --- Comment #19 from Fridolyn SOMERS --- Created attachment 15939 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15939&action=edit Proposed patch (followup) Follow up for better update database. Adds new permission for users with all report permissions and circulation remaining permission. This will not concern user having all circulation permissions. There is no need because when all module is permitted, sub-permissions does not exist in user_permissions, module permission is stored into borrowers.flags. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 17:16:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 16:16:26 +0000 Subject: [Koha-bugs] [Bug 9456] Add callnumber column to the cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 17:17:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 16:17:13 +0000 Subject: [Koha-bugs] [Bug 8917] Track clicks to links external to Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #72 from Jared Camins-Esakov --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 17:18:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 16:18:09 +0000 Subject: [Koha-bugs] [Bug 9456] Add callnumber column to the cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #38 from Owen Leonard --- (In reply to comment #35) > Created attachment 15937 [details] [review] This patch doesn't apply. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 17:24:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 16:24:43 +0000 Subject: [Koha-bugs] [Bug 6898] circulation librarians can't run overdues without reports permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #20 from Fridolyn SOMERS --- I set status to signed-off. Followup can be validated by QA ? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 17:27:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 16:27:32 +0000 Subject: [Koha-bugs] [Bug 9511] DOM indexing problem In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9511 --- Comment #13 from Paul A --- 3.8.10 tarball on Ubuntu 12.04.2 LTS, db imported from 3.8.5; using an incremental CRON '$KOHAPATH/bin/migration_tools/rebuild_zebra.pl -a -b -z -x' (with or without the '-x') does not remove the deleted record; a complete rebuild_zebra.pl -b -r -v -x is required. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 17:29:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 16:29:22 +0000 Subject: [Koha-bugs] [Bug 6898] circulation librarians can't run overdues without reports permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15939|0 |1 is obsolete| | --- Comment #21 from Fridolyn SOMERS --- Created attachment 15940 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15940&action=edit Proposed patch (followup) Small error in first patch. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 17:33:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 16:33:13 +0000 Subject: [Koha-bugs] [Bug 9566] Only run analytics code if analytics are enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9566 --- Comment #4 from Fridolyn SOMERS --- (In reply to comment #3) > Hmm, there are also normal analytics (not easy analytics), has this been > checked with that? IE does it make sure not to break normal analytics? Your right, I hope working on this with some people during hackfest. Maybe addind a new syspref for all analitics code ; we have a library that uses UNIMARC 461$9 for another purpose. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 17:42:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 16:42:44 +0000 Subject: [Koha-bugs] [Bug 9456] Add callnumber column to the cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15938|0 |1 is obsolete| | --- Comment #39 from Kyle M Hall --- Created attachment 15941 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15941&action=edit Bug 9456 - Add callnumber column to the cart - add tooltip -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 17:43:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 16:43:05 +0000 Subject: [Koha-bugs] [Bug 9377] itemtype in duplicate biblio search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9377 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15798|0 |1 is obsolete| | --- Comment #10 from Fridolyn SOMERS --- Created attachment 15942 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15942&action=edit Proposed patch (remove itemtype) Rewritten patch that simply removes item type from find duplicate. See commit message -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 17:43:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 16:43:13 +0000 Subject: [Koha-bugs] [Bug 9377] itemtype in duplicate biblio search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9377 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 17:45:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 16:45:45 +0000 Subject: [Koha-bugs] [Bug 9456] Add callnumber column to the cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15937|0 |1 is obsolete| | --- Comment #40 from Kyle M Hall --- Created attachment 15943 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15943&action=edit Bug 9456 - Add callnumber column to the cart This patch adds call-number sorting to the staff client cart. Sortining is enabled on the 'Items' column which uses a custom sorting routine to sort the callnumbers. If the sort is ascending, each column will be sorted by the highest ordered callnumber for that row. Likewise, if the sort is descending the table will be sorted by the lowest valued callnumber for that row. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 17:45:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 16:45:57 +0000 Subject: [Koha-bugs] [Bug 9456] Add callnumber column to the cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15941|0 |1 is obsolete| | --- Comment #41 from Kyle M Hall --- Created attachment 15944 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15944&action=edit Bug 9456 - Add callnumber column to the cart - add tooltip -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 17:47:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 16:47:16 +0000 Subject: [Koha-bugs] [Bug 9456] Add callnumber column to the cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA --- Comment #42 from Kyle M Hall --- Fixed! I've also switched from using the Bootstrap tooltip to the Bootstrap popover as it is visually more pleasing ( though I suppose we could restyle the tooltip to look more pleasing as well ). (In reply to comment #38) > (In reply to comment #35) > > Created attachment 15937 [details] [review] [review] > > This patch doesn't apply. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 17:47:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 16:47:32 +0000 Subject: [Koha-bugs] [Bug 8462] OpacHiddenItems and hidelostitems hide items, but query result count is off In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 --- Comment #26 from Fridolyn SOMERS --- (In reply to comment #23) > (In reply to comment #22) > +1 for solution 2. > > I think indeed the best solution is to use Suppress index. > The automatic suppress field could be updated in rebuild_zebra.pl. > An idea for syspref : OpacAutoSuppressField. A better solution is to add a new column to biblio or bilioitems table, mapped with opacsuppress subfield. This can be used to forbid access to a biblio via URL direct edition. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 17:51:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 16:51:27 +0000 Subject: [Koha-bugs] [Bug 9456] Add callnumber column to the cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Needs Signoff --- Comment #43 from Jared Camins-Esakov --- I'm still a bit confused about which patch you've decided to use, but either way it needs to be signed off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 18:10:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 17:10:05 +0000 Subject: [Koha-bugs] [Bug 7494] Use partial barcode or callnumber as a fallback for the barcode search in checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7494 MJ Ray (software.coop) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10139|0 |1 is obsolete| | --- Comment #5 from MJ Ray (software.coop) --- Created attachment 15945 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15945&action=edit bug 7494: optional checkout-time fallback search for a book When issuing a book, some libraries want to issue by title or other details. This patch adds a systempreference and code that allows it. To test: 1) scan a patron card or enter a surname to start checking out; 2) enter title or other keywords; 3) the circulation screen should display a warning allowing to choose between copies. Signed-off-by: MJ Ray -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 18:12:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 17:12:04 +0000 Subject: [Koha-bugs] [Bug 7494] Use partial barcode or callnumber as a fallback for the barcode search in checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7494 --- Comment #6 from MJ Ray (software.coop) --- rebased to current master I think this version allows you to choose between possible matches. Do you think this could be included? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 18:12:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 17:12:34 +0000 Subject: [Koha-bugs] [Bug 9456] Add callnumber column to the cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 --- Comment #44 from Kyle M Hall --- (In reply to comment #43) > I'm still a bit confused about which patch you've decided to use, but either > way it needs to be signed off. Sorry, my bad! I still advocate for the patch I submitted as Owen's patch, while visually quite nice, lacks the functionality that is the entire point of this feature ( being able to sort the entire table by callnumber ). Owen, please give my latest patch a try and let me know what you think! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 18:14:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 17:14:16 +0000 Subject: [Koha-bugs] [Bug 7494] Use partial barcode or callnumber as a fallback for the barcode search in checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7494 MJ Ray (software.coop) changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 18:18:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 17:18:16 +0000 Subject: [Koha-bugs] [Bug 6898] circulation librarians can't run overdues without reports permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15940|0 |1 is obsolete| | --- Comment #22 from Kyle M Hall --- Created attachment 15946 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15946&action=edit [SIGNED-OFF] Bug 6898 - circulation librarians can't run overdues without reports permissions followup Better update database. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 18:19:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 17:19:52 +0000 Subject: [Koha-bugs] [Bug 6898] circulation librarians can't run overdues without reports permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 --- Comment #23 from Kyle M Hall --- (In reply to comment #20) > I set status to signed-off. > Followup can be validated by QA ? Fridolyn, I don't see your SO on my original patch. Kyle -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 18:20:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 17:20:15 +0000 Subject: [Koha-bugs] [Bug 6898] circulation librarians can't run overdues without reports permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15162|0 |1 is obsolete| | --- Comment #24 from Kyle M Hall --- Created attachment 15947 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15947&action=edit Bug 6898 - circulation librarians can't run overdues without reports permissions This patch adds a new user permission overdues_report for the circulation module, and requires this permission to run the overdue items report, rather than requiring full reports permissions. Test plan : With a user with permissions circulate_remaining_permissions : - Add overdues_report permission to user - Go to circulation home => you see "Overdues" link - Clik on it => you are allowed to access and use this page - Remove overdues_report permission to user - Go to circulation home => you do not see "Overdues" link - Edit URL : /cgi-bin/koha/circ/overdue.pl => you are not allowed to access this page - Go to main page => you don't have access to reports module Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 18:20:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 17:20:37 +0000 Subject: [Koha-bugs] [Bug 6898] circulation librarians can't run overdues without reports permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15946|0 |1 is obsolete| | --- Comment #25 from Kyle M Hall --- Created attachment 15948 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15948&action=edit [SIGNED-OFF] Bug 6898 - circulation librarians can't run overdues without reports permissions followup Better update database. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 18:21:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 17:21:45 +0000 Subject: [Koha-bugs] [Bug 6898] circulation librarians can't run overdues without reports permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 --- Comment #26 from Kyle M Hall --- I've uploaded a rebased version of the patch. Also, thanks for the followup Fridolyn! (In reply to comment #23) > (In reply to comment #20) > > I set status to signed-off. > > Followup can be validated by QA ? > > Fridolyn, I don't see your SO on my original patch. > > Kyle -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 18:24:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 17:24:39 +0000 Subject: [Koha-bugs] [Bug 9456] Add callnumber column to the cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 --- Comment #45 from Jared Camins-Esakov --- Kyle, > Sorry, my bad! I still advocate for the patch I submitted as Owen's patch, > while visually quite nice, lacks the functionality that is the entire point > of this feature ( being able to sort the entire table by callnumber ). In that case, please attach it to this bug. Owen's patch is the one you have been attaching to the bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 18:28:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 17:28:49 +0000 Subject: [Koha-bugs] [Bug 9456] Add callnumber column to the cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15943|0 |1 is obsolete| | --- Comment #46 from Kyle M Hall --- Created attachment 15949 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15949&action=edit Bug 9456 - Add callnumber column to the cart This patch adds call-number sorting to the staff client cart. Sortining is enabled on the 'Items' column which uses a custom sorting routine to sort the callnumbers. If the sort is ascending, each column will be sorted by the highest ordered callnumber for that row. Likewise, if the sort is descending the table will be sorted by the lowest valued callnumber for that row. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 18:29:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 17:29:22 +0000 Subject: [Koha-bugs] [Bug 9456] Add callnumber column to the cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15944|0 |1 is obsolete| | --- Comment #47 from Kyle M Hall --- Created attachment 15950 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15950&action=edit Bug 9456 - Add callnumber column to the cart - add tooltip -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 18:50:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 17:50:14 +0000 Subject: [Koha-bugs] [Bug 9761] Make it possible to confirm future hold requests at checkin time In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9761 --- Comment #4 from M. de Rooy --- Created attachment 15951 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15951&action=edit Bug 9761: Reformulating the preference description After some thought, I had to reformulate what this pref does. No code changes here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 19:30:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 18:30:47 +0000 Subject: [Koha-bugs] [Bug 9458] Add sorting to lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9458 --- Comment #28 from Kyle M Hall --- Created attachment 15952 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15952&action=edit Bug 9458 - Add sorting to lists - QA Followup 4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 19:32:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 18:32:13 +0000 Subject: [Koha-bugs] [Bug 9458] Add sorting to lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9458 --- Comment #29 from Kyle M Hall --- Good catch! This latest followup fixes that. I've also simplified some of the presentation logic. (In reply to comment #27) > I've noticed something very odd about sorting on the staff client: if I > choose to sort by title (for example), it always defaults to sorting in > *descending* order, from Z-A. Is there any way to fix that so that it sorts > according to what we might expect? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 20:20:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 19:20:30 +0000 Subject: [Koha-bugs] [Bug 9764] New: Replace YUI buttons on the authority search popup with Bootstrap Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9764 Bug ID: 9764 Summary: Replace YUI buttons on the authority search popup with Bootstrap Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/authorities/auth_finder.pl OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org The authority search popup has several buttons which are styled with YUI. A couple of these ("Submit," "Cancel") should not be styled at all to conform with general practice. The others ("Clear field," "Create new") can be moved to a toolbar div and styled with Bootstrap. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 20:31:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 19:31:09 +0000 Subject: [Koha-bugs] [Bug 9764] Replace YUI buttons on the authority search popup with Bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9764 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 20:31:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2013 19:31:11 +0000 Subject: [Koha-bugs] [Bug 9764] Replace YUI buttons on the authority search popup with Bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9764 --- Comment #1 from Owen Leonard --- Created attachment 15953 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15953&action=edit Bug 9764 - Replace YUI buttons on authority search popup with Bootstrap The authority search popup styles several buttons with YUI. Bootstrap should be used instead. This patch removes YUI styling from two buttons ("Submit" and "Cancel") in favor of default styling for consistency's sake. The other buttons ("Clear field" and "Create new") have been moved to a standard toolbar div and styled with Bootstrap. Some inline JavaScript has been moved to the