[Koha-bugs] [Bug 8917] Track clicks to links external to Koha

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917

--- Comment #48 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to comment #47)
> (In reply to comment #46)
> > (In reply to comment #38)
> > > Comment on attachment 15714 [details] [review] [review] [review]
> > > [SIGNED_OFF] Bug 8917 : Script to log link clicks
> > > 
> > > Review of attachment 15714 [details] [review] [review] [review]:
> > > -----------------------------------------------------------------
> > > 
> > > ::: opac/tracklinks.pl
> > > @@ +65,5 @@
> > > > +    print $cgi->redirect("/cgi-bin/koha/errors/404.pl");    # escape early
> > > > +    exit;
> > > > +}
> > > > +
> > > > +sub trackclick {
> > > 
> > > Don't we want to have this routine into a new module (in order to prevent
> > > sql code into pl file)?
> > 
> > Hi Chris,
> > You didn't address this remark, isn't it relevant?
> 
> I didn't think it was, no.

So please set out your argument, mine is the coding guidelines : 
http://wiki.koha-community.org/wiki/Coding_Guidelines#SQL8:_SQL_code_in_.pl_scripts

-- 
You are receiving this mail because:
You are watching all bug changes.