[Koha-bugs] [Bug 9749] New: Placeholders in koha-conf.xml generated by the Debian packages

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9749

            Bug ID: 9749
           Summary: Placeholders in koha-conf.xml generated by the Debian
                    packages
    Classification: Unclassified
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Packaging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: magnus at enger.priv.no
                CC: robin at catalyst.net.nz

Bug 7028 updated the file debian/templates/koha-conf-site.xml.in to be more in
line with the koha-conf.xml generated by other installation methods. However
this seems to have introduced some placeholders that are not actually being
replaced when a new instance is created with koha-create. Here is what I see
with recently created instances, both with packages built off uptodate master
and the official 3.8.x packages:

$ sudo grep "__" /etc/koha/sites/bergting/koha-conf.xml
<listen id="publicserver" >tcp:@:__ZEBRA_SRU_BIBLIOS_PORT__</listen>
<listen id="mergeserver">tcp:@:__MERGE_SERVER_PORT__</listen>
    <xi:include href="__KOHA_CONF_DIR__/zebradb/explain-biblios.xml"
            <host>__ZEBRA_SRU_HOST__</host>
            <port>__ZEBRA_SRU_BIBLIOS_PORT__</port>
    <xi:include href="__KOHA_CONF_DIR__/zebradb/explain-authorities.xml"
            <host>__ZEBRA_SRU_HOST__</host>
            <port>__ZEBRA_SRU_AUTHORITIES_PORT__</port>
    <xi:include href="__KOHA_CONF_DIR__/zebradb/explain-biblios.xml"
            <host>__ZEBRA_SRU_HOST__</host>
            <port>__ZEBRA_SRU_BIBLIOS_PORT__</port>
 <!--
<pazpar2url>http://__PAZPAR2_HOST__:__PAZPAR2_PORT__/search.pz2</pazpar2url>
-->

koha-create does these substitutions:

    sed -e "s/__KOHASITE__/$name/g" \
        -e "s/__OPACPORT__/$OPACPORT/g" \
        -e "s/__INTRAPORT__/$INTRAPORT/g" \
        -e "s/__OPACSERVER__/$opacdomain/g" \
        -e "s/__INTRASERVER__/$intradomain/g" \
        -e "s/__ZEBRA_PASS__/$zebrapwd/g" \
        -e "s/__ZEBRA_MARC_FORMAT__/$ZEBRA_MARC_FORMAT/g" \
        -e "s/__ZEBRA_LANGUAGE__/$ZEBRA_LANGUAGE/g" \
        -e "s/__DB_NAME__/$mysqldb/g" \
        -e "s/__DB_HOST__/$mysqlhost/g" \
        -e "s/__DB_USER__/$mysqluser/g" \
        -e "s/__DB_PASS__/$mysqlpwd/g" \
        -e "s/__UNIXUSER__/$username/g" \
        -e "s/__UNIXGROUP__/$username/g" \
        "/etc/koha/$1" > "$2"

So unless I am missing something we should perhaps remove some of the
placeholders from koha-conf-site.xml.in again? 

The slightly weird thing is that all these placeholders do not seem to affect
Koha in any way...

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.