[Koha-bugs] [Bug 7131] way to overlay items in in marc import

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7131

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com

--- Comment #13 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to comment #12)
> Comment on attachment 14475 [details] [review]
> Patch adds the ability to overlay items when Staging
> 
> Review of attachment 14475 [details] [review]:
> -----------------------------------------------------------------
> 
> ::: C4/ImportBatch.pm
> @@ +696,5 @@
> >      $sth->execute();
> >      while (my $row = $sth->fetchrow_hashref()) {
> >          my $item_marc = MARC::Record->new_from_xml(StripNonXmlChars($row->{'marcxml'}), 'UTF-8', $row->{'encoding'});
> > +	#delete date_due subfield as to not accidentally delete item checkout due dates
> > +	$item_marc->field('952')->delete_subfield(code => 'q');
> 
> This is a problem. Not all frameworks will have items.onloan mapped to
> 952$q. We need to look up the problem tag/subtag here using
> C4::Biblio::GetMarcFromKohaField or get the value via
> C4::Biblio::GetRecordValue.

I just realized GetRecordValue will be useless in this scenario, you need to
use GetMarcFromKohaField.
($MARCfield,$MARCsubfield)=GetMarcFromKohaField($kohafield,$frameworkcode);

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.