[Koha-bugs] [Bug 9367] Code optimization: CheckReserves is too often called

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9367

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #3 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
QA Comment:
This looks quite good. Code improvement! koha-qa is happy too :)
A few minor details needing some attention:

1) Circ   $error->{message} = "on_reserve"; Should be just $error= "on_reserve"

2) GetReserveStatus needs some error checking to prevent warnings on
$found/$priority at the end (if there is no reserve) 

3) IsAvailableForItemLevelRequest: the check GetReserveStatus($itemnumber) eq
"W" is replaced by $status eq "Waiting" or $status = "Reserved"
  Please clarify. As I understand, AllowOnShelfHolds is OFF here. So the second
part of the check should be: AND Is it on loan or waiting (current behavior)? 
  You could even argue that you should test only for on loan.. 
  Why do you add Reserved?

Please send a followup. I will gladly sign off on that..

-- 
You are receiving this mail because:
You are watching all bug changes.