[Koha-bugs] [Bug 9367] Code optimization: CheckReserves is too often called

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Mon Mar 11 13:10:02 CET 2013


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9367

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #14544|0                           |1
        is obsolete|                            |
  Attachment #16018|0                           |1
        is obsolete|                            |

--- Comment #11 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 16021
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16021&action=edit
Bug 9367: Code optimization: CheckReserves is too often called

This patch rewrites the GetReserveStatus routine in order to take in
parameter the itemnumber and/or the biblionumber.

In some places, the C4::Reserves::CheckReserves routine is called when
we just want to get the status of the reserve. In these cases, the
C4::Reserves::GetReserveStatus is now called.
This routine executes 1 sql query (or 2 max).

Test plan:
Check that there is no regression on the different pages where reserves
are used. The different status will be the same than before applying
this patch.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list