[Koha-bugs] [Bug 7560] SIP Self Checkout Ignoring Fines Thresholds for Not Being able to Check Out Books

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7560

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Passed QA
                 CC|                            |kyle at bywatersolutions.com
           Assignee|colin.campbell at ptfs-europe. |kyle at bywatersolutions.com
                   |com                         |

--- Comment #13 from Kyle M Hall <kyle at bywatersolutions.com> ---
Paul, is QA Followup 2 what you were asking for?

I don't think GetTotalFines should be renamed GetFines as it does not return a
list, but a scalar.

I've cleaned up the code in the subs you referenced. 

Also, if you want to file a bug for moving the relevant subs from C4::Overdues
to C4::Accounts I'd be more than happy to get care of that as well.

One other thing, it appears that reports/stats.screen.pl and
reports/stats.print.pl are dead code. Am I correct? If so, I'll file a bug to
remove them.

(In reply to comment #8)
> QA comment:
> 
> shouldn't 
> +=head2 GetTotalFines
> +
> +    my $total_fines_owed = GetTotalFines( $borrowernumber );
> +
> +    Returns the total amount owed by the given borrower.
> 
> be in C4/Accounts.pm more than in C4/Overdues.pm ?
> 
> I know there is calcfine and UpdateFine in C4/Overdues.pm, but I think it's
> a mistake !
> 
> 
> If you agree with me and move GetTotalFines to C4/Accounts.pm, you're
> welcomed to factorize getcharges, getcredits, getrefunds, that are Getting
> things in accountlines table. Note this is not requested for earning QA,
> just a suggestion
> 
> You're also welcomed to name your sub GetFines, as GetSomethings() is
> already supposed to return a list of something, so the "Total" is useless

-- 
You are receiving this mail because:
You are watching all bug changes.