[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #25 from Owen Leonard <oleonard at myacpl.org> ---
After applying the patch I no longer see the logged-in user's name at the top
of the screen ("Welcome, ").

This kind of construction is a violation of coding guidelines because it breaks
the translator:

 <option value="1"  [% IF ( BlockExpiredPatronOpacActions == 1   ) %]
selected="selected" [% END %]> Block </option>

http://wiki.koha-community.org/wiki/Coding_Guidelines#HTML1:_Template_Toolkit_markup_inside_HTML

In opac-user.tt:

"Please contact the library if you wish to renew your subscription."

I don't think we use the term "subscription" anywhere in Koha to refer to the
patron's account. I see two variations in the template right now: "card has
expired" and "account has expired." We should pick one of these for
consistency's sake: "renew your card" or "renew your account."

There are a couple of instances of this HTML typo in opac-user.tt:

<string>Please note:</string>

I assume that should be "strong."

Also in opac-user.tt:

You're renew failed

That should be "Your."

In opac-renew.pl:

print $query->redirect("/cgi-bin/koha/opac-user.pl?renew_error=$errorstring");

You can't build an error string (in English) in the script and pass it to the
template for display. This is untranslatable. It's also bad practice to pass
unsanitized data directly to the template .

Also, this patch has a huge amount of whitespace changes that appear to be
unrelated to functional changes. I don't know if that is another cause to fail
the patch, but it sure makes it harder to understand.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.