[Koha-bugs] [Bug 9761] Make it possible to confirm future hold requests at checkin time

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9761

--- Comment #8 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Just some comments on the changed code (making life somewhat easier for QA or
RM most hopefully :)

Main change is in _Findgroupreserve: the where clause is adjusted to optionally
include future reserve dates.

This routine is *only* used in CheckReserves :)
The circulation module calls CheckReserves for transferbook, CanBookBeIssued,
AddReturn, CanBookBeRenewed.
This change is only meant for AddReturn.

When writing this patch, the Search and XSLT module used CheckReserves also for
displaying status information. Bug 9367 converts that to GetReserveStatus,
implicitly supporting this change too. Note that bug 9788 makes some
adjustments on top of that, improving item status for future waits.

In the Reserves module, CheckReserves is used by GetOtherReserves (when
confirming the hold: but you first need to recognize it!) and MoveReserve (for
checkout: not relevant here). 

The call of CheckReserves after calling CanBookBeRenewed in circulation.pl is
somewhat dubious.
The calls in opac-user.pl and opac-detail.pl are also for displaying status
info (see above with reference to the other reports again).

-- 
You are receiving this mail because:
You are watching all bug changes.