[Koha-bugs] [Bug 8365] Renewal duration in issuingules

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365

--- Comment #21 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to comment #20)
> Hi Jonathan, 
> the new unit tests don't pass the QA script - can you take a look please? 
> But I will continue testing :)
> 
> * t/db_dependent/Circulation_issuingrules.t    FAIL
> 	pod                         OK
> 	forbidden patterns          OK
> 	valid                       OK
> 	critic                      FAIL
> Code before strictures are enabled at line 11, column 1. See page 429 of PBP.

It is caused by the "use Modern::Perl;".
You should add to your ~/.perlcriticrc :
  [TestingAndDebugging::RequireUseWarnings]
  equivalent_modules = Modern::Perl

  [TestingAndDebugging::RequireUseStrict]
  equivalent_modules = Modern::Perl

Take a look at the perlcriticrc file present in the qa-tools repository.

-- 
You are receiving this mail because:
You are watching all bug changes.