[Koha-bugs] [Bug 8220] Allow koc uploads to go to process queue instead of being applied directly.

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8220

--- Comment #22 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Comment on attachment 12310
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12310
Bug 8220 - Allow koc uploads to go to process queue instead of being applied
directly.

Review of attachment 12310:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=8220&attachment=12310)
-----------------------------------------------------------------

Hi Kyle,

I started testing with some code review to see what you have done here - I
found some smaller issues. A follow-up resolving them would be good.

::: C4/Circulation.pm
@@ +3334,5 @@
> +    my $amount = $operation->{amount};
> +
> +    recordpayment( $borrower->{borrowernumber}, $amount );
> +
> +    return "Success."

Untranslatable string.

::: installer/data/mysql/updatedatabase.pl
@@ +5830,5 @@
> +$DBversion = "3.09.00.XXX";
> +if (C4::Context->preference("Version") < TransformToNum($DBversion)) {
> +    $dbh->do("ALTER TABLE `pending_offline_operations` CHANGE `barcode` `barcode` VARCHAR( 20 ) CHARACTER SET utf8 COLLATE utf8_general_ci NULL DEFAULT NULL");
> +    $dbh->do("ALTER TABLE `pending_offline_operations` ADD `amount` DECIMAL( 28, 6 ) NULL DEFAULT NULL");
> +    print "Upgrade to $DBversion done (redefine the field branchcode as PRIMARY KEY of branches)\n";

Wrong text in update message.

::: koha-tmpl/intranet-tmpl/prog/en/modules/offline_circ/enqueue_koc.tt
@@ +17,5 @@
> +
> +[% FOREACH message IN messages %]
> +  [% IF ( message.message ) %]
> +      [% IF ( message.ERROR_file_version ) %]
> +          <div class="dialog alert"><p>Warning: This file is version [% message.upload_version %], but I only know how to import version [% message.current_version %]. I'll try my best.</p>

Missing </div>

::: offline_circ/enqueue_koc.pl
@@ +18,5 @@
> +# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
> +#
> +
> +use strict;
> +use warnings;

Maybe better use Modern::Perl?

-- 
You are receiving this mail because:
You are watching all bug changes.