[Koha-bugs] [Bug 9457] Ordering branches should be case independent (2)

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9457

--- Comment #5 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
(In reply to comment #4)
> I just found a little (big?) stuff. You forget to test (at several places)
> if C4::Context->userenv exists before to access to the 'branch' key.
> Sometimes this hashref (C4::Context->userenv) is not defined and the user
> get a software error. I think there is just one case: if the insecure
> syspref is turn ON.

Good point. I was not aware of this syspref, and do not check that there is a
possibility that userenv could return undef.

> *But* I suppose this feature is broken, so are there actually someone using
> it?
> (I suppose that because of there are already several places where this test
> does not exist (e.g. reserve/request.pl)).

It is broken. After turned on, could not display staff login page.
Must revert value on database. 

> So there are 2 possibilities:
> 1/ You send a mail to koha-devel in order to know if this feature can be
> deleted (in this case, we open a new report for that).
> 2/ You submit a followup taking account of this syspref.
> 
I think is better to do both, to disentangle the feature and this bug.
I'll send a mail to koha-devel and add a followup, just in case :)

-- 
You are receiving this mail because:
You are watching all bug changes.