[Koha-bugs] [Bug 9554] single quote in didyoumean

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9554

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #15177|0                           |1
        is obsolete|                            |

--- Comment #7 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 16264
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16264&action=edit
Bug 9554: single quote in didyoumean

When using "url" or "uri" template toolkit filters, I noticed that double
quotes are escaped (%22), but not single quotes.
This causes sometimes a problem when URL is written in JavaScript code, in a
string delimited by single quotes.

This patch corrects by using double quotes for js strings.
Also, adds a test for "didyoumean" feature : when feature is not activated, do
not add corresponding javascript.

Test plan :
- activate OpacHighlightedWords syspref
- activate "didyoumean" feature for OPAC
- perform a search begining with a  single quote (ie "'sport")
=> look for javascript errors (you may use firebug)

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.