[Koha-bugs] [Bug 9692] Add a checkbox to display statistical fields in basket.tt

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9692

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m
   Patch complexity|---                         |Small patch

--- Comment #5 from Jonathan Druart <jonathan.druart at biblibre.com> ---
QA comment:

There are 3 issues:
1/ The columns does not hide if I unselect the new checkbox
+            [% IF ( listincgst ) %]
+                $("table .statistics").hide();
+            [% ELSE %]
+                $("table .statistics").hide();
+            [% END %]

2/ If these fields (sort1 and sort2) are linked to an authorized value, the
description should be displayed, not the code.

3/ 2 withespaces:
 * koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt  FAIL
  forbidden patterns  FAIL
    The patch introduces a forbidden pattern: withespace character  (43)
    The patch introduces a forbidden pattern: withespace character  (35)

Marked as Failed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.