[Koha-bugs] [Bug 6874] File upload in MARC

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
         QA Contact|koha-bugs at lists.koha-commun |paul.poulain at biblibre.com
                   |ity.org                     |

--- Comment #57 from Paul Poulain <paul.poulain at biblibre.com> ---
QA comment: sorry, another failed QA, because of koha-qa/perlcritic
complaining:

 * opac/opac-retrieve-file.pl                                              
FAIL
    critic                      FAIL
        Bareword file handle opened at line 35, column 5. See pages 202,204 of
PBP.
 * cataloguing/value_builder/upload.pl                                     
FAIL
    critic                      FAIL
        Glob written as <...> at line 143, column 17. See page 167 of PBP.


However, i've uploaded rebased patches with a 3rd perlcritic error fixed, I let
you fix those 2.

Once follow-up uploaded, switch back to signed off

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.