[Koha-bugs] [Bug 9845] New: SIP tests : fix in 08checkin.t ("alert" field)

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9845

            Bug ID: 9845
           Summary: SIP tests : fix in 08checkin.t ("alert" field)
    Classification: Unclassified
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: trivial
          Priority: P5 - low
         Component: SIP2
          Assignee: adrien.saurat at biblibre.com
          Reporter: adrien.saurat at biblibre.com
                CC: colin.campbell at ptfs-europe.com

[MT10401]
An error occurs while trying the checkin SIP test, 08checkin.t:
08checkin.t ........... 4/5 
#   Failed test 'match leader Checkin: Item not checked out'
#   at /home/asaurat/workspace/versions/community/C4/SIP/t/SIPtest.pm line 204.
# Response '100YNY20130319    142702AOVIL|AB1783B|AQVIL|AJL ANGOISSE DU ROI
SALOMON|CS362.6 AJA|AFItem not checked out|AY5AZE097' doesn't match pattern
'(?-xism:^100YNN\d{8} {4}\d{6})'

We are trying to do a checkin operation on a document which is not checked out.
Koha sends a code 100, meaning "Checkin failed". As expected.
The three following characters are:
- resensitize
- magnetic media
- alert
And we have a difference on the "alert" character. Koha sends Y, and the test
expects N.

Description of the "alert" field in the SIP2 documentation from 3M:
1-char, fixed-length field: Y or N. A Y in the alert field will generate an
audible sound at the
SC. The alert will indicate conditions like articles on hold, articles
belonging to another library
branch, or other alert conditions as determined by the ACS. The alert signal
will alert the
library staff to special article handling conditions during discharging
operations.

As we are testing a case where a problem is occuring (how could a patron check
in if the item was not checked out?!), I actually think that the "alert" should
be expected by the test, leading to a pattern like "^100YNY".
But maybe is this "alert" actually outside of the scope of this test, the
important result being that the string begins with "100". Thus the checking
pattern could be "^100YN[NY]".

I'll make a patch with the latest solution, but it's of course open to
discussion, as I'm not 100% sure about how this test is supposed to react.

-- 
You are receiving this mail because:
You are watching all bug changes.