[Koha-bugs] [Bug 9737] Local Covers sometimes appear then disappear on OPAC Search Results/Lists

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9737

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #6 from David Cook <dcook at prosentient.com.au> ---
(In reply to comment #5)
> (In reply to comment #4)
> > This seems to work fine, but I would rather sign off on a version that
> > didn't include the biblionumber in a title attribute here:
> > 
> > <span title="[% SEARCH_RESULT.biblionumber %]" 
> > 
> > That looks like debugging information to me. It's certainly not relevant to
> > the user.
> 
> Hi Owen:
> 
> I was just following the convention already set out by the LocalCoverImages
> and GoogleJackets code. They both have  <span title="[%
> SEARCH_RESULT.biblionumber |url %]" in the templates. 
> 
> I agree that this information isn't relevant to the user and I don't know of
> any code that relies on it, so perhaps a follow-up patch removing all 3
> instances of this span title is in order?

OpenLibraryCovers also has a span title with biblionumber. 

GoogleJackets and OpenLibraryCovers have classes with the normalized ISBN in
them. LocalCoverImages has a class with the biblionumber in it. 

Seems like these links have all sorts of seemingly meaningless information
which could be removed.

But...I don't really want to break anything, my code is reasonably consistent,
and it doesn't hurt anything now, so I'll leave a follow-up to someone else and
change the status of this bug back to Needs Signoff. 

This patch doesn't introduce anything that isn't already there.

-- 
You are receiving this mail because:
You are watching all bug changes.