[Koha-bugs] [Bug 9504] URL escape in OPAC more searches

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9504

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #15019|0                           |1
        is obsolete|                            |

--- Comment #3 from Mason James <mtj at kohaaloha.com> ---
Created attachment 16446
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16446&action=edit
Bug 9504: URL escape in OPAC more searches

OPACSearchForTitleIn is a syspref used to add links as "more searches" in OPAC
record detail page.
The links can contain vars depending on record values like title, ISBN, ...
Thoses values must be URL-escaped because they can contain special characters
that will brake URL and/or HTML.

This patch add a method C4::Output::parametrized_url() that replaces vars in
URL usign escape and UTF-8 encoding.

Test plan :
- Define in OPACSearchForTitleIn a link with all possible vars : TITLE, AUTHOR,
ISBN, ISSN, CONTROLNUMBER, BIBLIONUMBER
- Edit a record to add special characters in title : ", &, ? ...
- Go to OPAC detail pages of this record
=> Check that URL is well encoded
=> Click on link to check the term is well encoded (diacritical characters,
...)

Signed-off-by: Liz Rea <liz at catalyst.net.nz>
Nice test plan, thanks!

Verified bug and fix - both look good.
Signed-off-by: Mason James <mtj at kohaaloha.com>

-- 
You are receiving this mail because:
You are watching all bug changes.