[Koha-bugs] [Bug 9780] Deleting a record suppress bibliographic info in orders using that record

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9780

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
         QA Contact|                            |paul.poulain at biblibre.com

--- Comment #13 from Paul Poulain <paul.poulain at biblibre.com> ---
QA comment:
 * passes koha-qa.pl, great
 * works as advertised, great

However, some QA comments:
* lines like
+my $count_orders_using_biblio = scalar @orders_using_biblio ;
+$template->param (countorders => $count_orders_using_biblio);
can be removed = the .size pragma in template toolkit will achieve the same
result.

$template->parameters(orders_using_biblio => @orders_using_biblio)
then in the template, just use [% orders_using_biblio.size %]

* lines related to affecting T::T can be merged. Instead of
+$template->param (basketsorders => \@baskets_orders);
+$template->param (basketsdeletedorders => \@baskets_deletedorders);
write
+$template->param (basketsorders => \@baskets_orders,
+                  basketsdeletedorders => \@baskets_deletedorders);

* instead of
Number of order(s) using this title: X active order(s) in basket(s) #NN, #PP
write
Order(s) using this title: X (basket #NN, ##PP)

* the reason why I failed QA this patch : it adds a sub in C4/Acquisitions.pm,
but no unit test is provided for it.

-- 
You are receiving this mail because:
You are watching all bug changes.