[Koha-bugs] [Bug 9728] XISBN use simple search instead of SQL

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Thu Mar 21 14:56:51 CET 2013


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9728

--- Comment #6 from Paul Poulain <paul.poulain at biblibre.com> ---
Created attachment 16633
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16633&action=edit
Bug 9728: XISBN use simple search instead of SQL

XISBN API uses normalized ISBN of a biblio to get a list of ISBNs, then
searches via SQL in database for notices with those ISBNs.

I noticed that if input ISBN has hyphens then returned ISBNs have hyphens else
they don't have. So SQL query will not find if ISBNs have hyphens in database.
Also, if biblio has several ISBN, only first one can be found with actual SQL
query (isbn LIKE '$xisbn%').

This patch replaces SQL query by a simple search "nb=$xisbn". This will find
biblio from ISBN with or without hyphen.

Test plan :
- Activate FRBRizeEditions and XISBN sysprefs
- Go to a biblio witch has several editions
- Note its normalized ISBN (you may look in amazon links)
- Replace [ISBN] by biblio normalized ISBN in this URL :
http://xisbn.worldcat.org/webservices/xid/isbn/[ISBN]?method=getEditions&format=xml&fl=form,year,lang,ed
- Go to this URL and see which ISBNs are returned
- Perform a simple search on thoses ISBNs : nb:1234567890
- Look at "Editions" tab
=> Check that diplayed biblios are the same you found by simple search

Signed-off-by: jmbroust <jean-manuel.broust at univ-lyon2.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list