[Koha-bugs] [Bug 9673] Track when items are marked as lost or withdrawn

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9673

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #19 from Jonathan Druart <jonathan.druart at biblibre.com> ---
QA comment:
Just looking at the code:
If itemlost *and* wthdrawn are defined, we will have 2 calls to GetItem. It
could be improve if a test is added before the loop.

Something like:
if ( $item->{itemlost} or $item->{wthdrawn} ) {
 my $pre_mod_item = GetItem($item->{'itemnumber'});
 for my $field ( qw( itemlost wthdrawn ) ) {
     if ( defined( $item->{$field} ) ) {

Marked as Failed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.