[Koha-bugs] [Bug 906] ISBN Check

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=906

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |katrin.fischer at bsz-bw.de,
                   |                            |paul.poulain at biblibre.com
         QA Contact|                            |paul.poulain at biblibre.com

--- Comment #6 from Paul Poulain <paul.poulain at biblibre.com> ---
QA comment:
* I think I should fail QA the patch as it is written : there is a plugin/value
builder system in Koha, that is used for a lot of things, like coded fields,
but not only. Why didn't you use this system ? It would not need to check
between MARC21/UNIMARC/NORMARC, and no need of a syspref. look in
cataloguing/value_builder/, where plugins are. The addbiblio.pl part could
easily be ported to value_builder_checkisbn.pl, so the change should not be too
hard to do.

* passes koha-qa.pl

failing QA, but asking katrin's opinion, as she's the QA manager.

-- 
You are receiving this mail because:
You are watching all bug changes.