[Koha-bugs] [Bug 906] ISBN Check

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=906

--- Comment #7 from Jared Camins-Esakov <jcamins at cpbibliography.com> ---
(In reply to comment #6)
> QA comment:
> * I think I should fail QA the patch as it is written : there is a
> plugin/value builder system in Koha, that is used for a lot of things, like
> coded fields, but not only. Why didn't you use this system ? It would not
> need to check between MARC21/UNIMARC/NORMARC, and no need of a syspref. look
> in cataloguing/value_builder/, where plugins are. The addbiblio.pl part
> could easily be ported to value_builder_checkisbn.pl, so the change should
> not be too hard to do.
> 
> * passes koha-qa.pl
> 
> failing QA, but asking katrin's opinion, as she's the QA manager.

I don't think a check like this can be done with a value_builder plugin. If I
am wrong, a value_builder plugin would definitely be better, but the plugins
aren't -- so far as I understand -- used for validation but rather as helpers
for setting fields.

-- 
You are receiving this mail because:
You are watching all bug changes.