[Koha-bugs] [Bug 9894] New: de-serialize the 'hidden' value for subfields in frameworks

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9894

            Bug ID: 9894
           Summary: de-serialize the 'hidden' value for subfields in
                    frameworks
    Classification: Unclassified
 Change sponsored?: ---
           Product: Koha
           Version: 3.14
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: gmcharlt at gmail.com
          Reporter: tomascohen at gmail.com

The 'hidden' value is a serialization of several possible visualizatio
combinations
(http://manual.koha-community.org/3.8/en/catadmin.html#marcbibframeworks). This
way of handling is troublesome for:

- The code (difficult to read, difficult to find bugs)
- The users (instead of simple checkboxes they need to read the docs, looking
for a weird number.

Several bugs about this 'hidden' option are related to some math on the
'hidden' value. I propose to change that field for  'vis_opac' |' vis_intranet'
| 'vis_editor' | 'collapsed', all of them YesNo values.

This will require a lot of rewrite in code like this:

next if ( ($sf_def->{hidden}||0) > 0 );

or this:

next if ( $tagslib->{ $fields[$x_i]->tag() }->{'@'}->{hidden} =~
/-7|-4|-3|-2|2|3|5|8/);

-- 
You are receiving this mail because:
You are watching all bug changes.