[Koha-bugs] [Bug 7740] Highlight items in own library in search results/detail page in OPAC

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7740

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #14 from Paul Poulain <paul.poulain at biblibre.com> ---
Test plan:
 * apply the patch
 * activate the syspref  HighlightOwnItemsOnOPAC  to <<emphasize>>  results
from the <<patron home branche>> by moving the results to the front and
increasing the size or highlighting the rows for those results. 
 * go to OPAC, and login
 * search for a biblio that has at least 2 items, one at patron branch, one
not.
 * in the result list, the item from patron branch is highlighted, the other
one isn't
 * in the detail page, same thing

QA comment:
 * the css addition was missing to ccsr theme, i've added it in a follow-up
 * this patch adds a my $branches = GetBranches() in opac-detail. This has also
been introduced later, resulting in a perlcritic error. I've fixed it in
another follow-up
 * work fine, clean code.
 * tested with and without XSLT. with XSLT, the opac-detail is OK, but the
result IS NOT. Looking at
koha-tmpl/opac-tmpl/prog/en/xslt/MARC21slim2OPACResults.xsl, it appears that
there is no code to handle this syspref. Please fix & resubmit (and do that for
MARC21, NORMARC & UNIMARC please, should be easy once you've made it for
MARC21, should be easy to do it for others). I think it's

-- 
You are receiving this mail because:
You are watching all bug changes.