[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Comment on attachment 16456
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16456
Bug 7677: New areas in subscriptions and new functions when receiving.

Review of attachment 16456:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=7677&attachment=16456)
-----------------------------------------------------------------

This feature will have to wait for 3.14, but I did take a look at the code
today and wanted to leave some notes.

::: C4/Serials.pm
@@ +45,4 @@
>        &ReNewSubscription  &GetLateIssues      &GetLateOrMissingIssues
>        &GetSerialInformation                   &AddItem2Serial
>        &PrepareSerialsData &GetNextExpected    &ModNextExpected
> +      &GetPreviousSerialid

Needs a unit test!

::: installer/data/mysql/updatedatabase.pl
@@ +6570,5 @@
> +    print "Upgrade to $DBversion done (added new syspref: serialsFieldsToAV)\n";
> +    SetVersion($DBversion);
> +}
> +
> +

Database updates should be merged into 1 update with a nice description.

::: koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt
@@ +75,5 @@
>  	subfieldid = "subfield" + itemid.substr(4) + "h";
>  	// Setting text field 
>  	$("#" + subfieldid + " input[type='text']").val($("#serialseq" + serialId).val());
> +        // Also prefilling 995$l
> +        subfieldid = "subfield" + itemid.substr(4) + "l";

This looks like it's UNIMARC specific?

::: serials/subscription-add.pl
@@ +193,5 @@
> +    previoustypeloop         => \@previoustypearg,
> +    supportloop              => \@supportarg,
> +    originloop               => \@originarg,
> +    domainloop               => \@domainarg,
> +    DHTMLcalendar_dateformat => C4::Dates->DHTMLcalendar(),

DHTMLcalendar is no longer used.

-- 
You are receiving this mail because:
You are watching all bug changes.